[PAID] [$250] Editing date of an IOU details marks the main report as unread even though there is no new message in the main report

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open an existing chat with user B
2. Click on '+' icon > click on 'Request money'
3. Enter amount & click on 'Next' button
4. Click on 'Request' button
5. Open a tab where user B is signed in
6. Open the main report or chat with user B, make sure that it is marked as read, and open chat with Concierge
7. Open a tab where user A is signed in
8. Click on IOU preview component
9. Click on IOU preview component of IOU thread report
10. Click on 'Date' field
11. Click on year dropdown menu
12. Select another date that is in the past & click on 'Save' button
13. Open a tab where user B is signed in

Expected Result:

The main report with user A shouldn't be marked as unread since there is no new message in the report

Actual Result:

The main report with user A is marked as read

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-08-14.20-21-51.mp4

Recording.1336.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Natnael-Guchima

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692034383213899

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01163f580e40dfceb5
• Upwork Job ID: 1696674689918205952
• Last Price Increase: 2023-12-04

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[strepanier03]

@dangrous - Would you please attempt to repro this on DEV for me? I do not have a DEV environment to test.

Thank you for your help!

[Natnael-Guchima]

This is now reproducible on staging too @strepanier03.

[dangrous]

@strepanier03 let me know if you can reproduce on staging - if not I can try on dev!

[strepanier03]

@Natnael-Guchima - Thanks for the heads up.

@dangrous - Sure thing, I'm testing now and I'll let you know.

[strepanier03]

@dangrous - I am unable to repro this on staging. @Natnael-Guchima - What device and browser/app are you able to repro on staging.

I attempted on Mac/Chrome and the chat doesn't become unread for me.

[dangrous]

Okay confirmed that this happens on Dev!

I'm not 100% convinced it's a bug since the request DID change, but it didn't change visibly in the parent report so probably worth looking into

[strepanier03]

Thank you @dangrous - I will move this forward.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01163f580e40dfceb5

[melvin-bot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[sofi-a]

@Natnael-Guchima @dangrous @strepanier03 It looks like the last expense modification appears as a new message. Don't we consider expense modifications as report messages?

[melvin-bot]

📣 @sofi-a! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sofi-a]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~013c73af4810229810

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[DylanDylann]

It seems like a BE Bug. The BE return new lastVisibleActionCreated for main report when editing date

[dangrous]

@sofi-a so that part should be unread; it's the parent report that's getting marked that (maybe) shouldn't - i.e. the original chat, not the request itself. Does that make sense? Let me know if I need to explain in a different way!

[mountiny]

I think these have not been migrated to Auth yet

[dangrous]

Okay cool. So how do we feel about:

1. Create a PR to update this in Auth to not mark the parent report as read
2. And only THEN creating a new PR in Web-E (Solution TBD) to fix the Pusher event not to update LHN.

Technically that might have the very slightly confusing behavior (in the video) for a little while until we figure out the solution to # 2 but I think that's okay? Let me know if that sounds good to you.

[mountiny]

responded in the slack thread

[dangrous]

Responded in thread ;) https://expensify.slack.com/archives/C03U7DCU4/p1699574447577749?thread_ts=1698343200.916719&cid=C03U7DCU4

[melvin-bot]

@dangrous, @strepanier03, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@dangrous, @strepanier03, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@dangrous, @strepanier03, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

We're good Melvin 😂 - three times is plenty.

I'll continue following along.

[dangrous]

Auth PR is merged, not yet on prod. Technically this bug is fixed once that's deployed but we should keep this open for the Pusher/Web-E fix. I'll look into that now but I might shift this issue to weekly since it's just a small part left (unless anyone objects?).

[dangrous]

Welp, can't quite figure this out yet. It's this Onyx update but I can't figure out which part exactly is sending the LHN update (vs. updating the money request). There's a chance this might be an App/frontend issue instead of Web-E?

[dangrous]

Okay Web-E PR that should fix that LHN issue is up! Once that's deployed, i think we're good to close.

[strepanier03]

Got it, thanks @dangrous. I'll follow along to action once the PR is done.

[dangrous]

web-e is still on staging, should hopefully get to production soon!

[dangrous]

I think we're all set! @strepanier03 do you have a moment to re-test, and then handle any payment (this has gone on so long I'm not sure who needs what haha)

[dangrous]

Bump on the above payment when you have time, thank you!

[strepanier03]

Sorry, this didn't have the normal naming convention for a GH awaiting payment so I missed it was ready. Reviewing this now.

[strepanier03]

@dangrous - I'm also a little unsure who is owed what here so I'll break down what I found and perhaps some others can weigh in as well.

• Report by @Natnael-Guchima (Contributor) so $250 owed there (pre-change)
• PR for 1st change here - assignees were all internal Expensify folks
• PR for 2nd change here - assignees were all internal Expensify folks
• @fedirjh was the C+ assigned, but I don't see them on any PRs so I'm not sure if they reviewed anything and need payment. If you do @fedirjh can you link to what I missed and confirm you're owed payment?
• The fix was done internally so I don't think we need to pay anyone for that part.

Soooo, I think the payment summary is as below:

• Reporting bonus - @Natnael-Guchima - $50
• Contributor - N/A - Done internally
• Review (C+) - N/A - Done internally

@fedirjh @dangrous - Did I miss anything?

[fedirjh]

@strepanier03 I think that's correct, but I guess the reporting bonus should be $250 as it was reported before Aug 31 ?

[strepanier03]

Thank you @fedirjh - I appreciate you weighing in and for the reminder I didn't' realize this was so old but you're 100% right.

I'll move forward with payment and finishing this up.

[strepanier03]

@Natnael-Guchima - I've hired you to the job, please accept when you can and I'll pay it out.

[melvin-bot]

Upwork job price has been updated to $250

[Natnael-Guchima]

I have accepted the offer. Thanks @strepanier03

[strepanier03]

All right, this is paid out. Closing!