[HOLD for payment 2023-09-29] [$1000] Web - Selecting a user in the new group member search, a message 'No results found' is displayed.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Click FAB button
2. Click new group
3. Search any email and select, Observe that the message "No results found" appears

Expected Result:

Message "No results found" does not appears after select user

Actual Result:

Message "No results found" appears after select user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.57.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-19.at.20.47.50.mov

Recording.4052.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692453168520689

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01868e8617d1a2f9e1
• Upwork Job ID: 1696632090628845568
• Last Price Increase: 2023-08-29
• Automatic offers:
• s77rt | Reviewer | 26742716
• namhihi237 | Contributor | 26742717
• namhihi237 | Reporter | 26742719

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no error message after selecting the member in the search result

What is the root cause of that problem?

In the function getHeaderMessage we have added the param hasMatchedParticipant to check if the selected user has matched the search in here
But we do not pass it in:

App/src/pages/NewChatPage.js

Lines 57 to 62 in 08b75f3

	const headerMessage = OptionsListUtils.getHeaderMessage(
	filteredPersonalDetails.length + filteredRecentReports.length !== 0,
	Boolean(filteredUserToInvite),
	searchTerm,
	maxParticipantsReached,
	);

What changes do you think we should make in order to solve the problem?

We should pass the param in the function getHeaderMessage:

    const headerMessage = OptionsListUtils.getHeaderMessage(
        filteredPersonalDetails.length + filteredRecentReports.length !== 0,
        Boolean(filteredUserToInvite),
        searchTerm.trim(),
        maxParticipantsReached,
        _.some(selectedOptions, (participant) => participant.searchText.toLowerCase().includes(searchTerm.trim().toLowerCase())),
    );

What alternative solutions did you explore? (Optional)

N/A

[tjferriss]

I'm able to reproduce the issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01868e8617d1a2f9e1

[melvin-bot]

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@namhihi237 Thanks for the proposal. Your RCA is correct and the solution looks good to me.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

Not overdue. @neil-marcellini ^

[s77rt]

@neil-marcellini ^

[tjferriss]

@s77rt what exactly do you need from @neil-marcellini?

[s77rt]

@tjferriss To review the approved proposal and assign the contributor if agreed.

[melvin-bot]

@tjferriss @s77rt @neil-marcellini this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[neil-marcellini]

@parasharrajat I think #27658 should be treated as a duplicate since it's so similar, and we should fix that issue with @namhihi237's PR too.

[namhihi237]

Sure @neil-marcellini @s77rt I will include it in the PR

[c3024]

@neil-marcellini Could you consider giving bug report bounty for the issue #27658?

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @namhihi237, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @namhihi237 got assigned: 2023-09-18 23:47:40 Z
• when the PR got merged: 2023-09-20 07:48:57 UTC

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix select show no result found #27729

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @namhihi237 requires payment offer (Contributor)
• @namhihi237 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: New group can't search an email if it's a substring of a selected email #23982
• The offending PR has been commented on: New group can't search an email if it's a substring of a selected email #23982 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No

[tjferriss]

Payment Summary:

• @s77rt Reviewer $1500
• @namhihi237 Contributor $1500
• @namhihi237 Reporter $250

Both team members are eligible for the 50% speed bonus

[melvin-bot]

@tjferriss, @s77rt, @neil-marcellini, @namhihi237 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[neil-marcellini]

Clearing overdue

[tjferriss]

All payments have been sent via Upworks. Closing!

[parasharrajat]

It is worth mentioning that there was a regression from the PR of this issue #27864

[s77rt]

@parasharrajat Oh right! Thanks for bringing this up!

@tjferriss The paymend here should be $500. I have refunded the $1000.