[HOLD for payment 2023-09-21] [$500] Dev: Web - Console error on request money thread

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon and select request money option
2. Enter amount and click on Next button
3. Click on any user and request money
4. Go to request money thread

Expected Result:

It should not show any console error

Actual Result:

Console error appears (Warning: Failed prop type: Invalid prop source supplied to Image, expected one of type [number].)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.57.5
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-22.at.10.11.39.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692679550499059

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01157770cac8c77081
• Upwork Job ID: 1696964639125438464
• Last Price Increase: 2023-08-30
• Automatic offers:
• shubham1206agra | Contributor | 26442047
• gadhiyamanan | Reporter | 26442049

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

should not show any console error

What is the root cause of that problem?

We are passing the source prop of Image wrong here:

App/src/components/ReportActionItem/MoneyRequestView.js

Lines 98 to 100 in c029dc5

	<Image
	pointerEvents="none"
	source={EmptyStateBackgroundImage}

What changes do you think we should make in order to solve the problem?

source={{uri: EmptyStateBackgroundImage}}

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error for opening a report of money request view

What is the root cause of that problem?

It persists after this PR merged where the image source is passed as a string which should be the either number or object.
https://github.com/Expensify/App/pull/22562/files#diff-53a3b5c2e20375a2d0d3a700bd76dab7791ddc968e942d510a9e06572dc0e26fR57

App/src/components/Image/imagePropTypes.js

Lines 10 to 17 in 7b5fadf

	source: PropTypes.oneOfType([
	PropTypes.number,
	PropTypes.shape({
	uri: PropTypes.string.isRequired,
	// eslint-disable-next-line react/forbid-prop-types
	headers: PropTypes.object,
	}),
	]).isRequired,

What changes do you think we should make in order to solve the problem?

We need to pass it as an object by setting its uri property.
source={{uri: EmptyStateBackgroundImage}}

App/src/components/ReportActionItem/MoneyRequestView.js

Line 120 in 7b5fadf

source={EmptyStateBackgroundImage}

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

DEV: console error on request money thread

What is the root cause of that problem?

This is due to difference in Image Resolver for web and native devices. RNWeb also accepts string as a source

What changes do you think we should make in order to solve the problem?

Add platform dependent types for source (example below, not exact)

const sourceType = Platform.select({
    web: [
        PropTypes.number,
        PropTypes.shape({
            uri: PropTypes.string.isRequired,
            // eslint-disable-next-line react/forbid-prop-types
            headers: PropTypes.object,
        }),
        PropTypes.string,
    ],
    default: [
        PropTypes.number,
        PropTypes.shape({
            uri: PropTypes.string.isRequired,
            // eslint-disable-next-line react/forbid-prop-types
            headers: PropTypes.object,
        }),
    ],
});

What alternative solutions did you explore? (Optional)

[sonialiap]

Reproducible, triaging to external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01157770cac8c77081

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

I see. let's fix all instances of this issue in the codebase. @namhihi237's proposal looks good to me.

Note: As this issue is a quick one, the root cause was obvious. But please be sure to properly explain your root cause and solution. Always, remember you are talking to a person through comment.

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[shubham1206agra]

@parasharrajat There's a slight problem with the approach approved by you.

See this in the iOS native.

Can you please re-review the proposal?

[parasharrajat]

@shubham1206agra Can you explain the problem?

[shubham1206agra]

The problem is that native and web uses different resolvers for image source resolution
On the web we see a string URL as a source but on native we see a number as source

So your selected solution will cause prop error but now on native

[shubham1206agra]

See this

[parasharrajat]

Thanks for pointing that out @shubham1206agra.

[shubham1206agra]

@parasharrajat Can you review the proposal again in this case, please?

[parasharrajat]

So I looked further into the problem and I think that there could be two easy solutions.

1. We use RN's image component instead of our custom `Image.
2. Add different types mentioned for different platforms.

1st has a drawback of caching so the second seems fine.

@shubham1206agra's proposal seems to be the first which does not cause any errors. Taking back my previous decision.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix image props for web #26452

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @shubham1206agra requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Just a prop warning.
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Just a prop warning.
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Just a prop warning.
• [@parasharrajat] Determine if we should create a regression test for this bug. No
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[sonialiap]

@parasharrajat are we writing a regression test for this?

[sonialiap]

Payments

@parasharrajat review + bonus = $750 - please request in NewDot
@shubham1206agra fix + bonus = $750 - paid ✔️
@gadhiyamanan report = $250 - paid ✔️

[gadhiyamanan]

@sonialiap offer accepted. i think reporting bonus should be $250 because it was logged before 30 Aug (before announcement)

[sonialiap]

@gadhiyamanan agreed, thanks for pointing out that Melvin miscounted. I'm correcting that to $250 for the reporting

[sonialiap]

@parasharrajat bump on the regression test question (are we writing one for this issue?)

[parasharrajat]

@sonialiap I don't think regression tests are needed for this issue. It was just a console warning.

[melvin-bot]

@sonialiap, @parasharrajat, @thienlnam, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thienlnam]

Agreed - seems like we're just waiting on NewDot payout before closing this one out?

[melvin-bot]

@sonialiap, @parasharrajat, @thienlnam, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

Thanks for confirming that we don't need a regression test. In that case I'm closing out the issue since we do not need to keep the issue open for payout via NewDot

[parasharrajat]

Payment requested as per #26092 (comment)

[JmillsExpensify]

$750 payment approved for @parasharrajat based on BZ summary.