[HOLD for payment 2023-10-13] [$500] Inconsistensy Bug - vertical scroll Bar

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to settings and check every page in it whether it have a vertical scroll bar or not when the screen is minimized

Expected Result:

Vertical scroll bar should exist in every page inside the settings pages when ever they are needed

Actual Result:

Vertical scroll bar is not appearing in the "workspace" and "preference" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

BR.69.mp4

2023-08-28.16.58.56.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Yokabdk

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692400662129409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01228f2da341ad6648
• Upwork Job ID: 1703887623625846784
• Last Price Increase: 2023-09-18
• Automatic offers:
• 0xmiroslav | Reviewer | 26956698
• samh-nl | Contributor | 26956699
• Yokabdk | Reporter | 26956701

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Vertical scroll bar is inconsistently shown.

What is the root cause of that problem?

We set showsVerticalScrollIndicator={false} in ScrollView:

App/src/components/IllustratedHeaderPageLayout.js

Lines 56 to 58 in 08c2f5d

	<ScrollView
	contentContainerStyle={safeAreaPaddingBottomStyle}
	showsVerticalScrollIndicator={false}

This also affects a few other locations: StaticHeaderPageLayout and LHNOptionsList.

What changes do you think we should make in order to solve the problem?

Set it to true (default value) or false everywhere to make it consistent. However, we have to make sure that this is not an intentional setting here.

What alternative solutions did you explore? (Optional)

N/A

[MitchExpensify]

checking on a related issue here: #23609 (comment)

[melvin-bot]

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Bumped the Q in the related issue: #23609 (comment)

[melvin-bot]

@MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

@marcochavezf tagging you hear as you worked on the related issue above. Should there should be scrollbars on all pages?

[melvin-bot]

@MitchExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@MitchExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

@marcochavezf tagging you hear as you worked on the related issue above. Should there should be scrollbars on all pages?

Friendly bump on this question @marcochavezf 🙇

[melvin-bot]

@MitchExpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

We should have a vertical scroll bar on every tab of the settings pages

[melvin-bot]

📣 @Yokabdk 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[0xmiros]

@samh-nl when is PR ready?

[samh-nl]

Currently working on the PR

[melvin-bot]

🎯 ⚡️ Woah @0xmiroslav / @samh-nl, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @samh-nl got assigned: 2023-09-30 14:11:01 Z
• when the PR got merged: 2023-10-04 06:03:26 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: show scrollbar if applicable #28720

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @0xmiroslav requires payment offer (Reviewer)
• @samh-nl requires payment offer (Contributor)
• @Yokabdk requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

• $750 @0xmiroslav requires payment offer (Reviewer)
• $750: @samh-nl requires payment offer (Contributor)
• $50: @Yokabdk requires payment offer (Reporter)

[MitchExpensify]

Please accept the Upwork offer @0xmiroslav, thanks!

Paid and contracts ended for @samh-nl & @Yokabdk 🚀

[0xmiros]

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. This is not bug but minor visual inconsistency. I don't think this is worth adding to regression test suite.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[MitchExpensify]

Done! Paid and ended! Thanks