[HOLD for payment 2023-10-02] [$500] Feature Request: Allow searching a currency by country name

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on fab
2. Select 'Request Money'
3. From the RHN, click on the currency symbol/text
4. In the currency list, search for a currency by country name ex: Afgahn for AFN, United Sta... for USD
5. Notice it doesn't give any result when searching currency by country name,

Expected Result:

We should be able to search currency by country name

Actual Result:

We are not able to search currency by country name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.58.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Cant.search.currency.by.country.name.1.mov

Expensify/Expensify Issue URL:
Issue reported by: @huzaifa-99
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692707449381759

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ddc1f0abd774828f
• Upwork Job ID: 1698687347718701056
• Last Price Increase: 2023-09-18
• Automatic offers:
• mollfpr | Reviewer | 26795471
• huzaifa-99 | Contributor | 26795474
• huzaifa-99 | Reporter | 26795475

[melvin-bot]

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

From: @huzaifa-99
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692707449381759

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the currency list to be searchable by name along with the currency code

What is the root cause of that problem?

Our currency search in IOUCurrencySelection does not support searching a currency by country name.

What changes do you think we should make in order to solve the problem?

The currencyList from onyx has a name property for the country name of the currency. We can use that in the search here, then we can add the country name in the currency options

// pseudocode
const currencyOptions = _.map(currencyList, (currencyInfo, currencyCode) => {
    const isSelectedCurrency = currencyCode === selectedCurrencyCode;
    return {
        countryName: currencyInfo.name, // adding country name in currency options
        text: `${currencyCode} - ${CurrencyUtils.getLocalizedCurrencySymbol(currencyCode)}`,
        // .... other code

and update our search here to be something like this

// pseudocode
const searchRegex = new RegExp(Str.escapeForRegExp(searchValue.trim()), 'i'); // trim the search value
const filteredCurrencies = _.filter(currencyOptions, (currencyOption) => searchRegex.test(currencyOption.text) || searchRegex.test(currencyOption.countryName)); // also check for country name

This will allow us to search currencies by country name, we can do some optimizations here as well.

What alternative solutions did you explore? (Optional)

N/A

[joekaufmanexpensify]

IMO, this doesn't really feel like a priority personally. The list of currencies doesn't list the unabbreviated country name, so I wouldn't personally expect that you could search by country.

In any event, I was assigned by the bug zero auto-assigner (and this is not a bug), so going to un-assign. I'll defer to @sonialiap (who was assigned for new feature) as to whether we should close this or proceed.

[melvin-bot]

@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

I think this is a nice-to-have feature. I'm checking in with the team

[sonialiap]

Triaging to external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ddc1f0abd774828f

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

📣 @huzaifa-99 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[huzaifa-99]

@mollfpr @yuwenmemon PR #27946 is ready for review.

[melvin-bot]

🎯 ⚡️ Woah @mollfpr / @huzaifa-99, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @huzaifa-99 got assigned: 2023-09-21 11:19:39 Z
• when the PR got merged: 2023-09-22 03:44:22 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow currency search by currency name #27946

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment offer (Reviewer)
• @huzaifa-99 requires payment offer (Contributor)
• @huzaifa-99 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[mollfpr]

[] The PR that introduced the bug has been identified. Link to the PR:
[] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR.

[] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This is a feature request, the regression step should be good.

[] Determine if we should create a regression test for this bug.
[] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Click on Fab > Request Money (manual)
2. Click on the selected current - you will be redirected to the currency list page
3. Search for a currency by currency name and verify that the correct currencies show up. For example: searching for dollar should list all dollar-based currencies, for rupee should list all rupee-based currencies, and more specific searches like United States dollar should only list USD, etc.
4. 👍 or 👎

[mollfpr]

@sonialiap Requested the payment in NewDot because I have yet to accept the Upwork offer. Thank you!

[JmillsExpensify]

@sonialiap Can you please add a payment summary to this issue?

[huzaifa-99]

Bump on this @sonialiap

[stanislavkononiuk]

Thanks, but I'm not interested. пн, 9 жовт. 2023 р. о 18:18 Huzaifa Rasheed ***@***.***> пише:

…

Bump on this <#26120 (comment)> @sonialiap <https://github.com/sonialiap> — Reply to this email directly, view it on GitHub <#26120 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BA264ZVGUK5QLO2WBORBGF3X6PFP3AVCNFSM6AAAAAA4B5OITGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSG4ZTINZUGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[sonialiap]

@mollfpr review + time bonus = $750 - ND
@huzaifa-99 report + fix + time bonus = $800 - paid ✔️

EDIT: paid Upwork is giving me errors and not loading so I can't complete payment, I will try again in a bit

[sonialiap]

Paid Huzaifa via upwork

[JmillsExpensify]

$750 payment approved for @mollfpr based on BZ summary.