Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-02] [Wave 6: Tags] CRITICAL - Tag Menu Item and Tag Picker UI #26126

Closed
2 tasks done
amyevans opened this issue Aug 28, 2023 · 14 comments
Closed
2 tasks done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Weekly KSv2

Comments

@amyevans
Copy link
Contributor

amyevans commented Aug 28, 2023

Reminder: only users in the beta will have the data

Design doc section

Implementation

@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

@melvin-bot melvin-bot bot added the Weekly KSv2 label Aug 28, 2023
@amyevans
Copy link
Contributor Author

Callstack will be helping here!

@puneetlath puneetlath changed the title [Wave 6: Tags] Tag Menu Item and Tag Picker UI [Wave 6: Tags] CRITICAL - Tag Menu Item and Tag Picker UI Sep 5, 2023
@BeeMargarida
Copy link
Contributor

Hi 👋 I'm Ana from Callstack, I'll be helping with this issue. Is it possible to get access to the design doc?

@melvin-bot melvin-bot bot added the Overdue label Sep 6, 2023
@amyevans amyevans added Daily KSv2 and removed Weekly KSv2 labels Sep 6, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 6, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 7, 2023
@amyevans
Copy link
Contributor Author

amyevans commented Sep 7, 2023

I added to the OP but let's make sure one of the PRs includes a Typescript definition for the new data!

@amyevans
Copy link
Contributor Author

@BeeMargarida now that we have the first PR merged, when do you think is a reasonable expectation for the second?

@BeeMargarida
Copy link
Contributor

@amyevans Hopefully today or tomorrow

@amyevans
Copy link
Contributor Author

💯

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 19, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Sep 19, 2023
amyevans added a commit that referenced this issue Sep 20, 2023
@puneetlath puneetlath moved this from In Progress to Done in [#whatsnext] Wave 06 - Collect Submitters Sep 25, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 25, 2023
@melvin-bot melvin-bot bot changed the title [Wave 6: Tags] CRITICAL - Tag Menu Item and Tag Picker UI [HOLD for payment 2023-10-02] [Wave 6: Tags] CRITICAL - Tag Menu Item and Tag Picker UI Sep 25, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@amyevans
Copy link
Contributor Author

Just to note: @rushatgabhane is due for payment for review of the first PR. That's all for payments.

@rushatgabhane
Copy link
Member

thanks, i almost forgot about it.

requested payment here - https://staging.new.expensify.com/r/1256219278489207

we can close this issue because payment will be tracked on newdot

@JmillsExpensify
Copy link

Can I get a payment summary with amount so I can approve what's needed for @rushatgabhane?

@amyevans
Copy link
Contributor Author

amyevans commented Oct 9, 2023

@JmillsExpensify -

Contributor+: $500 @rushatgabhane

@JmillsExpensify
Copy link

$500 payment approved for @rushatgabhane based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants