[C+ Checklist Needs Completion] [$500] mWeb - Search icon is partially visible in help page on mobile

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to help web page (help.expensify.com)
2. Click on search icon to go to search page
3. Notice that search icon is partially visible

Expected Result:

Search icon should appear normal

Actual Result:

Search icon is partially visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v.1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230829_010235_Chrome.mp4

Screenrecorder-2023-08-22-11-51-01-37.mp4

Expensify/Expensify Issue URL:

Issue reported by: @alitoshmatov

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692687046963399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012bd40a33e016375b
• Upwork Job ID: 1697230740293746688
• Last Price Increase: 2023-09-25

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - Search icon is partially visible in help page on mobile

What is the root cause of that problem?

We set the viewBox attribute for SVG elements on mobile here:

App/docs/assets/js/main.js

Lines 126 to 133 in 3f9f1e6

	// Check if the viewport is smaller than tablet
	if (!mediaQuery.matches) {
	Array.from(svgsGoogle).forEach((svg) => {
	// Set the viewBox attribute to '0 0 13 13' to make the svg fit in the mobile view
	svg.setAttribute('viewBox', '0 0 13 13');
	svg.setAttribute('height', '13');
	svg.setAttribute('width', '13');
	});

From MDN docs:

These numbers, which are separated by whitespace and/or a comma, specify a rectangle in user space which is mapped to the bounds of the viewport established for the associated SVG element (not the browser viewport)"

https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/viewBox

What changes do you think we should make in order to solve the problem?

We should set viewBox="0 0 20 20" on mobile too as we did in the PR #24299.
Just need to change height and width attributes for mobile view.

Result

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012bd40a33e016375b

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[greg-schroeder]

Setting to $250 as this looks like a very very minor change

[ghost]

Dibs

[hamzasaleem2]

Dibs

HAHAH!

[melvin-bot]

📣 @hamzasaleem2! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[hamzasaleem2]

Is the issue already fixed? Because I cannot re generate the issue on Android/Chrome

[melvin-bot]

@greg-schroeder, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[greg-schroeder]

Hmm - can anyone else reproduce this?

[situchan]

Hmm - can anyone else reproduce this?

I reproduced this on android chrome

[situchan]

I reproduced on web as well

chrome: (not reproducible from 2nd visit until clear cache)

Screen.Recording.2023-09-04.at.8.20.53.PM.mov

safari: (wrongly positioned)

Screen.Recording.2023-09-04.at.8.19.57.PM.mov

[situchan]

@ginsuma issue happens on web as well, not only mWeb

No satisfactory proposals yet

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[srikarparsi]

@b4s36t4's proposal looks good to me as well. I believe the upwork automation didn't kick in because the issue briefly went internal but please ping @situchan and myself once the PR is ready.

[b4s36t4]

@situchan @srikarparsi Sorry for the delay. Please checkout the PR here #30577

[greg-schroeder]

Bump @srikarparsi for PR review on this one

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.0-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• update search icon & styles for search input #30577

If no regressions arise, payment will be issued on 2023-11-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @b4s36t4 requires payment
• @situchan requires payment
• @alitoshmatov requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

offers sent to all contributors in prep for tomorrow's payment date

@b4s36t4
@situchan
@alitoshmatov

[greg-schroeder]

All paid, job closed.

@situchan can you complete the checklist so we can close this? Thanks!

[situchan]

No need checklist as it's helpDot issue

[greg-schroeder]

oh, word. okay then!

[alitoshmatov]

@greg-schroeder You made a mistake by paying me 250$, I was a reporter in this issue and I should have been payed 50$

[situchan]

@alitoshmatov I think you're eligible for previous bonus amount. I see that you reported on slack before announcement

[alitoshmatov]

Understood. Thank you