[HOLD Safari 17.4][$1000] [mWeb/Safari] Fix safari unfocused selection prop

[thienlnam]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

1. We have a bug that is specific to mWeb/Safari that causes us to continue making safari specific updates in our code

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 120 to 122 in bb2386b

	// For mobile Safari, updating the selection prop on an unfocused input will cause it to automatically gain focus
	// and subsequent programmatic focus shifts (e.g., modal focus trap) to show the blue frame (:focus-visible style),
	// so we need to ensure that it is only updated after focus.

f74dbb1

2. To reduce the amount of platform specific code in our repo - let's aim to get this fixed upstream. Creating this issue to track for when we can do this

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b2f48b6c5a3887bd
• Upwork Job ID: 1700115117826949120
• Last Price Increase: 2024-06-05
• Automatic offers:
• getusha | Contributor | 102518816

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[thienlnam]

Adding monthly as an upstream fix might take a while

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b2f48b6c5a3887bd

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[michaelhaxhiu]

As mentioned by @thienlnam, this will get fixed upstream.

To reduce the amount of platform specific code in our repo - let's aim to get this fixed upstream. Creating this issue to track for when we can do this

We need a contributor to make the corresponding GH in that repository and then we'll collectively push to get this across the finish line. 👍

[ntdiary]

Ah, what a coincidence! This is exactly the code I added previously. And actually, this is a Safari/Webkit bug, I submitted a PR to Webkit before, but had to put it on hold because I needed to fix other external issues first to make a living. I've been thinking I could fix it once I have some free time in the next couple months. 😂

[michaelhaxhiu]

@ntdiary You want to submit the GH on the upstream repo to drive this through ⛳ ?

[ntdiary]

Sure, this is my previous PR. I wanted to quickly fix it with a small change, but based on their feedback, I think it would be better to refactor it systematically, which will take more time.

[melvin-bot]

@ntdiary @michaelhaxhiu this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@ntdiary, @michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

Update: We are waiting for this PR to go into production.

[alexpensify]

Looking at the PR, it was merged last week. I'll start the payment process tomorrow.

[ntdiary]

Looking at the PR, it was merged last week. I'll start the payment process tomorrow.

Hi, @alexpensify, I'm in the process of switching to NewDot payments, could you please hold this payment temporarily? :)

[alexpensify]

@ntdiary - noted, I'll still work on the summary later today but not issue a payment in Upwork. When you are ready, you can input the Request and point back to the summary.

[melvin-bot]

Upwork job price has been updated to $500

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[alexpensify]

Payouts due: 2024-05-29

• Contributor: $1000 @ntdiary
• Contributor+: $1000 @getusha

Upwork job is closed. For context, I've updated the summary since this issue was created before April 4.

Any issues created before this date will maintain their original stated price.

[alexpensify]

@getusha can you access this offer here:

https://www.upwork.com/nx/wm/offer/102518816

If yes, please accept and then I'll complete the payment process. Thanks!

[alexpensify]

@getusha any update if you can access that Upwork link to approve? Thanks!

[getusha]

@getusha any update if you can access that Upwork link to approve? Thanks!

Apologies for the delay, i am also working on migrating payments to ND, could we hold it? thanks!

[ntdiary]

Upwork job price has been updated to $500

Hi, @alexpensify, just curious, would you mind sharing why the price has been decreased? Perhaps there have been some changes to the rules that I'm not aware of? I haven't received payments recently, so I'm not quite sure. 😄

[alexpensify]

@getusha - sounds like a plan. Keep me posted when you are set up. For now, I'm going to withdraw the job in Upwork to close the job.

[alexpensify]

@ntdiary - Here is the update from April 4 regarding the changes to the job prices:

https://expensify.slack.com/archives/C01GTK53T8Q/p1712256409152489

[alexpensify]

I've reviewed the summary again and realized that I based it off the PR creation date. My mistake, the updated summary is here:

#26239 (comment)

[melvin-bot]

Upwork job price has been updated to $1000

[ntdiary]

@ntdiary - Here is the update from April 4 regarding the changes to the job prices:

https://expensify.slack.com/archives/C01GTK53T8Q/p1712256409152489

@alexpensify, Thank you! BTW, I have received the first payment through ND yesterday, and will start this issue request later. 😄

[JmillsExpensify]

$1,000 approved for @ntdiary

[alexpensify]

@getusha, are you set up for payments, so we can close out this issue? Thanks!

[getusha]

@getusha, are you set up for payments, so we can close out this issue? Thanks!

@alexpensify not yet, i received an invitation last week. I think the process is yet to begin.

[alexpensify]

Thanks for the update!

[getusha]

@alexpensify since i was assigned before 2024-05-25 can we process the payment via upwork?

[alexpensify]

@getusha ok, I sent over a new offer in Upwork. Please accept here: https://www.upwork.com/jobs/~019cb418da52a59d59

I can complete the next steps after you accept this new offer. Thanks!

[getusha]

@alexpensify, Accepted, thank you!

[alexpensify]

All set here, I've completed the payment process to @getusha. Everyone has been paid accordingly: #26239 (comment).