[HOLD for payment 2023-10-23] [$1000] Feature request: Unable to add multiple emails at once as members to a workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with any account
3. Add multiple emails at once as members to a workspace

Expected Result:

Allow for multiple emails addresses to be added at once when inviting new members to a workspace.

Actual Result:

Unable to add multiple emails at once as members to a workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.58.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1692837155454539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017b2a4652d665e512
• Upwork Job ID: 1699456983730249728
• Last Price Increase: 2023-09-26

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[hungvu193]

I remembered I was able to search multiple emails at once.
Long story short, it was added long time ago by @jasperhuangg in this PR:
#2958
Then we had this #22411, we changed the search logic to be AND, also removed the usage of underscore and I believe that's the RCA.
In order to search for multiple value we can update isSearchStringMatch a little bit:

const newSearchWords = searchValue
    .replace(/,/g, '')
    .split(' ')
    .map(word => word.trim());

 return _.some(newSearchWords, (word) => {
        const matchRegex = new RegExp(Str.escapeForRegExp(word), 'i');
        return matchRegex.test(valueToSearch) || (!isChatRoom && participantNames.has(word));
     })

@mallenexpensify But I think we should discuss about this carefully about why we implemented it then removed it later 😂

Result:

Screen.Recording.2023-08-30.at.17.53.46.mov

[maddylewis]

pinged Matt about this here - https://expensify.slack.com/archives/C01GTK53T8Q/p1693505035975329?thread_ts=1692837155.454539&cid=C01GTK53T8Q

[melvin-bot]

@maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

[maddylewis]

bumped again - https://expensify.slack.com/archives/C01GTK53T8Q/p1693922448639589?thread_ts=1692837155.454539&cid=C01GTK53T8Q

[jasperhuangg]

#2958

So it seems that the PR I did wasn't to allow searching for multiple emails. That just allows us to search for chat names with commas inside them. That's for the search page, which is separate from the issue we're talking about here.

[mallenexpensify]

Sorry for the delay. Without knowing much about the code, I think it's more common that people, especially companies (who pay us!), will want to add multiple users at once vs someone searching for emails or room names with commas in them (if they're even related, Jasper's comment above makes it sound like they're not).

I can see this not being a quick/easy fix that should be thoroughly thought through before implementing. I think it's common for people to add multiple emails by having a comma in between each but maybe there's another/better way? Maybe we would have a tooltip or similar letting people know who to add multiples?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017b2a4652d665e512

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

📣 @Juggernaut-98! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Juggernaut-98]

Contributor details
@mananjadhav After going through the code I realized that the issue is with how we are checking validity of search values. From what I have observed we are not properly spliting the search values in SearchPage.js. With proper splitting we can make this work.
Do let me know if more information is needed or if my solution seems like something that could work. I would send a porposal on upwork. :)

Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~017b88118348aa48c8

[mallenexpensify]

Quick question then I'll close. @francoisl @mananjadhav @Samueljh1 , if we wanted to replicate this for adding multiple email address to a room, how similar would it be to the work that was done here?

[Samueljh1]

Quick question then I'll close. @francoisl @mananjadhav @Samueljh1 , if we wanted to replicate this for adding multiple email address to a room, how similar would it be to the work that was done here?

I expect it to be very similar. I'd be happy to work on this as a separate issue.

[mallenexpensify]

Thanks @Samueljh1 , I'm discussing internally, I'll tag you in the new GH for the new feature request if/when it gets created.

[mallenexpensify]

@Samueljh1 tagged ya over here...

• [HOLD][$500] Feature request: Unable to add multiple emails at once as members to a room #26242 #30874

[mallenexpensify]

Did this reverted because we didn't address how to show error messages? Reopening so that people see this

[mallenexpensify]

@francoisl @mananjadhav @Samueljh1 Did this reverted because we didn't address how to show error messages?

[Samueljh1]

@francoisl @mananjadhav @Samueljh1 Did this reverted because we didn't address how to show error messages?

Yes, it was. Workspace will have to be restarted from scratch along with Room.

[quinthar]

Let's pause work on this until we settle having a unified design here: https://expensify.slack.com/archives/C01GTK53T8Q/p1703557793897069?thread_ts=1703360093.158969&cid=C01GTK53T8Q

[melvin-bot]

@francoisl, @mananjadhav, @Samueljh1, @maddylewis Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@francoisl, @mananjadhav, @Samueljh1, @maddylewis 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[maddylewis]

hiya @garrettmknight - nothing actionable on your end atm. i left BZ a couple of months ago but was waiting for some solid next steps on this one before un-assigning myself.

it sounds like we're going to pause on this feature until some additional details are worked out - #26242 (comment)

[garrettmknight]

This is actively being redesigned with Groups so I'm going to close. We can reopen if it's still behaving unexpectedly once we update.