The report preview is not removed when request is made offline and becomes stale

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login as User A and User B in front of you at the same time.
2. As User A Go offline
3. As User A requests Money from User B ( make sure it works by avoiding the bugs around the IOU feature Now )
4. As User B open the chat and request money from User A.
5. Now back to User A and go online.

Expected Result: -

There is only one report preview for both User A and User B

Actual Result:

User A has two report previews, the second one is the correct one but the first one is the stale report preview which needs to be removed with pusher update when this collision happens. Its linking to the previously optimistically created report which is stale and no longer valid.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.58-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

1701128113639945.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692590693071889

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d18debe98d8308dd
• Upwork Job ID: 1699073811659808768
• Last Price Increase: 2023-10-02
• Automatic offers:
• mollfpr | Reviewer | 26983423
• Ahmed-Abdella | Reporter | 26983426

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Ahmed-Abdella]

Important notice:
The behavior here differs based on whether User B's request is smaller or larger than User A's.

1. If user B's request is smaller It behaves exactly like the report steps and results. The first money request is not calculated (see the second video in the report)

2. If user B's request is larger, the money amount will be calculated, but there are bugs such as the first money request from user A while offline resulting in a broken link that opens a "page not found" error. (see the first video in the report)

So, To reproduce all the bugs related to this issue, request a smaller amount as User B.

[isabelastisser]

I'm heading OOO now and will be back on Sept 5; I will reapply the Bug label but leave myself assigned in case I need to action this once I'm back. Thanks!

Summary: I haven't touched this issue yet, so all the triage steps are pending.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@michaelhaxhiu, @isabelastisser Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d18debe98d8308dd

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

@mollfpr, @isabelastisser Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@mollfpr, @isabelastisser Huh... This is 4 days overdue. Who can take care of this?

[mollfpr]

No new proposals.

[danieldoglas]

Still didn't have the time to look into this one.

[danieldoglas]

I'll be OOO starting this Friday, and will tackle this when I'm back

[isabelastisser]

Not overdue.

[isabelastisser]

No updates.

[isabelastisser]

No updates.

[isabelastisser]

Any updates @danieldoglas ?

[danieldoglas]

@isabelastisser I haven't really worked on this yet, but based on our new rules, we should find a wave and fit it into the wave now. Considering that it's related to requests I think it should fit into wave5. And it should probably enter the priority system of that wave.

Can you please post it there?

Thanks!

[isabelastisser]

Yes, thanks for the heads up @danieldoglas! :)

[isabelastisser]

Asking here.

[isabelastisser]

Bumped the question in Slack. https://expensify.slack.com/archives/C05DWUDHVK7/p1707845988509359

[youssef-lr]

I think this was fixed here. Reproduction steps look the same.

[isabelastisser]

Thanks for the heads up, @youssef-lr! Closing this.

[Ahmed-Abdella]

Hey, @isabelastisser, @mountiny, Sorry but shouldn't this be eligible for reporting bonus?

[mountiny]

Discussed in slack, no reporting bonus