[$500] [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-07] 'FAB' popover menu is not opened when user Sign-up

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Navigate to sign-up page
2. Enter email & click on continue
3. Enter magic code

Expected Result:

'FAB' popover menu should be opened on sign-up

Actual Result:

'FAB' popover menu is not opened on sign-up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.59-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-08-30.07-23-35.mp4

Recording.1385.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Natnael-Guchima

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693369621472089

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015934b071bb2db892
• Upwork Job ID: 1702307379358162944
• Last Price Increase: 2023-09-14

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

This is similar KI #26076

[grgia]

Caused by my PR, I can get a fix up now

[amyevans]

Thanks @grgia!

[luacmartins]

Seems like we merged and CPed a fix. Removing the blocker label.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[laurenreidexpensify]

Reviewing now

[laurenreidexpensify]

@grgia @amyevans I'm not familiar with the back and forth here on the regressions etc - can you help me unpick this so we can get it closed? Thanks

[DinalJivani]

@laurenreidexpensify
Gentle bump for payment
&
"Issue reported by:" should be updated by my name. Thanks
cc: @garrettmknight

[amyevans]

@laurenreidexpensify It was a regression from #26182

#26076 was reported in Slack August 16. #26182 wasn't merged until August 29 so I don't really see how #26076 would have reported the bug before it was introduced 😄 That bug report looks specific to a cross-platform flow.

So to me it looks like:

• @Natnael-Guchima is due $250 for reporting
• @jjcoffee is due $1000 for PR review

But I'd like @grgia to weigh in first because she has more context than I do

[grgia]

@laurenreidexpensify I fixed the regression in this PR #26293 after being alerted on slack by @jjcoffee. I agree it's just whichever bug report came first in this case

[Natnael-Guchima]

They are different bug reports. #26076 is a cross-platform test with different test steps. By the time #26076 was reported the regression fixed here wasn't introduced as @amyevans mentioned here.

[Natnael-Guchima]

@DinalJivani can you please retest your report again with the exact test steps, and share a video so that we might see if the issue you reported is still reproducible or not?

[DinalJivani]

@grgia @amyevans @garrettmknight
Sorry to tag y'all 😅

Steps are simple:

1. Logout of all instances, Staging and New
2. Register with new Email
3. Open magic code link from email -> Click on 'just sign in here' link

@Natnael-Guchima The bug reports or steps might be same but the resolution to it might be the same for both issue.

Untitled.mp4

[Natnael-Guchima]

@DinalJivani correct me if I am wrong. From the video, it seems that the issue you have reported still exists, right?

[DinalJivani]

@Natnael-Guchima Yes I am still able to reproduce this issue.
May be, That's why I could find that bug even before it occurred from regression

[Natnael-Guchima]

Hmmm, if it is still reproducible I think the fix doesn't address the issue you have reported. IMO, both issues seems to be different because one of the bug is fixed and the other is not by the fixing PR.

[DinalJivani]

Yes my issue was closed based on comment by @jjcoffee that it will be fixed in this PR
@Natnael-Guchima let's wait for them to decide on this now!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015934b071bb2db892

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[jjcoffee]

@laurenreidexpensify Thanks, offer accepted!

[laurenreidexpensify]

Payment Summary:

Reporter: @Natnael-Guchima - paid in Upwork $250
Code Fix: @grgia internal $0 (regression)
C+: @jjcoffee paid in Upwork $1000

To note the prices above reflect the rates when this issue was picked up, not the new rates

[Natnael-Guchima]

Accepted the offer. Thanks @laurenreidexpensify

[situchan]

@jjcoffee can you please continue discussion on this thread for reference in the future so that other C+s know how much to get paid in such cases?

@jjcoffee bump ^

[melvin-bot]

@amyevans, @jjcoffee, @grgia, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[laurenreidexpensify]

Payments issued, closing