[$500] Web - Workspace request money message displays wrong currency before conversion

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings and click on new workspace
3. In new workspace, if current currency is not 'USD' the change to USD and if 'USD', change to any other currency.
4. In LHN, workspace chat will be created, open it
5. Click on plus and click Request money
6. In request money, select currency different then workspace currency eg: In video, INR is selected in request money and workspace currency is USD
7. Complete the request with any amount
8. Observe the IOU message displays the workspace currency even before conversion to it eg: In video, it displays $900 instead of ₹900 and few moments later, it converts to $10.9

Expected Result:

Before conversion to workspace currency, app should display request money selected currency symbol in request money message

Actual Result:

Before conversion to workspace currency, app still displays workspace selected currency symbol in request money message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

currency.displayed.as.workspace.currency.mp4

Recording.4089.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692866442917089

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010daaf0b73a652083
• Upwork Job ID: 1702053307519152128
• Last Price Increase: 2023-09-13
• Automatic offers:
• DylanDylann | Contributor | 26746667
• dhanashree-sawant | Reporter | 26746668

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

Reviewing today!

[dylanexpensify]

Reviewing today while in the air! Currently taxi'd, will get to once I can hop on wifi! Sorry I didn't get to this last week, had head down on wave4 saastr

[dylanexpensify]

Reviewing today while in the air! Currently taxi'd, will get to once I can hop on wifi! Sorry I didn't get to this last week, had head down on wave4 saastr

[dylanexpensify]

Reviewing today while in the air! Currently taxi'd, will get to once I can hop on wifi! Sorry I didn't get to this last week, had head down on wave4 saastr

[dylanexpensify]

Coming back from conference last week - updating today!

[melvin-bot]

@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010daaf0b73a652083

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[dylanexpensify]

confirmed

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace request money message displays wrong currency before conversion

What is the root cause of that problem?

App/src/pages/iou/steps/NewRequestAmountPage.js

Line 70 in d68263a

const currency = currentCurrency || iou.currency;

If there is no currency in the param we will use currency from iou but the iou field is used for all chats

What changes do you think we should make in order to solve the problem?

We should get currency from policy and use it like this

const policy = ReportUtils.getPolicy(report.policyID)
const currency = currentCurrency || lodashGet(policy, 'outputCurrency', undefined) || iou.currency;

Result

Screen.Recording.2023-09-14.at.12.11.31.mp4

[robertKozik]

Hi @DylanDylann!
Your solution looks well designed and addresses the issue entirely, as it's the only one here let's see it in action 🚀

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[DylanDylann]

@dylanexpensify Are we eligible for compensation for our effort? Contributors are already assigned and started on the PR. It's just due to the expectation changes and the solution becomes outdated.

Some other similar cases where compensation is made are below:
#18664 (comment)
#21419 (comment)

[dylanexpensify]

@danieldoglas mind confirming here? ^ If we agree, happy to do so!

[danieldoglas]

@dylanexpensify Yeah, I think compensation is due in this case.

[dylanexpensify]

Do we feel fine with $250 @danieldoglas @DylanDylann

[danieldoglas]

That works for me.

[DylanDylann]

@DylanDylann @danieldoglas Contributors are already assigned to this issue and were preparing to raise PR. We spent more time investigating to give the final decision. One more thing, there are many similar cases, where the payment is 100% price even without PR
#26470 (comment)
#26309 (comment)
#28844 (comment)
#22806 (comment)

So could you help to re-evaluate If we are eligible for 100% price in this issue? Thanks

Anyway, Happy with your decision.

[DylanDylann]

bump @danieldoglas @dylanexpensify Could you help to move forward this issue?

[danieldoglas]

Reopening the issue so we don't lose track of it

[DylanDylann]

@danieldoglas @dylanexpensify Could you help to check this comment

[melvin-bot]

@danieldoglas, @dylanexpensify, @robertKozik, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@danieldoglas, @dylanexpensify, @robertKozik, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[danieldoglas]

bump @dylanexpensify

[dylanexpensify]

Apologies! Looking now

[dylanexpensify]

ah, confirming we paid $250, and the request is for an amount of $500? Is that right @DylanDylann ?

[DylanDylann]

@dylanexpensify yep it is my opinion. But happy with your final decision

[melvin-bot]

@danieldoglas, @dylanexpensify, @robertKozik, @DylanDylann 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[dylanexpensify]

Sounds good - thanks for understanding!

[DylanDylann]

@dylanexpensify I haven't received any payment for this issue 😄 Could you help to check again? This is my opinion
cc @danieldoglas

[dylanexpensify]

Oh apologies! Jeez - blonde time. Payment of $250 sent, as discussed above!