[$1000] Request money - Tabs jump back and forth when swiping through tabs

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #26022

Action Performed:

1. Go to staging.new.expensify,com
2. Go to + > Request money
3. Swipe through the tabs in Request money page

Note: I believe the key to reproduce the issue is to swipe to another tab before the animation has finished.

Expected Result:

The tab does not jump back and forth

Actual Result:

The tab jumps from Scan > Distance > Scan > Manual when swiping from Scan to Manual

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.60-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6183894_Screen_Recording_20230831_175255_Chrome.mp4

Bug6183894_touch-enabled_web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015402cabc0571ff40
• Upwork Job ID: 1697381434343821312
• Last Price Increase: 2023-11-07

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[b4s36t4]

@hannojg maybe you've worked on it? after the patch with material tab view?

[aldo-expensify]

@Pluto0104

Thanks for the proposal: #26407 (comment)

I'm trying it, but I still see the bug. I did this:

This makes me thing that there may be a bug in the external library, but I haven't been able to test that.

[aldo-expensify]

Lol, this is very broken in production, much worse than this:

Screen.Recording.2023-08-31.at.2.10.07.PM.mov

Considering that, I think we should remove the DeployBlocker label and investigate with lower priority

[luacmartins]

Agree this is not a blocker since it happens in production too!

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015402cabc0571ff40

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@Pluto0104 Thanks for the proposal. I don't think your RCA is correct, onyx does not seem to be the root cause here.

[b4s36t4]

Can anyone help me with re-production steps here? Do we need to use the swipe or clicks on tabs?

[Pluto0104]

@s77rt I have already seen @aldo-expensify's explanation. it may be caused by module issue.

[aldo-expensify]

Can anyone help me with re-production steps here? Do we need to use the swipe or clicks on tabs?

@b4s36t4

You need to swipe, no clicking. It is reproducible using Chrome with dev tools open to simulate a small screen.

Steps:

1. Start in tab 1 (Manual)
2. Swipe left to move to tab 2 (Scan)
3. Before the animation has completed, swipe right to go back to tab 1 (Manual)

Result:

• Tab 3 (Distance) becomes briefly active and you also see briefly the map.

Screen.Recording.2023-09-01.at.10.39.54.AM.mov

Expected Result:

• Should have moved back to Tab 1 without seeing the content of tab 3 or highlighting tab 3

[greg-schroeder]

Still looking for proposals. Although now QA is saying not reproducible? hmmm

[aldo-expensify]

Although now QA is saying not reproducible?

I just reproduced it. They are not probably following well the steps:

1. Swipe from "Manual" to "Scan"
2. Swipe back to "Manual" before the animation has completely finished

[melvin-bot]

@s77rt @greg-schroeder @aldo-expensify this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

[aldo-expensify]

I think we should just start by reporting this in react-native-tab-view's repo

[s77rt]

@aldo-expensify Should this be set back External?

[melvin-bot]

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aldo-expensify]

I found that this was reported on Oct 2021 in the external library repo: react-navigation/react-navigation#10072

I don't think this will be fixed anytime soon in the library code. What would be the next step? Should we just close this issue? I think we should close it because I see it as a pretty minor thing (low ROI) and could be quite complex to fix.

[greg-schroeder]

All right - thanks Aldo. I'll close this then.