[HOLD for payment 2024-04-09] [$500] [MEDIUM] IOU - Money request page displays skeleton in online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch app
2. Tap profile icon
3. Tap Preferences
4. Toggle on force offline
5. Navigate back to LHN
6. Tap IOU report for request money received
7. Note the IOU report page keeps loading
8. Tap Pay elsewhere
9. Navigate back to LHN and again visit IOU to note page keeps loading
10. Navigate to LHN
11. Tap profile
12. Tap preferences
13. Toggle off force offline
14. Navigate back to LHN
15. Tap IOU report

Expected Result:

Output of @mountiny & I discussing this one here for reference.

• We have the report total loaded in the iouReport data, so we should show the report total in the report where possible when offline.
  -The iouActions we can't load would still show with a skeleton UI as we do today (we agreed just the one request preview component appearing as a skeleton is fine).
  When a new request is added to the request when offline and appears at 50% opacity in the pending create state, so should the report total in the expanded header area.

Actual Result:

In online, in IOU report for request money, the page keeps on loading

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6184136_loading_redmi_secondaey_receivrr.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012efb1896a46c34c4
• Upwork Job ID: 1707346943173816320
• Last Price Increase: 2024-02-13
• Automatic offers:
• abdulrahuman5196 | Reviewer | 0
• dukenv0307 | Contributor | 0

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

When I come back online, they eventually load and the skeleton UI goes away, so that's contrary to the bug report. When we can't load the content, the skeleton UI is the correct pattern to use.

RPReplay_Final1693568080.MP4

I'm curious why the report total extended header in the iouReport isn't available to view offline in the first place though, and whether we can improve that in the spirit of offline-first?

CC: @mountiny @luacmartins @JmillsExpensify

[luacmartins]

It seems like a regression. I agree they should be working offline.

[mountiny]

I'm curious why the report total extended header in the iouReport isn't available to view offline in the first place though, and whether we can improve that in the spirit of offline-first?

Yep I think in offline it can work like that, online we probably still need to show the skeleton

[trjExpensify]

Can you expand on that, @mountiny? Why do we need to show the skeleton for the report total when online?

[mountiny]

No we dont have to, sorry we were probably talking about different things

[trjExpensify]

Cool, so we agree with the below? Then next question, is this going to need backend changes?

Expected results
The report total in the expanded header area should be available to view when offline.

Actual Results
The report total doesn't load, and shows a skeleton UI in its place when offline.

[mountiny]

The report total in the expanded header area should be available to view when offline.

What if you have exisitng IOU report and you sign out sign back in, you dont go to the IOU report so you dont have the report actions but you have the total.

You are offline, You request more, the total is updated and you see that offline made request but you dont see the previosu messages and there is no indication the report has more report actions while total is more. Is that fine as a feedback to the user while offline?

[trjExpensify]

You might have to type that out again in steps for me to follow it completely sorry man. Let's park this and focus on the deploy for a sec.

[trjExpensify]

Okaaaay. @mountiny, circling back here. Mind rephrasing? 😄

[mountiny]

1. You fresh sign in
2. you have the IOU report data and its total ($50) locally with user B
3. You go offline
4. you request more money $10 from the user B
5. We wont show a skeleton, one report action done optimistically with $10 and total of $60

If there is no skeleton, then it might be confusing to the user as there is only one report action and they cannot see the others

[trjExpensify]

Why wouldn't it just work like this as it does now? 😕

yfMvCuNr58.mp4

Interestingly, the report total updates as well. Perhaps that should be at 50% opacity as well though, as it's pending the update? CC: @JmillsExpensify @shawnborton

[shawnborton]

Yeah, I think that makes sense to me.

[mountiny]

@trjExpensify In this case you have visited the report before you went offline so you had the £50 report action. You could not have that if you would sig in and not open the report and went offline and then go to the report.

Its edge case but thats what we trying to cover here

[trjExpensify]

I don't think I did visit the iouReport, no. Here's another one:

ofdi8s8pOz.mp4

[mountiny]

@trjExpensify yeah but you just created it locally so the request is there. You would have to create the request and report, then sign out and sign back in, request from global create from the same person, the historical report actions will be missing I believe because they do not load during openApp

[melvin-bot]

@trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Going to chat with Vit about this on Monday.

[dukenv0307]

@abdulrahuman5196 The PR is ready for review.

[aldo-expensify]

Reassigning to @mountiny since he has a lot more context of this

[trjExpensify]

PR in active review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Display total and money request in offline #36657

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196 / @dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196 / @dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196 / @dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196 / @dukenv0307] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196 / @dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

$500 to @dukenv0307 and to @abdulrahuman5196

[trjExpensify]

👋 checklist time please, @abdulrahuman5196!

In the meantime, payment summary will be as follows:

• $500 to @abdulrahuman5196 for the C+ review
• $500 to @dukenv0307 for the fix

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Create some money requests in a chat
2. Open the IOU report and send some messages
3. Open another report and send a message
4. Logout and login again with the same account
5. Without opening any other report, go offline
6. Open IOU report that we created above
7. Verify that the total is displayed and at least one money request appears

@trjExpensify Added checklist. And I am still getting paid via upwork. Kindly process on the same.

[melvin-bot]

@trjExpensify, @mountiny, @abdulrahuman5196, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

[trjExpensify]

Paid you both! Closing!