[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Chat - Entering @ in second line not showing 5 user suggestions

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on any report
3. Enter @ in compose to note 5 user suggestions displayed
4. Select any one
5. Tap enter key
6. In second line, enter @

Expected Result:

Entering @ in second line must show 5 user suggestions

Actual Result:

Entering @ in second line not showing 5 user suggestions

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.61-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6184879_5suggestions.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0107efd9d088b99c24
• Upwork Job ID: 1707566811859394560
• Last Price Increase: 2023-09-29
• Automatic offers:
• cubuspl42 | Reviewer | 26993154

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Entering @ in second line not showing 5 user suggestions

What is the root cause of that problem?

The root cause of this issue is that we have an incorrect condition to calculate the suggestion size here.

What changes do you think we should make in order to solve the problem?

We should instead change this condition to be:

    const hasEnoughSpaceForLargeSuggestion = windowHeight - composerHeight - HEADER_HEIGHT >= SUGGESTION_MENU_HEIGHT;

We can save the HEADER_HEIGHT and SUGGESTION_MENU_HEIGHT as a constant (its value is 65 & AUTO_COMPLETE_SUGGESTER.SUGGESTION_ROW_HEIGHT * 5 respectively)

What alternative solutions did you explore? (Optional)

None

[alexpensify]

I'm OOO today and will test soon.

[alexpensify]

Closing - this is a dupe of #26197

@allroundexperts - please share your proposal there for review. Thanks!

[allroundexperts]

I don't think this is a duplicate of #26197.

[cubuspl42]

@allroundexperts It looks like a dupe for me. Slightly different symptom of the same problem

[allroundexperts]

@allroundexperts It looks like a dupe for me. Slightly different symptom of the same problem

Possibly. We can wait till the other is resolved and then try again.

[alexpensify]

Weekly Update: Putting this one on hold until #26197 hits production and we can confirm this is still an issue.

[alexpensify]

Looks like I didn't edit the labels, this one should be a weekly.

[alexpensify]

Disregard

Weekly Update: PR is under review

[alexpensify]

@allroundexperts could you help to confirm if we should move this one off HOLD since the other GH is in staging? Thanks!

[allroundexperts]

@alexpensify This is still happening:

Screen.Recording.2023-09-29.at.5.55.01.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0107efd9d088b99c24

[allroundexperts]

PR created #28927

[alexpensify]

Weekly Update: It looks like the PR is moving forward!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: show large suggestion menu only if there is space #28927

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment offer (Reviewer)
• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42 / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42 / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42 / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42 / @allroundexperts] Determine if we should create a regression test for this bug.
• [@cubuspl42 / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: show large suggestion menu only if there is space #28927

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment offer (Reviewer)
• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42 / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42 / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42 / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42 / @allroundexperts] Determine if we should create a regression test for this bug.
• [@cubuspl42 / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@cubuspl42 - to prepare for the payment date, can you please complete the checklist? Thanks!

[cubuspl42]

• The PR that introduced the bug has been identified. Link to the PR:
  • It seems that the bug was present in the relevant components since they were created
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • No need for additional discussion
• Determine if we should create a regression test for this bug.
  • Up to the QA team
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • Sign in and open any report.
  • Move the cursor to the second line or any line after that in the composer.
  • Type "@".
  • Ensure that...
    • given enough space, a full suggestion menu appears, capable of displaying 5 suggestions.
    • in case of limited space, a smaller version of the suggestion menu appears.

[cubuspl42]

@allroundexperts I modified the QA Steps from your PR to be more explicit, you can give it a quick look

[JmillsExpensify]

Can I get a payment summary on this issue?

[alexpensify]

Here is the payment summary:

• External issue reporter - N/A
• Contributor that fixed the issue - @allroundexperts $500
• Contributor+ that helped on the issue and/or PR - @cubuspl42 $500

Upwork Job: https://www.upwork.com/jobs/~0107efd9d088b99c24

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: This solution took more than 6 business days, but I think the payment should include no penalty. The issue was fixed and took into account an edge case. I believe that we fixed this issue right and avoided regressions instead of rushing, so keeping the payment as is for this one.

[JmillsExpensify]

$500 payment approved for @allroundexperts based on summary above.

[alexpensify]

Closing - I created the QA GH and everyone has been paid.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.