Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Distance] Request money - Map box not zooming to current location #26485

Closed
2 of 6 tasks
lanitochka17 opened this issue Sep 1, 2023 · 9 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #25990

Action Performed:

Prerequisite: Distance request beta must be enabled

  1. Click on Fab -> Request Money -> Press Distance Tab
  2. Click on any waypoint
  3. On the waypoint editor page, click on the "Use current location" button
  4. If location permission is enabled, verify that the address field changes text to "Your Location" and clears any errors on that page and navigates you back to distance page. There you will see the waypoint edited with text 'Your Location'

Expected Result:

Mapbox zooming into your location

Actual Result:

Mapbox not zooming to current location and at default location

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.61-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6184962_GUTS1534.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@huzaifa-99
Copy link
Contributor

I will be fixing this with a new PR (taking changes from #25990)

cc: @hayata-suenaga @narefyev91

@JmillsExpensify
Copy link

Sounds great. I'll keep an eye on this one in the meantime.

@huzaifa-99
Copy link
Contributor

I don't think this is a regression from #25990. As this issue is also on main. Confirming if we need to fix it as part of #25990?

cc: @hayata-suenaga @JmillsExpensify

@hayata-suenaga
Copy link
Contributor

this might have been solved by this PR

@huzaifa-99 when you create the PR, can you make sure that you test this behavior? 🙇

@huzaifa-99
Copy link
Contributor

sure. I will definitely check @hayata-suenaga

@huzaifa-99
Copy link
Contributor

this might have been solved by this PR

@huzaifa-99 when you create the PR, can you make sure that you test this behavior? 🙇

Yes, this seems to have solved it. I still tested it in the PR #26546

@hayata-suenaga
Copy link
Contributor

Yes, this seems to have solved it. I still tested it in the PR #26546

nice closing this issue now

@lanitochka17 lanitochka17 changed the title Request money - Map box not zooming to current location [Distance] Request money - Map box not zooming to current location Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants