[HOLD for payment 2023-10-18] [Wave 6: Categories] Low: Shouldn't be able to select categories on split bill that doesn't involve workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click the + icon in announce room
2. Select Split Bill
3. Click on "Show More"
4. Click on "Category"
5. Select any category from the dropdown menu

Expected Result:

Selected category should be displayed after making selection

Actual Result:

When user click on any category there is no selection made

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.61-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6185197_Recording__833.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BhuvaneshPatil]

How do we create categories in workspace?

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Not sure I can reproduce this without categories being live for Split bills, so I asked in the Wave 6 channel

[puneetlath]

The solution here is that we should only show the Category selector if one of the people you are splitting the bill with is the workspace. Even if the split is happening in the workspace room, we shouldn't show the category selector unless the workspace itself is involved in the split.

[melvin-bot]

@puneetlath this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[puneetlath]

Dropping to weekly since this is a beta feature, so it shouldn't affect anyone. We'll handle it as a wave6 polish item.

@rezkiy37 perhaps you want to take it when you're done with the editing categories feature.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow Adding a category to a Split Bill #27936

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@puneetlath] The PR that introduced the bug has been identified. Link to the PR:
• [@puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rezkiy37] Determine if we should create a regression test for this bug.
• [@rezkiy37] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hoangzinh]

@puneetlath I'm assigned as a C+ review on this PR #27936. Could you help to add me to this issue so we can trigger payment properly? Thanks

[puneetlath]

Thanks for letting me know. Please fill out the checklist and I'll pay on Wednesday 🙂

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: Nope, it's a feature request
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes, we should
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. [HOLD for payment 2023-10-18] [Wave 6: Categories] Low: Shouldn't be able to select categories on split bill that doesn't involve workspace #26506 (comment)

[hoangzinh]

Regression Test Proposal

Note: the backend is not ready yet to handle categories for split bills. Also, there is no UI to verify that in a newly created split bill there is a category.

Tests

Case 1. Split bill for workspace participants with categories

1. Click on "+" (FAB)
2. Click on "Request Money".
3. Click on "Split" on a participant that is a workspace and has categories.
4. Click on "Show more".
5. Verify that there is a "Category" field.
6. Click on the field.
7. Verify that you can select/deselect a category.
8. Click on "Split".
9. Verify that the app redirects you to a chat page with a newly created split bill.

Case 2. Split bill for regular users without categories

1. Click on "+" (FAB).
2. Click on "Request Money".
3. Click on "Split" on any participant that does not have categories like a regular user.
4. Click on "Show more".
5. Verify that there isn't a "Category" field.
6. Click on "Split".
7. Verify that the app redirects you to a chat page with a newly created split bill.

Do we agree 👍 or 👎

[melvin-bot]

@puneetlath, @hoangzinh, @rezkiy37 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@puneetlath, @hoangzinh, @rezkiy37 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[puneetlath]

Looks like only @hoangzinh requires payment here. Sent you an offer @hoangzinh: https://www.upwork.com/nx/wm/offer/27368549

And the back-end still needs to be updated.

[hoangzinh]

Accepted offer. Thanks @puneetlath

[rezkiy37]

I have to inform that starting tomorrow I have a short vocation until next Monday (6.11.2023). Feel free to left any comments, I will address them. See you soon 😉

[hoangzinh]

cc @puneetlath on payout #26506 (comment)

[melvin-bot]

@puneetlath, @hoangzinh, @rezkiy37 Huh... This is 4 days overdue. Who can take care of this?

[puneetlath]

Whoops, sorry for the delay @hoangzinh. Paid!