[HOLD for payment 2023-10-20] [$250] OldDot Transition - Opening free policy from OD with another user logged to ND opens blank page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Log in NewDot with an account
2. Navigate to OldDot and sign in to a different account that has a existing workspace.
3. Go to Settings > Policies > Group and click on any Workspace policy

Expected Result:

You're redirected to NewDot, you're logged in with the same account as in OldDot and that the Workspace settings page is displayed

Actual Result:

You're redirected to NewDot, you're logged in with the same account as in OldDot but the page is shown blank. User needs to refresh or use the link again for the page to appear correctly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.61-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6185425_Recording__257.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017c59d6ab1d74e2a2
• Upwork Job ID: 1698462755419181056
• Last Price Increase: 2023-10-16
• Automatic offers:
• sourcecodedeveloper | Contributor | 27244329

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jliexpensify]

@lanitochka17 can you try this on v1.3.62-1?

I can't exactly reproduce this - basically clicking on a Workspace in Old.Dot opens up New.Dot, but there's considerable lag.

[lanitochka17]

Issue reproducible on Build 1.3.62-3

Recording.263.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017c59d6ab1d74e2a2

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[jliexpensify]

Ok yeah, I am seeing it now - thanks! Assigning to External.

[burczu]

Just to inform: I'll be OOO on Thursday and Friday (7-8 September).

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jliexpensify]

Hmm the source code for www.expensify.com is not made publicly available. If this is a change that needs to occur on Old.Dot, then we would likely make this one Internal - I'll let @burczu weigh in when they are back.

[burczu]

@jliexpensify I think we should make it Internal - even if there is no need to change anything in OldDot eventually, I think it would be good to have a chance to check it.

[melvin-bot]

Current assignee @burczu is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[koko57]

@burczu looks like a very similar issue to this one #27418
fixed in: #28984

[burczu]

@koko57 Thanks for pointing this out - I'll check if it's fixed by the PR you've mention soon.

[koko57]

@Sourcecodedeveloper Why do you think that my solution breaks the deeplinking? I tested this flow with my solution and it works fine.

Screen.Recording.2023-10-10.at.10.09.08.mp4

Your solution is very similar, when I was working on mine I've tried something very similar (but instead just clearing the Onyx in this condition in setUpPoliciesAndNavigate I used signOutAndRedirectToSignIn method) but I decided that It would be better to move this method to AuthScreens. LogOutPreviousUserPage just doubled the signOut request and clearing the Onyx, so there is no necessity to make the same request again on this page. I left the shouldForceLogin logic there though.

[burczu]

@Sourcecodedeveloper Sorry, I had no time yet to come back to this issue and take a closer look on both solutions... I'll get back to it once I finish my other tasks.

In terms of reproducing this issue, I've followed your advices from this comment: #26530 (comment)

[burczu]

@koko57 @Sourcecodedeveloper I've finally managed to check the solution provided in #28984 and it looks like it fixes this issue. In my opinion this other solution looks better because the check is done in AuthScreens so it's done earlier. Additionally it seem to work a little bit faster, so I think we should go with that other solution and close this one.

@danieldoglas @jliexpensify In case we agreed with the above, I think we should compensate @Sourcecodedeveloper for they effort here, what do you think?

[burczu]

@Sourcecodedeveloper I see your point but I'm not sure this is a real life scenario we need to handle in the app (the /transition route isn't supposed to be used in other way than while switching from OldDot to NewDot). I've posted a comment in the other PR asking others about their opinion.

[mountiny]

Stepping in here after discussing these two options I agree that solution from @koko57 is more robust and we should go with that. The spinner when clicking transitionlink is edge case normal users will not go through, although I think we can explore after this. So I will move this ahead so we are not in this standstill.

We should pay you @Sourcecodedeveloper 25% of the reward so $250 for your efforts here as the PR would solve the issue, but given other circumstances out of your hands we choose different path.

Thanks for contributing ❤️

[mountiny]

@jliexpensify as a payment summary we got $250 to @Sourcecodedeveloper for their work on this issue, we are going to use different solution from a different issue which has similar effects though.

[mountiny]

I wanted to request re-evaluation of the 25% compensation because it is the second time similar has happened and such practice should be discouraged given that I had the proposal awarded first and the other solution could have been discussed prior to the PR being created.

I understand this is not ideal situation and I am sorry for this. In ideal world there would be no duplicates, however with the number of issues and contributors it happens that we miss this and there might be similar issue/ solution happening else where.

I dont want to make exceptions here as that would set precedence for other issues and makes the rules muddier, will stick with 25% here and I know you are a great engineer and contributor, who will be able to fix many other issues which will compensate for these two issues. This does not happen often and I am sorry you had this happen to you twice.

[mountiny]

I believe @koko57 has found a fix for the spinner now #28984

[jliexpensify]

Based on this comment, is this correct for a final Payment Summary for this issue @mountiny ?

• Contributor: @Sourcecodedeveloper $250 (can you edit your GH profile to include the same name as your Upworks profile, and apply for https://www.upwork.com/jobs/~017c59d6ab1d74e2a2?)

I'm assuming that we can close this issue after payment in favour of #28984?

[melvin-bot]

Current assignee @burczu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @Sourcecodedeveloper 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jliexpensify]

Paid and job closed!