[HOLD for payment 2023-12-06] [Distance] - Extra padding between the header and address field in waypoint editor

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #25707

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Request money > Distance
3. Click Start

Expected Result:

There is no extra padding between the header and address field in the waypoint editor

Actual Result:

There is extra padding between the header and address field in the waypoint editor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f960fba5bc1e0680
• Upwork Job ID: 1700179776262045696
• Last Price Increase: 2023-09-08
• Automatic offers:
• jjcoffee | Reviewer | 27224524
• Pujan92 | Contributor | 27224525

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra top margin for waypoint editor page

What is the root cause of that problem?

We have provided styles.mt4 to the address search container.

App/src/pages/iou/WaypointEditor.js

Line 208 in 9701fbe

containerStyles={[styles.mt4]}

What changes do you think we should make in order to solve the problem?

Update it with styles.mt3 for making it to 12px as suggested here.
I am not sure whether it is intentional or not, otherwise we can take that margin out.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

@lanitochka17 to ensure I'm understanding the bug correctly...
The expected is this padding

And the actual is below, where the extra padding is the red box area.

Is that correct?

@CortneyOfstad I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx

[CortneyOfstad]

Can do @mallenexpensify!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f960fba5bc1e0680

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[aimane-chnaif]

This will be handled in #23496

[mallenexpensify]

Thanks @shawnborton , please move forward with the PR @Pujan92

[mallenexpensify]

@Pujan92 are we waiting on a PR from you? (can't remember where we're at, I did just remove the hold from the title though!)

[Pujan92]

Yes @mallenexpensify, sorry for the delay as I missed this somehow. PR will be up by tomorrow.

[AndrewGable]

Waiting for PR from @Pujan92 !

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Extra padding between the header and address field in waypoint editor #31247

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment offer (Contributor)
• @jjcoffee requires payment offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A - this covers a lot of screens and probably the correct spacing was just missing from the start
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. It's a bit cumbersome to measure, but probably worth doing for design consistency
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Navigate to each of the below pages:

• Waypoint Editor Page
• Priority mode page
• App download link
• About page
• ReimbursementAccountPage (all steps)

2. Verify the top margin/padding is 12px between header and the start of the page's content

Do we agree 👍 or 👎

[mallenexpensify]

Contributor: @Pujan92 paid $500 via Upwork
Contributor+: @jjcoffee paid $500 via Upwork

TestRail GH

• https://github.com/Expensify/Expensify/issues/345509

Thanks!