[HOLD for payment 2023-11-22] Deleting a request report correctly takes you back to the workspace chat but doesn’t clear the navigation history

[JmillsExpensify]

As a result pressing < takes you BACK to a deleted page instead of UP to the LHN.

Reproduction video

RPReplay_Final1693672766.MP4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ddba2d8935891e4d
• Upwork Job ID: 1698674199278931968
• Last Price Increase: 2023-09-04

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

cc @adamgrzybowski could you have a look

[adamgrzybowski]

Hey @mountiny it seems that this PR should fix it

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ddba2d8935891e4d

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[mountiny]

Great, what needs to be done to take it out of draft?

[adamgrzybowski]

@mountiny I added videos and tests to my PR and took it out of the draft

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @sobitneupane, @mountiny, @adamgrzybowski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[neil-marcellini]

I'm removing this from the distance requests project because it's not specific to it.

[mountiny]

Almost forget about this. @luacmartins havent you worked on an issue where you have been trying to do the dismissModal for two reports for this case of deleting a request?

[luacmartins]

I reported a similar issue here and I think swm was working on it here. I see that issue is closed now and it seems like the problem still exists, so I don't think anyone is tackling it right now and we still need this issue.

[mountiny]

Maybe this will help too #26498

[JmillsExpensify]

It looks like #26498 will resolve this, though it's still in review.

[mountiny]

Adam is focusing on wave8 so giving it some time

[JmillsExpensify]

Still focused on wave8

[sobitneupane]

@s77rt is reviewing the PR associated with this issue. @s77rt #29497 issue look similar to this one. Will it be handled by this PR?

[s77rt]

Can someone please assign me here for PR review

[luacmartins]

Done!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Improve goBack function #26498

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment
• @adamgrzybowski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: I think this existed since day one
• The offending PR has been commented on: n/a
• A discussion in #expensify-bugs has been started: I don't think this is needed
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

Extending #30020 (comment)

1. Open a chat report with someone you have not chatted with before
2. Request money (using the plus + button in the composer)
3. Click on the IOU preview then on the transaction report action
4. Click on the 3 dots > Delete request
5. Verify you are redirected to the chat report
6. Go back
7. Verify you are not on the "not found" page

[JmillsExpensify]

Thanks so much @s77rt! I believe the payment summary is as follows:

• Issue reporter: N/A
• Contributor: expert agency (no payment)
• Contributor+: @s77rt $500

[JmillsExpensify]

Offer sent via upwork!

[s77rt]

Accepted! Thanks!

[JmillsExpensify]

Offer paid via Upwork and regression test created. Closing this one!