[$500] Workspace - User account closed is not removed in real-time in Workspace members page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch app
2. Tap profile
3. Tap workspaces
4. Select a Workspace
5. Tap members
6. Enter a new non existing user
7. Tap next
8. Tap invite
9. Open email link and validate the account(in other device or environment)
10. Open validated account(in other device or environment)
11. Tap profile
12. Tap security
13. Tap Close account
14. Enter email and confirm close account.
15. Note admin Workspace members page ie. 8th step(app)
16. Tap back button
17. Revisit Workspace members page

Expected Result:

When invited user closes the account, user must not be shown in admin Workspace members page

Actual Result:

When invited user closes the account, in real- time, user is not removed from admin Workspace members page. User has to navigate back from members page and revisit the page again to note the user of closed account to be removed from members list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62-1

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6186548_real_time.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01da2cae35a2022fcb
• Upwork Job ID: 1699326238020980736
• Last Price Increase: 2023-11-22

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01da2cae35a2022fcb

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[greg-schroeder]

Applied External

[ayazalavi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Members list in workspace members page is not updated real time.

What is the root cause of that problem?

As soon as the invited user closes their account, we have no way of subscribing to fetch the fresh members' list from the server.

What changes do you think we should make in order to solve the problem?

We need to update the user profile with custom data in the CloseAccount API callback. We can pass custom data, such as 'accountClosed,' like this:

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: ONYXKEYS.PERSONAL_DETAILS_LIST,
    value: {
        [assigneeAccountID]: null,
    },
}

On the other end, in the workspace members component, it will refresh, and we can fetch a fresh members list. So, in essence, we're just updating the profile data of the user closing the account and then retrieving it on the other end to fetch the latest members list.

Result:
https://github.com/Expensify/App/assets/767439/8b3798f8-fada-44da-8830-6bb64a25ca04

What alternative solutions did you explore? (Optional)

N/A

[ayazalavi]

@sobitneupane what do you think about my proposal #26593 (comment)?

[melvin-bot]

@sobitneupane, @greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

[greg-schroeder]

bump @sobitneupane

[ayazalavi]

@sobitneupane any update?

[sobitneupane]

will review the proposal shortly.

[sobitneupane]

Thanks for the proposal @ayazalavi.

Can you please add more details to your proposal? Why is SetInterval required here? I don't think it's good idea to fetch members repeatedly.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ayazalavi]

Proposal

Updated

[ayazalavi]

Proposal

Updated

[melvin-bot]

@sobitneupane @greg-schroeder this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[ayazalavi]

Updating my proposal.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sobitneupane, @greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@sobitneupane, @greg-schroeder Still overdue 6 days?! Let's take care of this!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Awaiting proposals

[greg-schroeder]

Same as above

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Posting in Callstack slack:

https://expensify.slack.com/archives/C03UK30EA1Z/p1700093219774199

[Piotrfj]

Hey, I'm Piotr from Callstack - expert contributor group - I would like to help resolve this issue

[sobitneupane]

@Piotrfj Could you kindly provide details on your approach to resolving the issue?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sobitneupane, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($500)

[greg-schroeder]

Yes, @Piotrfj do you mind giving a breakdown of your approach here? Thanks!

[aimane-chnaif]

This is dupe of #20264 but closed as edge case.
#20264 (comment)

[greg-schroeder]

Okay then, guess we're closing