Web - Emojis are accepted in name fields in " I know a teachers page"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. go to fab button -> save the world
2. now go to I know a teacher
3. in the name fields enter emojis like 😄😭😭

Expected Result:

Name fields should not accept emojis only field.

Actual Result:

Emojis are accepted in name fields in " I know a teachers page"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-30.at.5.48.15.PM.mov

Recording.4228.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693397428120089

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015f2493332ae4694a
• Upwork Job ID: 1708434857718169600
• Last Price Increase: 2023-10-01

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emojis are accepted in name fields in " I know a teachers page"

What is the root cause of that problem?

We are only checking if the values are non-empty:

App/src/pages/TeachersUnite/KnowATeacherPage.js

Lines 67 to 72 in 91ff78d

	if (_.isEmpty(values.firstName)) {
	ErrorUtils.addErrorMessage(errors, 'firstName', translate('bankAccount.error.firstName'));
	}
	if (_.isEmpty(values.lastName)) {
	ErrorUtils.addErrorMessage(errors, 'lastName', translate('bankAccount.error.lastName'));
	}

What changes do you think we should make in order to solve the problem?

We can add the same checks as for the legal name to validate the value.

App/src/pages/settings/Profile/PersonalDetails/LegalNamePage.js

Lines 54 to 58 in 91ff78d

	if (!ValidationUtils.isValidLegalName(values.legalFirstName)) {
	errors.legalFirstName = 'privatePersonalDetails.error.hasInvalidCharacter';
	} else if (_.isEmpty(values.legalFirstName)) {
	errors.legalFirstName = 'common.error.fieldRequired';
	}

ValidationUtils.isValidLegalName is based on CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS which would prevent emojis and other kind of undesired inputs. We can consider giving it a more generic name, e.g. isValidPersonName.

What alternative solutions did you explore? (Optional)

N/A

[AmjedNazzal]

Just FYI, this is same RC as this https://expensify.slack.com/archives/C049HHMV9SM/p1692198598449099 and this https://expensify.slack.com/archives/C049HHMV9SM/p1691823752102549 and a bunch of others, and it was decided to do nothing about it.

[melvin-bot]

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

I'm not really sure we need to add these controls. Do we have such a control in place for other email fields?

[melvin-bot]

@JmillsExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@JmillsExpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@JmillsExpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@JmillsExpensify 12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. @JmillsExpensify eroding to Weekly issue.

[melvin-bot]

@JmillsExpensify this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015f2493332ae4694a

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[melvin-bot]

@JmillsExpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aimane-chnaif]

Seems like no C+ assigned here for a month.
@samh-nl is your proposal still valid?

[samh-nl]

Turns out this is a duplicate - it was already fixed in #26275 using a similar solution.

[melvin-bot]

@JmillsExpensify, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Awesome, closing this as a dupe then!