[HOLD for payment 2023-10-05] [$500] mWeb - Update message with empty values shown when changing track distance in offline mode more than once

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. login to staging new dot
2. Go to preferences and turn offline mode on
3. Go to a workspace and select reimbursement
4. Click on rate in track distance and change the amount and click save
5. Again click on the rate and change the amount to something else and click save
6. Go to preferences and toggle offline mode off
7. Go to the admin room of the workspace in step 3
8. Observe that in addition to the corrected rate update message an addition updated the pendingAction of the Distance rate "Default Rate" from "" to "update" is shown with empty amounts.

Expected Result:

Search bar should be focused

Actual Result:

"Updated the pendingAction of the Distance rate "Default Rate" from "" to "update""

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.62-4

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023_08_23_08_35_31.mp4

Screen_Recording_20230904_194647_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: @SofoniasN

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692775659465039

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01123e24d63cdd9c43
• Upwork Job ID: 1701781124103757824
• Last Price Increase: 2023-09-13
• Automatic offers:
• s77rt | Reviewer | 26772413
• sofoniasN | Reporter | 26772420

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[anmurali]

Reproduced on staging on Mac/Chrome

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01123e24d63cdd9c43

[melvin-bot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[tsa321]

Proposal

Please re-state the problem that we are trying to solve in this issue

Update message with empty values shown when changing track distance rate more than once after going online from offline

What is the root cause of that problem?

App/src/libs/actions/Policy.js

Line 722 in 2d5bea5

customUnitRate: JSON.stringify(newCustomUnit.rates),

We include pendingAction field inside inside customUnitRate parameter when requesting UpdateWorkspaceCustomUnitAndRate API call. The pendingAction is used for front end use on offline functionality, so we don't need to send the value to back end. Then server send the updated message in report for each field which have been updated or have different value from previous. So: the updated the pendingAction of the Distance rate "Default Rate"... is displayed.

What changes do you think we should make in order to solve the problem?

We could omit the pendingAction field in customUnitRate parameter:

customUnitRate: JSON.stringify( _.omit(newCustomUnit.rates, ['pendingAction']))

What alternative solutions did you explore? (Optional)

N/A

[s77rt]

@tsa321 Thanks for the proposal. Your RCA makes sense, the backend seems to compare every prop that we send and pendingAction is supposed to be a client only field and should not be sent / compared with any prev values. Your solution looks good to me and I think we should do the same with errors.

A slightly different solution is that instead of using the whole object and excluding those that we don't need, we can construct a new object that only contains the props that we need. I have asked on Slack for that.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@deetergp @anmurali @s77rt this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[s77rt]

We have a proposal already and a working solution. I just bumped the slack thread as there may be better future proof solution.

[deetergp]

The silence in the Slack thread is deafening 😅 I am fine with just omitting it on the front end. Let's go with @tsa321's proposal.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tsa321 You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @SofoniasN 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @tsa321, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @tsa321 got assigned: 2023-09-20 08:26:00 Z
• when the PR got merged: 2023-09-25 07:43:41 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Workspace distance rate when offline #27870

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @tsa321 requires payment
• @SofoniasN requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Refactor custom unit rate update  #10557
• The offending PR has been commented on: Refactor custom unit rate update  #10557 (comment)
• A discussion in #expensify-bugs has been started: I don't think we need this for now but we have this slack thread.
• Determine if we should create a regression test for this bug: No

[melvin-bot]

@deetergp, @anmurali, @s77rt, @tsa321 Huh... This is 4 days overdue. Who can take care of this?

[deetergp]

Still holding?

[s77rt]

I think payment is due here

[deetergp]

@anmurali ^

[tsa321]

cc @anmurali ^^

[melvin-bot]

@deetergp, @anmurali, @s77rt, @tsa321 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Steppin' in to help here
Issue reporter: @SofoniasN paid $250 via Upwork (the bug was reported in Slack before we changed the bounty price)
Contributor: @tsa321 paid $750 via Upwork, inc. urgency bonus
Contributor+: @s77rt paid $750 via Upwork, inc. urgency bonus

@tsa321 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01123e24d63cdd9c43

live as of today, August 30th, and will affect all issues created after this point.

[tsa321]

@mallenexpensify thanks, I have accepted the offer.

[mallenexpensify]

Thanks @tsa321 , I just paid you, and updated the payment breakdown above!

Contributor: @tsa321 paid $750 via Upwork, inc. urgency bonus