[SMARTSCAN] [$500] LOW: Web - Request Money - "Changed the date to..." message looks as a new message after refreshing the page

[kbecciv]

Held on #30603

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open website
2. Click on + > Request money > Scan > Choose file, user and continue > Reach "Receipt scan in progress…" page > Change the description and date multiple times > Reload the page

Expected Result:

"Changed the date to..." message should not look as a new message even after refreshing the page

Actual Result:

"Changed the date to..." message looks as a new message after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-08-30T175326.879.2.webm

bandicam.2023-09-04.20-22-33-551.mp4

Expensify/Expensify Issue URL:
Issue reported by: @MahmudjonToraqulov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693399950131659

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b6e7b1cbb84756c
• Upwork Job ID: 1698913876057669632
• Last Price Increase: 2023-09-12

Issue Owner

Current Issue Owner: @cristipaval

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kadiealexander]

Repro:

2023-09-05_16-19-08.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010b6e7b1cbb84756c

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[nahid633]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request Money - "Changed the date to..." message looks as a new message after refreshing the page

What is the root cause of that problem?

New message indicator shows when shouldDisplayNewMarker is true and in the code there is state messageManuallyMarked
if (!messageManuallyMarked.read) {
shouldDisplayNewMarker = shouldDisplayNewMarker && reportAction.actorAccountID !== Report.getCurrentUserAccountID();
}

Basically we need to set mark report as read and make it shouldDisplayNewMarker false

What changes do you think we should make in order to solve the problem?

We need to add 'OR' case this part of the code
const didManuallyMarkReportAsUnread = report.lastReadTime < DateUtils.getDBTime() && ReportUtils.isUnread(report).

to check if
actionName is 'MODIFIEDEXPENSE' then mark that message as read(dont show new message indicator.).

indicator.mp4

What alternative solutions did you explore? (Optional)

none

[tienifr]

this is BE bug since API EditMoneyRequest returns the wrong lastReadTime for report

[kadiealexander]

@narefyev91 do you agree with this, that it should be marked internal?

[narefyev91]

@narefyev91 do you agree with this, that it should be marked internal?

Yes we should mark this as internal - we need some BE support

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Current assignee @narefyev91 is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kadiealexander]

@flodnv I got you assigned to handle the backend changes for this bug, thanks for your help!

[flodnv]

@mountiny I see you wrote this API command in the past couple of months, so I assume this should be assigned to you

[mountiny]

Same as above

[mountiny]

I think this belongs to the wave5

[cristipaval]

PR up for review

[cristipaval]

this should be fixed, as the PR hit production 3 days ago

[cristipaval]

@kadiealexander do we have any payment due here?

[kadiealexander]

I don't think so!