Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEED TO PAY STEVEN] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created #26722

Closed
6 tasks done
lanitochka17 opened this issue Sep 4, 2023 · 41 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 4, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #26580

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open a workspace chat
  3. Send a Distance IOU to the workspace chat

Expected Result:

The requester avatar and name are shown as soon as the request is created

Actual Result:

The requester avatar and name are not shown for a while

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.63-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188417_20230905_021312.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0130c70f29cf0ac46d
  • Upwork Job ID: 1701423694582550528
  • Last Price Increase: 2023-09-12
  • Automatic offers:
    • situchan | Reviewer | 26698696
    • StevenKKC | Contributor | 26698698
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@jliexpensify
Copy link
Contributor

@hayata-suenaga and @situchan , from the comment above:

Issue found when executing PR #26580

@jliexpensify jliexpensify changed the title Distance - The requester avatar and name are not shown for a while after request is created [REGRESSION?] Distance - The requester avatar and name are not shown for a while after request is created Sep 5, 2023
@StevenKKC
Copy link
Contributor

Proposal

Please state again the problem we are trying to solve in this issue.

Distance - The requester avatar and name are not shown for a while after request is created.

What is the cause of this issue?

The root cause is that we does not pass correct payeeAccountID and payeeEmail to IOU.getMoneyRequestInformation.

App/src/libs/actions/IOU.js

Lines 512 to 524 in 6b1a667

const {iouReport, chatReport, transaction, iouAction, createdChatReportActionID, createdIOUReportActionID, reportPreviewAction, onyxData} = getMoneyRequestInformation(
report,
participant,
comment,
amount,
currency,
created,
merchant,
null,
null,
null,
transactionID,
);

Because we pass payeeAccountID and payeeEmail with null, iouReport's managerID is set to null, and then reportPreviewAction's actorAccountID is set to 0.
managerID: payerAccountID,

actorAccountID: hasReceipt ? currentUserAccountID : iouReport.managerID || 0,

So the avatar and name are not shown until OpenReport returns correct report data.

What changes do you think we should make to solve the problem?

We should set correct payeeAccountID and payeeEmail in IOU.createDistanceRequest

const { ... } = getMoneyRequestInformation(
        ...
        userAccountID,
        currentUserEmail,
        ...
    );

What alternative solutions have you investigated? (Optional)

None.

@lanitochka17 lanitochka17 changed the title [REGRESSION?] Distance - The requester avatar and name are not shown for a while after request is created [REGRESSION?] [Distance] - The requester avatar and name are not shown for a while after request is created Sep 5, 2023
@hayata-suenaga
Copy link
Contributor

@StevenKKC where is getMoneyRequestInformation invoked?

@StevenKKC
Copy link
Contributor

@hayata-suenaga getMoneyRequestInformation is invoked in IOU.createDistanceRequest.

App/src/libs/actions/IOU.js

Lines 511 to 524 in cbda2b0

function createDistanceRequest(report, participant, comment, created, transactionID, amount, currency, merchant) {
const {iouReport, chatReport, transaction, iouAction, createdChatReportActionID, createdIOUReportActionID, reportPreviewAction, onyxData} = getMoneyRequestInformation(
report,
participant,
comment,
amount,
currency,
created,
merchant,
null,
null,
null,
transactionID,
);

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@jliexpensify, @hayata-suenaga, @situchan Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@jliexpensify, @hayata-suenaga, @situchan Eep! 4 days overdue now. Issues have feelings too...

@jliexpensify
Copy link
Contributor

Not overdue, but @hayata-suenaga did you want to review the above?

@melvin-bot melvin-bot bot removed the Overdue label Sep 12, 2023
@hayata-suenaga
Copy link
Contributor

I completely missed this thank you for pinging me 🙇

I somehow thought this one has already been fixed but it's still happening on production.

Screen.Recording.2023-09-12.at.10.31.12.AM.mov

@hayata-suenaga
Copy link
Contributor

I gonna make this issue external

@hayata-suenaga hayata-suenaga added the External Added to denote the issue can be worked on by a contributor label Sep 12, 2023
@melvin-bot melvin-bot bot changed the title [REGRESSION?] [Distance] - The requester avatar and name are not shown for a while after request is created [$500] [REGRESSION?] [Distance] - The requester avatar and name are not shown for a while after request is created Sep 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0130c70f29cf0ac46d

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@tgolen tgolen assigned tgolen and unassigned hayata-suenaga Sep 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 15, 2023
@tgolen
Copy link
Contributor

tgolen commented Sep 15, 2023

@situchan I think this is waiting for you to evaluate the proposal? It looks like a good proposal to me.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 22, 2023
@melvin-bot melvin-bot bot changed the title [$500] [Distance] - The requester avatar and name are not shown for a while after request is created [HOLD for payment 2023-09-29] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created Sep 22, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
  • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@situchan] Determine if we should create a regression test for this bug.
  • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@tgolen, @jliexpensify, @situchan, @StevenKKC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@tgolen
Copy link
Contributor

tgolen commented Oct 2, 2023

@jliexpensify Looks like this issue is waiting for you.

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@jliexpensify
Copy link
Contributor

jliexpensify commented Oct 2, 2023

Thanks for the bump Tim! Yep, was OOO and a whole bunch of issues hit the payment date. Sorting this out now.

@jliexpensify jliexpensify changed the title [HOLD for payment 2023-09-29] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created [SITU - WAITING ON CHECKLIST] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created Oct 2, 2023
@jliexpensify
Copy link
Contributor

Paid and job closed. @situchan just waiting on you to complete the checklist, cheers!

@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@tgolen
Copy link
Contributor

tgolen commented Oct 5, 2023

bump @situchan to complete the checklist

@melvin-bot melvin-bot bot removed the Overdue label Oct 5, 2023
@StevenKKC
Copy link
Contributor

@jliexpensify I am afraid to let you know that My Upwork account is suspended permanently so I couldn't withdraw money. I would be really appreciate it if you refund money and send to my friend's account.

@jliexpensify
Copy link
Contributor

jliexpensify commented Oct 6, 2023

@StevenKKC I'm sorry, but we cannot pay out your funds to another account, as this is a breach of Upworks T+C's and could cause Expensify to be suspended. Can you share some additional context/details on what's happening with your situation, and I'll bring this up with our team? Feel free to DM me if you like.

@jliexpensify
Copy link
Contributor

@StevenKKC our team has reached out to Upworks specifically regarding this issue and unfortunately, there is nothing that can be done from our side - we have to pay into your Upworks account. The advice we have been given is to ask you to continue working with Upworks to get your account restored. Thanks for your understanding!

@situchan can you also complete the checklist please?

@StevenKKC
Copy link
Contributor

Yes, thank you for your consideration. I received the terrible news from Upwork support that my account has been permanently disabled. In this case what should I do?

@jliexpensify
Copy link
Contributor

@StevenKKC this is something you'll need to talk to Upworks about. As mentioned before, we're not able to pay via another means, sorry about that!

@situchan
Copy link
Contributor

situchan commented Oct 9, 2023

  • The PR that introduced the bug has been identified. Link to the PR: Modify MoneyRequestConfirmPage for Distance Request #25707
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25707/files#r1349870552
  • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
  • Determine if we should create a regression test for this bug.
  • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This was caught by Applause team so I don't think we need more regression test.

@jliexpensify
Copy link
Contributor

@StevenKKC an update from our team: I'm going to close this issue for now. Once you've resolved things with Upworks, please tag me and I will re-open and pay you.

@jliexpensify jliexpensify changed the title [SITU - WAITING ON CHECKLIST] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created [NEED TO PAY STEVEN] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants