-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEED TO PAY STEVEN] [$500] [Distance] - The requester avatar and name are not shown for a while after request is created #26722
Comments
Triggered auto assignment to @jliexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
@hayata-suenaga and @situchan , from the comment above:
|
ProposalPlease state again the problem we are trying to solve in this issue.Distance - The requester avatar and name are not shown for a while after request is created. What is the cause of this issue?The root cause is that we does not pass correct Lines 512 to 524 in 6b1a667
Because we pass payeeAccountID and payeeEmail with null , iouReport 's managerID is set to null , and then reportPreviewAction 's actorAccountID is set to 0 .Line 1935 in 6b1a667
Line 2207 in 6b1a667
So the avatar and name are not shown until OpenReport returns correct report data.
What changes do you think we should make to solve the problem?We should set correct const { ... } = getMoneyRequestInformation(
...
userAccountID,
currentUserEmail,
...
); What alternative solutions have you investigated? (Optional)None. |
@StevenKKC where is |
@hayata-suenaga Lines 511 to 524 in cbda2b0
|
@jliexpensify, @hayata-suenaga, @situchan Eep! 4 days overdue now. Issues have feelings too... |
@jliexpensify, @hayata-suenaga, @situchan Eep! 4 days overdue now. Issues have feelings too... |
Not overdue, but @hayata-suenaga did you want to review the above? |
I completely missed this thank you for pinging me 🙇 I somehow thought this one has already been fixed but it's still happening on production. Screen.Recording.2023-09-12.at.10.31.12.AM.mov |
I gonna make this issue external |
Job added to Upwork: https://www.upwork.com/jobs/~0130c70f29cf0ac46d |
Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new. |
Current assignee @situchan is eligible for the External assigner, not assigning anyone new. |
@situchan I think this is waiting for you to evaluate the proposal? It looks like a good proposal to me. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-29. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@tgolen, @jliexpensify, @situchan, @StevenKKC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@jliexpensify Looks like this issue is waiting for you. |
Thanks for the bump Tim! Yep, was OOO and a whole bunch of issues hit the payment date. Sorting this out now. |
Paid and job closed. @situchan just waiting on you to complete the checklist, cheers! |
bump @situchan to complete the checklist |
@jliexpensify I am afraid to let you know that My Upwork account is suspended permanently so I couldn't withdraw money. I would be really appreciate it if you refund money and send to my friend's account. |
@StevenKKC I'm sorry, but we cannot pay out your funds to another account, as this is a breach of Upworks T+C's and could cause Expensify to be suspended. Can you share some additional context/details on what's happening with your situation, and I'll bring this up with our team? Feel free to DM me if you like. |
@StevenKKC our team has reached out to Upworks specifically regarding this issue and unfortunately, there is nothing that can be done from our side - we have to pay into your Upworks account. The advice we have been given is to ask you to continue working with Upworks to get your account restored. Thanks for your understanding! @situchan can you also complete the checklist please? |
Yes, thank you for your consideration. I received the terrible news from Upwork support that my account has been permanently disabled. In this case what should I do? |
@StevenKKC this is something you'll need to talk to Upworks about. As mentioned before, we're not able to pay via another means, sorry about that! |
This was caught by Applause team so I don't think we need more regression test. |
@StevenKKC an update from our team: I'm going to close this issue for now. Once you've resolved things with Upworks, please tag me and I will re-open and pay you. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #26580
Action Performed:
Expected Result:
The requester avatar and name are shown as soon as the request is created
Actual Result:
The requester avatar and name are not shown for a while
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.63-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6188417_20230905_021312.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: