[HOLD for payment 2023-10-20] [$500] [$1,000] Android - App freezes after killed app is called via concierge deep-link

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login to NewDot
2. Kill app
3. Tap concierge deep-link from another mobile application (https://staging.new.expensify.com/concierge)

Expected Result:

App is opened, concierge chat is displayed

Actual Result:

App freezes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.64-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6189863_video_02.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb7f1ef5548a9cf1
• Upwork Job ID: 1699456046868582400
• Last Price Increase: 2023-10-04

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fb7f1ef5548a9cf1

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[imranaalam]

---

Problem Statement:
When tapping on a deep link to the Concierge chat from another mobile application, the Expensify app freezes instead of displaying the Concierge chat.

---

Root Cause:
The root cause could be attributed to several factors:

1. Delay or failure in resolving the Welcome.serverDataIsReadyPromise():

   Explanation:
   The navigateToConciergeChat function waits for the promise Welcome.serverDataIsReadyPromise() to resolve. This promise ensures that the server data is ready before proceeding with the chat navigation. If there's a delay or failure in this resolution, it can halt the process and cause the app to freeze.

   Possible Scenarios:

   • The server might be experiencing delays, resulting in a longer response time.
   • Network issues could be affecting the app's communication with the server.
   • The promise itself might have a bug or issue, preventing proper resolution.

2. Misrepresentation by the isNetworkOffline variable:

   Explanation:
   The app uses the isNetworkOffline variable to determine the network's status. If this variable isn't accurate, it might lead the app down an unintended logic path.

   Possible Scenarios:

   • The method determining network status might be outdated or slow.
   • The network could be intermittent, causing unpredictable behavior.
   • A bug might exist in the logic that sets or updates this variable.

3. Complex Navigation Logic:

   Explanation:
   The functions navigateToConciergeChat and openReportFromDeepLink contain intricate conditions that decide the navigation route. If a specific state isn't accounted for, it could leave the app without a defined navigation action, causing it to hang.

   Possible Scenarios:

   • Unaccounted edge cases or states within the logic.
   • Asynchronous operations not completing as expected.
   • Conflicting navigation actions.

4. Report Rerouting Issues:

   Explanation:
   The app's logic handles instances where an optimistically created report later matches a preexisting report. If this rerouting has issues, it can disrupt the app's flow.

   Possible Scenarios:

   • Faulty logic in the deletion of the optimistically created report.
   • Delays in obtaining information about the preexisting report.
   • Corrupted or incorrect navigation state updates.

5. Deep Link Initialization in DeepLinkWrapper:

   Explanation:
   The DeepLinkWrapper component handles deep links. If there's an initialization issue or if these deep links aren't processed correctly, the app might become unresponsive when activated.

   Possible Scenarios:

   • Inaccurate capture or processing of deep links.
   • Conflicts between the initial deep link and subsequent changes.
   • Logic conflicts between the component and other app states.

---

Proposed Solution:

• Ensure that the Welcome.serverDataIsReadyPromise() resolves correctly. Implement a timeout to handle scenarios where it might take too long or not resolve at all.
• Improve the accuracy of the isNetworkOffline check, possibly by using a more robust method or library to check network connectivity.
• Refactor navigation logic to ensure there's always a definitive navigation action for every possible state. Add proper error handling and fallbacks.
• Handle report rerouting more gracefully, ensuring that the user experience isn't disrupted.
• Thoroughly test and debug the deep link initialization process to ensure it works seamlessly.

---

Alternative Solution:

• Bypass the server data check if it's causing significant delays, especially for operations that don't strictly require the most recent server data.
• Use service workers or background tasks to pre-fetch or update necessary data, reducing the reliance on real-time network checks.
• Simplify navigation logic by having a default route or chat that the app can fall back to in ambiguous situations.
• Implement a more user-friendly error or loading screen that informs users when there's a delay, providing options to retry or navigate elsewhere.
• Reevaluate the deep link structure or implementation method to ensure it's optimized for the app's architecture.

---

[robertKozik]

Thank you, @imranaalam, for your thoughtful analysis. Your insights are indeed valuable. However, it seems that we might need to dig a bit deeper to pinpoint the exact root cause of the issue. While you've highlighted several potential scenarios and solutions, finding the specific factor would be immensely helpful.

[NicMendonca]

@robertKozik any update here?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[robertKozik]

@NicMendonca, I'm still waiting for proposals. The one that's already here doesn't pinpoint exactly what's causing it or how to tackle it. It just lists potential root causes and general solutions.

[robertKozik]

Still no proposals

[NicMendonca]

Doubled the price

[melvin-bot]

@NicMendonca @robertKozik this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[NicMendonca]

^ doubled the price this week

[melvin-bot]

@NicMendonca, @robertKozik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix - app freeze issue #29245

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @HezekielT requires payment
• @robertKozik does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix - app freeze issue #29245

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @HezekielT requires payment
• @robertKozik does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix - app freeze issue #29245

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @HezekielT requires payment
• @robertKozik does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[NicMendonca]

@HezekielT can you please apply to the job here? Thanks -- https://www.upwork.com/jobs/~01fb7f1ef5548a9cf1

[NicMendonca]

@robertKozik bump on BZ checklist: #26867 (comment)

[HezekielT]

@NicMendonca Applied. Thanks!

[robertKozik]

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: In my opinion this issue was an adge-case which was not handled before, so no any particular PR introduced it
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I don't think the regression test is needed here
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[NicMendonca]

@HezekielT - sent offer!

[HezekielT]

@NicMendonca If I'm not mistaken, I think the offer should be $1000 given that the price was doubled and the payment should be $1500 since it was merged within 3 days. Regardless of that, I have accepted the offer. Thank you.

[NicMendonca]

@HezekielT yep - we apply that in the form of bonuses.

[NicMendonca]

• reporter: n/a
• contributor: @HezekielT - $1500
• c+ @robertKozik (n/a)

All set!

[HezekielT]

@NicMendonca Thank You!