Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] LHN - Uh-oh something went wrong screen displayed after splitting bill and returning online #26885

Closed
2 of 6 tasks
lanitochka17 opened this issue Sep 6, 2023 · 107 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open the app and log into the same account on main and secondary device
  2. Disable the internet on the main device
  3. Tap FAB > Split bill
  4. Split bill with 2 users
  5. On the secondary device split the same bill with same users
  6. Enable the internet connection on the main device
  7. Navigate to LHN

Expected Result:

User is returned online and can keep using the app

Actual Result:

After returning online the "Uh-oh something went wrong" screen is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.64-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6190241_video_2023-09-05_23-03-25.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018cf27bdeeb75326a
  • Upwork Job ID: 1699877376966991872
  • Last Price Increase: 2023-10-02
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@MitchExpensify MitchExpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Current assignee @MitchExpensify is eligible for the Bug assigner, not assigning anyone new.

@MitchExpensify MitchExpensify removed their assignment Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@MitchExpensify MitchExpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@MitchExpensify
Copy link
Contributor

Reassigning as I'm going OOO until Tuesday! (I'm in PORTUGAL @NicMendonca !)

@MitchExpensify
Copy link
Contributor

Will take it back upon return

@NicMendonca NicMendonca added the External Added to denote the issue can be worked on by a contributor label Sep 7, 2023
@melvin-bot melvin-bot bot changed the title LHN - Uh-oh something went wrong screen displayed after splitting bill and returning online [$500] LHN - Uh-oh something went wrong screen displayed after splitting bill and returning online Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018cf27bdeeb75326a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@NicMendonca, @MitchExpensify, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@NicMendonca, @MitchExpensify, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@rezkiy37
Copy link
Contributor

rezkiy37 commented Dec 4, 2023

I think the expected behavior is to split bill 2 times successfully.

Alright, if we want achieve it, we really need help here. Because the error is returned by the backend. @MitchExpensify, who can help us from the backend side?

Screenshot 2023-12-04 at 16 28 46

@0xmiros
Copy link
Contributor

0xmiros commented Dec 4, 2023

🎀 👀 🎀 getting engineer to help with backend

Copy link

melvin-bot bot commented Dec 4, 2023

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hayata-suenaga
Copy link
Contributor

@0xmiroslav thank you for the review of proposals

the conversation in this GH issue seems quite long. I'd appreciate it if you could summarize what we found so far and what we have to do in the backend.

@0xmiros
Copy link
Contributor

0xmiros commented Dec 4, 2023

Here's summary:
The user did split bill actions in 2 devices logged in with same account. First one is done offline. 2nd one is done online. First one made online after 2nd one is done.

These are the fields to split bill: participants, amount, description, merchant, etc
We haven't tested all cases yet but according to our testing so far:

  • Different amount and same participants: both requests are successful
  • Different participants and same amount: both requests are successful
  • Same amount and same participants: 2nd request (online) is successful. 1st request (offline) is failed from backend and the error is Unexpected error creating this chat, please try again later. There is a previously existing chat between these users.

(We left description, merchant empty when run these tests so they are all same)

So what we need now to debug and fix this issue is that why backend throws that error

@hayata-suenaga
Copy link
Contributor

@0xmiroslav did you get any error code (a string like this one? 8230FE6F-E7AE-4FF3-90B8-B2F64EA46D0C)?

@rezkiy37
Copy link
Contributor

rezkiy37 commented Dec 5, 2023

@hayata-suenaga, fyi: #26885 (comment).

@melvin-bot melvin-bot bot added the Overdue label Dec 7, 2023
@rezkiy37
Copy link
Contributor

rezkiy37 commented Dec 7, 2023

Waiting on some updates from the backend side by @hayata-suenaga.

@melvin-bot melvin-bot bot removed the Overdue label Dec 7, 2023
@hayata-suenaga
Copy link
Contributor

yep I'm working on it

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

@MitchExpensify, @rezkiy37, @0xmiroslav, @hayata-suenaga Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hayata-suenaga
Copy link
Contributor

will work later this week.

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2023
@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Dec 12, 2023

Memo for myself

Auth code where the error is thrown

Condition: chatReportID != newChatReportID

In Transaction::createMoneyRequest, if the participants of a report is the same, the createChatReport method of Report will return the existing report for these participants.

When a report is created as a result of a split money request, the...

IOU.createSplitsAndOnyxData generates/get the report ID that is used inside IOU.splitBillAndOpenReport to be sent along with the SplitBillAndOpenReport Web-E command.

@hayata-suenaga
Copy link
Contributor

@0xmiroslav could you check if the issue happens when a IOU chat report already exists between the two parties?

@rezkiy37
Copy link
Contributor

@hayata-suenaga, do you mean this case?

Test.mp4

@rezkiy37
Copy link
Contributor

No update.

@hayata-suenaga
Copy link
Contributor

sorry I'm checking this today

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2023
@rezkiy37
Copy link
Contributor

Melvin, no "overdue". Waiting on some update from @hayata-suenaga.

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2023
@rezkiy37
Copy link
Contributor

No update.

@hayata-suenaga
Copy link
Contributor

checking with the internal team if the but is worth fixing

@MitchExpensify
Copy link
Contributor

This scenario is too much of an edge case for us to prioritize right now so we have decided it is best to close it for now

Copy link

melvin-bot bot commented Dec 25, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

10 participants