Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web – Request Money - "Report Not Found" Error expensify.com sign-in page opens by the Email link #26938

Closed
1 of 6 tasks
izarutskaya opened this issue Sep 7, 2023 · 32 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@izarutskaya
Copy link

izarutskaya commented Sep 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Click the green + icon and select request money

  2. Enter an amount and click next

  3. Enter the email address of a user that doesn't have an existing account and request $x to confirm and send the request.

  4. Go to the email inbox of that user you just invited and make sure the email is received - it will look like this
    image

  5. Click the "Expensify" hyperlink in the email

Expected Result:

Navigated to the New Expensify sign-in page and not the expensify.com sign-in page.

Actual Result:

Navigated to the expensify.com sign-in page with The Error message "Report not Found"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome /
  • MacOS / Desktop

Version Number: 1.3.65-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6190827_OldDot_2.mp4

Bug6190827_Split_Old

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013568bf585c519a67
  • Upwork Job ID: 1699857983227707392
  • Last Price Increase: 2023-09-07
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Christinadobrzyn Christinadobrzyn changed the title Web – Request Money - Error expensify.com sign-in page opens by the Email link Web – Request Money - "Report Not Found" Error expensify.com sign-in page opens by the Email link Sep 7, 2023
@Christinadobrzyn
Copy link
Contributor

I can reproduce this - I can't find any other reports of this.
I think this needs to be internal but not quite sure...

@Christinadobrzyn Christinadobrzyn added the Internal Requires API changes or must be handled by Expensify staff label Sep 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013568bf585c519a67

@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@rushatgabhane, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@rushatgabhane, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Christinadobrzyn
Copy link
Contributor

Hey @rushatgabhane can you confirm if this should be internal? I can add an engineering label if yes. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@rushatgabhane
Copy link
Member

@Christinadobrzyn yes, this is internal.

@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Overdue label Sep 15, 2023
@Christinadobrzyn
Copy link
Contributor

Hi @chiragsalian let me know if you have the bandwidth to take this job on and an update on a PR. thanks!

@melvin-bot melvin-bot bot removed the Overdue label Sep 15, 2023
@chiragsalian
Copy link
Contributor

Hi Christina, im swamped. Could you find another engineer to tackle this or should i unassign and post in engg chat instead?
Also is this a daily. I'm wondering if it could be demoted to weekly instead.

@marcochavezf marcochavezf added Weekly KSv2 and removed Daily KSv2 labels Sep 22, 2023
@rushatgabhane rushatgabhane removed their assignment Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 28, 2023

@marcochavezf @Christinadobrzyn this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 28, 2023
@Christinadobrzyn
Copy link
Contributor

I don't think WAQ applies here because this is an internal issue and not customer-facing. But going to move this back to weekly. I wonder if this should be monthly even?

@Christinadobrzyn Christinadobrzyn added Monthly KSv2 and removed Daily KSv2 labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

@marcochavezf @Christinadobrzyn this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Oct 5, 2023
@Christinadobrzyn
Copy link
Contributor

I'm not sure what to do with this issue - maybe I should reach out in BZ room and see if someone else can take it? Seems like moving to monthly doesn't stop the WAQ messaging.

Reached out to @marcochavezf to see if he has an idea

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 9, 2023

@marcochavezf, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@marcochavezf
Copy link
Contributor

I will work on this one today

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@marcochavezf
Copy link
Contributor

marcochavezf commented Oct 9, 2023

We're probably not setting the param isChat for this condition when we call the API command RequestMoney. For some reason, my bwm is stuck to debug the issue. I will continue later

@Christinadobrzyn
Copy link
Contributor

working on it Melvin!

@marcochavezf
Copy link
Contributor

Still wrapping up some priorities for wave7, no update atm

@marcochavezf
Copy link
Contributor

No update, tackling one issue by one

@marcochavezf
Copy link
Contributor

No update, focused on TU launch

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@marcochavezf
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@Christinadobrzyn
Copy link
Contributor

Should I move this to weekly @marcochavezf?

@marcochavezf
Copy link
Contributor

Thanks for the suggestion @Christinadobrzyn, I already have a fix for it I will create a PR tomorrow, so I will leave it as daily atm since it can be experienced by real customers with the latest wave launches.

@marcochavezf
Copy link
Contributor

marcochavezf commented Oct 18, 2023

Oh noticed this is no longer an issue:

Dev:
Screenshot 2023-10-18 at 3 14 18 p m

Staging (we're not sending emails from staging, but the report can be opened if we add the staging subdomain to the url):
Screenshot 2023-10-18 at 3 20 12 p m

@izarutskaya could you verify from your end too?

@marcochavezf
Copy link
Contributor

Closing it out because it's already fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants