-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$1000] Workspace - App crashes when entering Bank account page #26958
Comments
Triggered auto assignment to @laurenreidexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Opening the bank account after going back using the device back button/swipe will crash the app (on dev, an error will show) What is the root cause of that problem?The error I got is This error comes from the auto-focus code of text input. On Android, App/src/components/TextInput/BaseTextInput.js Lines 66 to 78 in d63ea05
When we open the bank account page for the first time by going to Workspace > Bank Account > Connect manually, the focus works fine. When we press the device back button, it navigates us to the workspace page instead of the initial page of a bank account (where there is a plaid and manual option). Opening the Bank account once again takes us immediately to the 1st step of bank account and somehow the page is unmounted[1] once and then remounted. The issue is that when the page is unmounted, we don't clear the focus timeout (see above code that we return nothing after setting a timeout), so when the timeout is done, the ref is already null. [1] explanation of why the 1st page of the bank account page is unmounted: What changes do you think we should make in order to solve the problem?When App/src/components/TextInput/BaseTextInput.js Lines 73 to 78 in d63ea05
|
Job added to Upwork: https://www.upwork.com/jobs/~01d23926d190e45c2e |
Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
@laurenreidexpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@laurenreidexpensify, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@thesahindia bump for review thanks |
@bernhardoj can you check if you are still getting the error? I was able to repro it in the morning but now I can't repro it. |
@thesahindia Yes, still reproducible Screen.Recording.2023-09-13.at.12.22.04.mov |
For some reason I can't repro it. I am on latest main. Screen.Recording.2023-09-14.at.1.17.21.AM.mov |
@thesahindia hmm, that's really weird. I can still reproduce it on we can ask QA to retest it too |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@thesahindia bump ^^ |
@laurenreidexpensify @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@laurenreidexpensify, everything is fine on my end. Let's ask QA team to test it again. |
Thanks! PR is ready cc: @thesahindia |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary:
|
@thesahindia bump for checklist steps so we can close this one out! |
@laurenreidexpensify hi, I think we are eligible for the 50% bonus. |
@thesahindia bump for checklist thanks |
@thesahindia bump to get this one closed thanks |
I think it was a regression from the refactor. Not sure if we could have prevented it. Here are the steps if we wanna add a test case -
|
$1,500 payment approved for @thesahindia based on this summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
App does not crash
Actual Result:
App crashes
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.65-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6191172_Screen_Recording_20230907_153227_One_UI_Home.mp4
logs2.txt
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: