Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-10-18] Add Global Nav component #27000

Closed
hayata-suenaga opened this issue Sep 8, 2023 · 21 comments
Closed

[$500] [HOLD for payment 2023-10-18] Add Global Nav component #27000

hayata-suenaga opened this issue Sep 8, 2023 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Sep 8, 2023

Add the new Global Navigator component.

Implement the new GN. Add the Avatar, Chat, and Global Create buttons on it.

Mockup is coming...

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e642e5cdb1d956db
  • Upwork Job ID: 1716590225572917248
  • Last Price Increase: 2023-10-23
@hayata-suenaga hayata-suenaga added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 8, 2023
@hayata-suenaga hayata-suenaga self-assigned this Sep 8, 2023
@hayata-suenaga hayata-suenaga added Engineering and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 8, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Sep 8, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Sep 8, 2023
@hayata-suenaga hayata-suenaga changed the title Implement the new Left Hand Navigator [HOLD Expensify #314917]Implement the new Left Hand Navigator Sep 8, 2023
@hayata-suenaga hayata-suenaga changed the title [HOLD Expensify #314917]Implement the new Left Hand Navigator [HOLD Expensify #315012]Implement the new Left Hand Navigator Sep 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@hayata-suenaga
Copy link
Contributor Author

This hasn't started yet. Will assigns a SWM engineer once they confirm that they have a capacity to take on this issue.

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@hayata-suenaga hayata-suenaga added Daily KSv2 and removed Daily KSv2 labels Sep 11, 2023
@hayata-suenaga hayata-suenaga changed the title [HOLD Expensify #315012]Implement the new Left Hand Navigator Add Global Nav component Sep 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 13, 2023
@hayata-suenaga
Copy link
Contributor Author

A SWM engineer is working on a PoC PR ⬆️

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

@hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

@hayata-suenaga Still overdue 6 days?! Let's take care of this!

@hayata-suenaga
Copy link
Contributor Author

Adam from SWM is working on this. I gonna assign Adam once they comment on this issue.

@melvin-bot melvin-bot bot removed the Overdue label Sep 22, 2023
@adamgrzybowski
Copy link
Contributor

👁 👁

@hayata-suenaga
Copy link
Contributor Author

@adamgrzybowski please link the PoC PR you're working on to this issue 🙇

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 11, 2023
@melvin-bot melvin-bot bot changed the title Add Global Nav component [HOLD for payment 2023-10-18] Add Global Nav component Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@rushatgabhane
Copy link
Member

heads up, we have this regression https://expensify.slack.com/archives/C049HHMV9SM/p1697459165285599

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

@allroundexperts, @adamgrzybowski, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Oct 23, 2023

Payment summary

@s77rt and @allroundexperts helped with the review of the PR that was done by an expert agency engineer (Software Mansion)

We should pay for these two, taking into considering the regression that @rushatgabhane mentioned here

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@laurenreidexpensify laurenreidexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Expensify Expensify deleted a comment from melvin-bot bot Oct 23, 2023
@greg-schroeder
Copy link
Contributor

Taking a look

@greg-schroeder
Copy link
Contributor

I'm going to apply External to create an upwork job

@greg-schroeder greg-schroeder added the External Added to denote the issue can be worked on by a contributor label Oct 23, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-10-18] Add Global Nav component [$500] [HOLD for payment 2023-10-18] Add Global Nav component Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e642e5cdb1d956db

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

@greg-schroeder greg-schroeder removed the External Added to denote the issue can be worked on by a contributor label Oct 23, 2023
@greg-schroeder
Copy link
Contributor

Payment summary from here: #27000 (comment)

Looks like we will be paying $250 to each reviewer:

@allroundexperts you can make a manual request tied to this issue for $250
@s77rt offer sent to you via upwork for $250

@JmillsExpensify
Copy link

$250 payment approved for @allroundexperts based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

8 participants