[HOLD for payment 2023-10-09] [$500] Chat - Mentioning a user in new offline conversation displays user picker transparent

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Turn off the connection
3. Click FAB icon and select/start new chat
4. Type @

Expected Result:

The suggestion list shows custom avatars for users that have them

Actual Result:

The suggestion list is shown transparent

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66-3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6193068_RPReplay_Final1694180324.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ab2a548d85f3dca
• Upwork Job ID: 1700212174202789888
• Last Price Increase: 2023-09-08

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Mentioning a user in new offline conversation displays user picker transparent

What is the root cause of that problem?

The ReportActionCompose component is wrapped by OfflineWithFeedback, and the Suggestions component inherits its opacity.

What changes do you think we should make in order to solve the problem?

When the composer focuses, we won't change the opacity of it. We did the same for ReportActionItemMessageEdit here.

We change this LOC to:

pendingAction={isFocused ? null : pendingAction}

Before

Screen.Recording.2023-09-09.at.12.16.24.AM.mov

After

Screen.Recording.2023-09-09.at.12.06.49.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ab2a548d85f3dca

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention suggestions displays in a transparent popup in new offline conversation

What is the root cause of that problem?

In ReportActionCompose, OfflineWithFeedback component wraps all the children. OfflineWithFeedback component has opacity(0.5) in offline state for pending report.

App/src/styles/styles.js

Line 2965 in b11bddc

opacity: 0.5,

Suggestions are children of this component and so opacity is applied to suggestions as well.
This is the root cause

What changes do you think we should make in order to solve the problem?

We need to use React.createPortal to avoid opacity inheritance.
As you can see below, we have already this function in AutoCompleteSuggestions component

App/src/components/AutoCompleteSuggestions/index.js

Line 58 in b11bddc

return ReactDOM.createPortal(<View style={StyleUtils.getBaseAutoCompleteSuggestionContainerStyle({left, width, bottom})}>{componentToRender}</View>, document.querySelector('body'));

We changed the parentContainerRef props to measureParentContainer props in this PR but this change was applied only to propTypes and parent components. Those changes were not applied to AutoCompleteSuggestions component itself.

In order to fix this, the following replacements are needed

App/src/components/AutoCompleteSuggestions/index.js

Line 17 in b11bddc

function AutoCompleteSuggestions({parentContainerRef, ...props}) {

function AutoCompleteSuggestions({measureParentContainer, ...props}) {

App/src/components/AutoCompleteSuggestions/index.js

Lines 39 to 44 in b11bddc

	React.useEffect(() => {
	if (!parentContainerRef || !parentContainerRef.current) {
	return;
	}
	parentContainerRef.current.measureInWindow((x, y, w) => setContainerState({left: x, bottom: windowHeight - y, width: w}));
	}, [parentContainerRef, windowHeight, windowWidth]);

    React.useEffect(() => {
        if (!measureParentContainer) {
            return;
        }
        measureParentContainer((x, y, w) => setContainerState({left: x, bottom: windowHeight - y, width: w}));
    }, [measureParentContainer, windowHeight, windowWidth]);

App/src/components/AutoCompleteSuggestions/index.native.js

Line 5 in b11bddc

function AutoCompleteSuggestions({parentContainerRef, ...props}) {

function AutoCompleteSuggestions({measureParentContainer, ...props}) {

This works as expected

Result

27036.mp4

What alternative solutions did you explore? (Optional)

[lschurr]

@rushatgabhane could you review the proposals here?

[rushatgabhane]

When the composer focuses, we won't change the opacity of it. We did the same for ReportActionItemMessageEdit here.

@ginsuma interesting solution but I think it's a hack. Making opacity depend on focus state doesn't seem intuitive 😅

[rushatgabhane]

It looks like we forgot to pass the correct props down. I like @s-alves10's solution #27036 (comment)

C+ reviewed 🎀 👀 🎀

[rushatgabhane]

@lschurr could you please add engineering label, I'm temporarily removed from c+ team so my super powers are gone :)

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lschurr]

Shoot, I missed this. Adding Eng now.

[lschurr]

Bump @techievivek

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent transparent suggestion list by using portal #27771

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @s-alves10 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@rushatgabhane could you complete the checklist for this one?

[lschurr]

Payment summary:

• Bug reporter: Applause (no payment needed)
• Contributor: @s-alves10 $500 (paid in Upwork)
• Contributor+: @rushatgabhane $500

[lschurr]

@s-alves10 could you accept the offer in Upwork? (https://www.upwork.com/nx/wm/offer/26729370)

[s-alves10]

@lschurr

Accepted. Thanks

[lschurr]

Bump @rushatgabhane for the checklist: #27036 (comment)

[lschurr]

Waiting on the checklist.

[techievivek]

Gentle bump @rushatgabhane to complete the above checklist.

[rushatgabhane]

WIP ⚠️

1. The PR that introduced the bug has been identified. Link to the PR:

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

4. Determine if we should create a regression test for this bug.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

[rushatgabhane]

created a payment request - https://staging.new.expensify.com/r/3291458028812337

[lschurr]

Are you still working on that checklist @rushatgabhane or are we good to close this one?

[JmillsExpensify]

$500 payment approved for @rushatgabhane based on BZ summary.