[$500] LHN - Сonversation is not displayed in bold when new messages are received

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a New Expensify app
2. Log in using any login A
3. Navigate to the concierge conversation
4. Open https://staging.new.expensify.com/
   in your browser
5. Log in using any login B
6. Send a message from user B to user A
7. Under user A in the application, navigate to Settings/Preferences
8. Activate the "Force offline" mode
9. Send a message from user B to user A
10. Deactivate the "Force offline" mode
11. Focus on the conversation with the concierge

Expected Result:

When receiving new messages when exiting offline mode, the conversation name should become bold in the LHN

Actual Result:

When receiving new messages when leaving offline mode, the conversation is not displayed in bold in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.199.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01005d8dd45f8b4890
• Upwork Job ID: 1700237159903662080
• Last Price Increase: 2023-09-08
• Automatic offers:
• tienifr | Contributor | 26684669

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01005d8dd45f8b4890

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[allroundexperts]

As @Santhosh-Sellavel is OoO for couple of weeks, I can take this over!

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When receiving new messages when leaving offline mode, the conversation is not displayed in bold in LHN

What is the root cause of that problem?

In this line, we're checking if current report is visible, if yes we call openReport on it. The problem is if we ever opened the report before (but we already switched to another report), isTopMostReportId will be true. Because that value is calculated at the time that report is opened here, and never changes once another report goes on top. It's a regression from this PR where we migrate the ReportScreen to functional component, before that change, the isTopMostReportId is always recalculated inside the listener.

This leads to, when we go back to the report after sending messages from another tab, it calls openReport on the not-on-top report, causing the incoming new messages to be read immediately and the bold style does not show (because it only shows for unread report here.

Meanwhile, if we send new messages from another device, without changing the visibility of the current tab. The bold style will show normally because the openReport is not run in that case.

What changes do you think we should make in order to solve the problem?

We can make isTopMostReportId a function to make sure it's evaluated any time the listener run. This is the same logic as we have previously, before the migration to functional component.

1. Update here to

const isTopmostReportId = () => Navigation.getTopmostReportId() === getReportID(route);

2. Use that function here

if (!getIsReportFullyVisible(isTopMostReportId()) || report.isOptimisticReport) {

3. Use it here as well

What alternative solutions did you explore? (Optional)

We can make isTopMostReportId a dependency of the useEffect that registers the listener here, but I'm not sure we want that since it will reregister the listener any time the topmost report changes.

Another potential solution is to add the visibility listener only when the report is topmost report or it's optimistic report, if that is no longer true, we'll remove the listener because it doesn't make sense any more to listen to the visibility change in that case, since we'll early return here already.

[abekkala]

@allroundexperts have you had a chance to review the proposal?

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($500)

[abekkala]

@allroundexperts friendly bump on reviewing the Proposal that has been provided :)

[allroundexperts]

@tienifr's proposal looks good to me. It has the correct RCA and proposes a working solution as well.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

@hayata-suenaga @allroundexperts This issue is no longer reproducible, it has been fixed via this PR (which fixes another issue that has similar root cause). So I think we can close this one.

[abekkala]

@hayata-suenaga do you agree we can just close this issue out?

[hayata-suenaga]

@allroundexperts could you double check on this comment?

[melvin-bot]

@abekkala @allroundexperts @hayata-suenaga @tienifr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[abekkala]

@allroundexperts can you please confirm the above?

[abekkala]

@allroundexperts can you please address the comment above (#27038 (comment)?)?

cc: @hayata-suenaga

[allroundexperts]

That's accurate @abekkala. Let's close this!

[hayata-suenaga]

bumped @allroundexperts in slack