[$500] Web - Assignee email or name is missing for other users

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to chat with userB
2. Click on + icon and select assign task option
3. Enter title and create task
4. Go to task thread
5. Click on Assignee and select Assignee with whom userB didn't have chat history
6. From userB, check the Assignee in task thread

Expected Result:

Assignee email or name should show

Actual Result:

Assignee email or name is missing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.67.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-11.at.11.03.09.AM.mov

Recording.4378.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693807403315129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018f80383d65e746df
• Upwork Job ID: 1701221850589401088
• Last Price Increase: 2023-10-02

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018f80383d65e746df

[melvin-bot]

Triggered auto assignment to @sakluger (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[h0u554m]

Stop emitting the 'assign event' when a user is assigned, and emit it only when a message is sent.

Your Expensify account email: https://new.expensify.com/a/15606409
Upwork Profile Link: https://www.upwork.com/freelancers/~01d68a22e5d906bca6

[melvin-bot]

📣 @h0u554m! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[h0u554m]

Stop emitting the 'assign event' when a user is assigned, and emit it only when a message is sent.

Contributor details
Your Expensify account email: https://new.expensify.com/a/15606409
Upwork Profile Link: https://www.upwork.com/freelancers/~01d68a22e5d906bca6

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[h0u554m]

Stop emitting the 'assign event' when a user is assigned, and emit it only when a message is sent.

Contributor details
Your Expensify account email:
[email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01d68a22e5d906bca6

[h0u554m]

Stop emitting the 'assign event' when a user is assigned, and emit it only when a message is sent.

Contributor details
Your Expensify account email:
[email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01d68a22e5d906bca6

[flaviadefaria]

We're waiting for proposals.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[flaviadefaria]

@kadiealexander I'm going OoO for a week so assigning this to you so that you can move it forward in the meantime. I'll take it back from you once I'm online again. Thanks!

[kadiealexander]

I also can no longer reproduce this error. @gadhiyamanan could you please confirm if you can still reproduce it?

[gadhiyamanan]

it is still reproduciable
you need to select Assignee with whom userB didn't have chat history
please try with normal gmail account

Screen.Recording.2023-09-20.at.10.56.35.AM.mov

[kadiealexander]

My userB was a brand new account with no conversation history with the assignee:

[kadiealexander]

Tried again with a gmail account as User B, all accounts are on different domains:

[ArekChr]

@kmostafa599 What is the root cause of the issue? Please follow the proposal template

[kmostafa599]

@ArekChr The current implementation of the setAssigneeValue function in codebase generates random IDs and uses a fake owner email and owner account when creating an optimistic chat report. This approach can lead to inconsistencies and potential issues in our application, as the generated IDs and owner details do not correspond to actual user data.

The root cause of this problem is the use of randomly generated IDs and fake owner details when creating an optimistic chat report. This can lead to inconsistencies as these details do not match with actual user data.

modify the setAssigneeValue function to use the proper user email instead of a fake one. This will involve the following steps:

Retrieving User Data: When the setAssigneeValue function is called, we will retrieve the actual user data from our database or authentication service. This data should include the user’s email and account ID.

Modifying Chat Report Generation: In the buildOptimisticChatReport function, will replace the randomly generated IDs and fake owner email with the actual user data retrieved in step 1. This will ensure that the chat report is linked to an actual user account.

Updating Share Destination: If a share destination isn’t already set in this step, will set the shareDestination as that chat report.

[kadiealexander]

@ArekChr any further thoughts?

[melvin-bot]

@ArekChr @kadiealexander @flaviadefaria this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[kadiealexander]

@gadhiyamanan can you still reproduce this? I've never been able to.

[gadhiyamanan]

still able to reproduce

Screen.Recording.2023-09-28.at.10.43.01.AM.mp4

[kadiealexander]

@gadhiyamanan the video doesn't match the steps in the OP, could you please rewrite new reproduction steps?

[gadhiyamanan]

I am doing the same thing, which step am i missing ?

[kadiealexander]

I'm not sure, I just can't reproduce. When I try, I can't assign the task to a third user. All are gmail accounts.

2023-09-29_16-25-03.mp4

[gadhiyamanan]

try this

1. from userA, create a chat with userB and userC (receiver also need to send message otherwise it will not reflect in Assignee list )
2. from userA, Click on + icon and select assign task option
3. Enter title and select userB as share somewhere
4. create task
5. from userB, Go to task thread
6. from userA, Go to task thread and Assign task to userC

Untitled.mp4

[melvin-bot]

@ArekChr @kadiealexander @flaviadefaria this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@ArekChr, @kadiealexander, @flaviadefaria Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[flaviadefaria]

I tried reproducing this and also couldn't reproduce it. @kadiealexander @ArekChr have you been able to reproduce this with @gadhiyamanan last steps?

[ArekChr]

Same here, couldn't reproduce this issue, when reassigning tasks to someone else I see the correct avatar and display name

[flaviadefaria]

Ok since no one seems to be able to reproduce this I'll close this for now.