[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-25] Display company cards in Wallet

[luacmartins]

HELD on #22872

Implement this section of the design doc - https://docs.google.com/document/d/1vnZSy0ot3Ykz7sRTw2A5Cvuj9_azjkj90ikE_iuwvF8/edit#bookmark=id.fn2ijzi5eww7

We’ll use PaymentMethodList to display company cards with the following changes:
We’ll pass () => {} to the onPress prop
The cardName will be set to cardName
We’ll set props.shouldShowRightIcon={isExpensifyCard) to hide the right caret We’ll use BankIcons.getBankIcon to display the icon associated with the card program. Icon assets already exist in assets/images/bankicons`
We’ll add a new iconStyle prop to MenuItem and pass it to the Icon component here.
We’ll then pass the rounded square style as seen in the mocks.
We’ll add the same styles to the bank account tile icons.
We’ll add a new prop canClose to OfflineWithFeedback, defaulting to true.
We’ll conditionally render the close button if canClose is true
We’ll pass () => {} as onClose callback to OfflineWithFeedback
We’ll pass interactive={isExpensifyCard}
We’ll pass canDismissError = isExpensifyCard in renderItem

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7d9a978f64c8780
• Upwork Job ID: 1702220961846599680
• Last Price Increase: 2023-09-14

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c7d9a978f64c8780

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @s77rt, @luacmartins eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[luacmartins]

@shawnborton I just realized that we actually don't set any bank icon styles and they come from the SVGs. Example below:

Do we have bank icon SVGs that match the square with rounded borders, like we show in the design doc mocks?

[shawnborton]

I can create them all for you. Can you share with me the existing bank SVGs we have? As well as a list of all of the cards we'll support, too. Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Display company cards #29718

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[s77rt]

Regression Test Proposal
Pre-requisites: an account with an imported bank card and an expensify card

1. Go to Settings > Payments
2. Verify that you see the expensify card first and it has a right caret
3. Verify that the company card does not have the right caret and that there's no hover style

[luacmartins]

The regression test steps above look good. We also have additional ones as part of the design doc.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Wave 8- Card Settings] CLEAN UP - Filter out personal cards, fix route to card page, fix card icons #29834

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[JmillsExpensify]

Payment summary:

• $500 to @s77rt for this PR review.
• $500 to @s77rt for this PR review.

[JmillsExpensify]

Offer sent. I hope you don't mind, I batch both of those into one Upwork payment for simplicity. We can circle back after the regression period passes.

[s77rt]

@JmillsExpensify Accepted! Thank you!

[JmillsExpensify]

Awesome, thanks! We'll be ready when the time comes.

[melvin-bot]

@JmillsExpensify, @shawnborton, @s77rt, @luacmartins, @grgia Huh... This is 4 days overdue. Who can take care of this?

[luacmartins]

I think we're just pending payment here

[JmillsExpensify]

Yes, apologies for the delay! Offer paid via Upwork.