[HOLD for payment 2023-10-05] [$500] IOS - Bottom of Preference page is not transparent

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Login with any account on iPhone X and above
2. Go Settings => Preferences
3. Scroll up and down, observer the bottom of the page.

Expected Result:

Bottom of the Preference page should be transparent

Actual Result:

Bottom of the Preference page is not transparent

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1694601966.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694676966334599

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01687aa628faa714e2
• Upwork Job ID: 1702690337682669568
• Last Price Increase: 2023-09-15
• Automatic offers:
• hungvu193 | Contributor | 26742473
• hungvu193 | Reporter | 26742474

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01687aa628faa714e2

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[kbecciv]

Proposal by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694676966334599

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bottom of Preference page is not transparent

What is the root cause of that problem?

We're adding bottomPadding here which make the bottom isn't transparent with the case we didn't have footer component.

App/src/components/IllustratedHeaderPageLayout.js

Line 59 in d68263a

<View style={[styles.flex1, StyleUtils.getBackgroundColorStyle(themeColors.appBG), !isOffline ? safeAreaPaddingBottomStyle : {}]}>

What changes do you think we should make in order to solve the problem?

Solution 1

We only need the padding if we have the footer so we should update the condition:
!isOffline ? safeAreaPaddingBottomStyle : {}
to
!isOffline && !_.isNull(footer) ? safeAreaPaddingBottomStyle : {}

Solution 2:

Remove !isOffline ? safeAreaPaddingBottomStyle : {} and update style of the FixedFooter:

const safeAreaMarginBottom = StyleUtils.getSafeAreaMargins(insets);

{!_.isNull(footer) && <FixedFooter style={[!isOffline ? safeAreaMarginBottom : {}]}>{footer}</FixedFooter>}

What alternative solutions did you explore? (Optional)

N/A

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bottom of the Preference page is not transparent

What is the root cause of that problem?

One condition is missing and it should be the first to check in order safeAreaPaddingBottomStyle to work and bottom of the preference page to be transparent ie. we did not have the footer component

App/src/components/IllustratedHeaderPageLayout.js

Line 62 in 2427a06

<View style={[styles.flex1, appBGColor, !isOffline ? safeAreaPaddingBottomStyle : {}]}>

What changes do you think we should make in order to solve the problem?

First thing first we need check if we have footer:

!_.isNull(footer) && !isOffline ? safeAreaPaddingBottomStyle : {}

What alternative solutions did you explore? (Optional)

NA

Result:

[robertKozik]

Hi @hungvu193 @PiyushChandra17! Thank you both for your proposals. After careful consideration, it's evident that both of you have accurately identified the root cause of the issue, and your proposed solutions are quite similar. Due to the timing, I'm inclined to go with @hungvu193's proposal as it was the first one. Regarding the solution, I'm leaning towards the first option as it seems more descriptive, but I'm open to further discussion on this.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tylerkaraszewski]

Does anyone know why github won't let me assign @hungvu193? He just will not appear in the dropdown for assignees.

[aimane-chnaif]

Does anyone know why github won't let me assign @hungvu193? He just will not appear in the dropdown for assignees.

@hungvu193 needs to comment something here.
This usually happens when proposal from slack is posted by QA team and then is accepted without contributor's comment.

[laurenreidexpensify]

Bumped @hungvu193 in Slack too :)

[PiyushChandra17]

@robertKozik Sure, we need to check footer first and it's different from what @hungvu193 proposed, it's the vital check first going forward with this one.

Also @tylerkaraszewski @laurenreidexpensify if he is unavailable, i can take this going forward :)

[hungvu193]

Does anyone know why github won't let me assign @hungvu193? He just will not appear in the dropdown for assignees.

Sorry you can assign me now

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hungvu193 got assigned: 2023-09-18 23:27:45 Z
• when the PR got merged: 2023-09-22 16:39:20 UTC
• days elapsed: 3

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix bottom PreferencePage not transparent #27738

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment offer (Contributor)
• @robertKozik does not require payment (Contractor)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary:

• External issue reporter @hungvu193 $50 payment issued in Upwork
• Contributor that fixed the issue @hungvu193 @500 payment issued in Upwork
• Contributor+ that helped on the issue and/or PR @robertKozik agency worker, no payment issued

[laurenreidexpensify]

@robertKozik please advise on regression steps in checklist above, thanks

[robertKozik]

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: Cannot trace any particular PR which introduced this behaviour
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. I don't think the regression test is needed here. It's visual bug which don't interfere with any user flow
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

tldr; I don't think the regression test is needed here. It's visual bug which don't interfere with any user flow

[laurenreidexpensify]

Thanks @robertKozik 👍