[$500] Assign task - Marking the Task as Complete or incomplete does not focus the composer

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any task report page
2. Click "Mark as done". Notice the composer is not focused
3. Go to the three dots and click on Mark as incomplete. Notice the composer is not focused

Expected Result:

Marking the Task as Complete or incomplete focuses the composer

Actual Result:

Marking the Task as Complete or incomplete does not focus the composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.70-5

Reproducible in staging?: Y

**Reproducible in production?:**Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

T146taskfocus-1.mp4

2023-09-15.14.17.08.mov

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694057465609589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dda7cab075cd4ea4
• Upwork Job ID: 1702707529787387904
• Last Price Increase: 2023-09-15

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dda7cab075cd4ea4

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task - Marking the Task as Complete or incomplete does not focus the composer

What is the root cause of that problem?

We are missing focusing logic on Task Status changes.
I feel we don't need to focus back on the composer when Task is completed.
But we should focus back to the composer when a task is re-opened.

What changes do you think we should make in order to solve the problem?

We should use ReportActionComposeFocusManager to focus on the composer when Task is reopened here:

App/src/pages/home/HeaderView.js

Line 119 in 76b6914

onSelected: () => Task.reopenTask(props.report, title),

Implemetation:

Import ReportActionComposeFocusManager in HeaderView.js:

import ReportActionComposeFocusManager from '../../libs/ReportActionComposeFocusManager';

then here:

onSelected: () => {
    Task.reopenTask(props.report, title);
    ReportActionComposeFocusManager.focus();
},

---

We should also add focus when task is reopened using TaskHeaderActionButton:

App/src/components/TaskHeaderActionButton.js

Line 41 in 8d928c2

ReportUtils.isCompletedTaskReport(props.report) ? Task.reopenTask(props.report, props.report.reportName) : Task.completeTask(props.report, props.report.reportName)

---

Result:

Screencast.from.19-09-23.07.59.26.AM.IST.webm

What alternative solutions did you explore? (Optional)

xx

[poonam286]

Hi i want help with this

[melvin-bot]

📣 @poonam286! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[poonam286]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01c0d53d695396e11c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mananjadhav]

on the composer when Task is reopened here.

@neonbhai I didn't understand what you mean here, it links to the current issue itself. Can you please elaborate?

[strepanier03]

I am able to recreate this but I raised here to discuss expected behavior.

I get that we're not focusing the composer but why would we expect the composer needs to be focused after marking a task complete or incomplete?

[neonbhai]

@mananjadhav Hi, I have updated the link and added implementation details in proposal(comment).

[neonbhai]

Hi @strepanier03, we refocus on the TextInput elements whenever we expect the user to type something, such as opening a chat, start filling a form, navigating back to a report. With this we decrease friction of the user by intelligently focusing on the important areas of the App on user actions.

[strepanier03]

@neonbhai - Please join the discussion here if you'd like to help move this forward. Right now the plan is to close this GH as a feature request.

[strepanier03]

I'll reopen if we decide to make a change.