[HOLD for #30153 - $500] The selected attachment modal don't hide when drag a file

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any report
2. Click +
3. Click Add Attachment
4. Drag a file to report screen

Expected Result:

The selected attachment modalshould hide when drag a file

Actual Result:

The selected attachment modal don't hide when drag a file

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-13.at.11.09.50.mov

Recording.252.mp4

Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694578316488209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0148455e0883b1f9ba
• Upwork Job ID: 1702778220407894016
• Last Price Increase: 2023-10-06

Issue Owner

Current Issue Owner: @situchan

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0148455e0883b1f9ba

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[raymondchooi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

File picker does not close on file drag and drop

What is the root cause of that problem?

The user is allowed to drop files in the <ReportDropUI /> component while the file picker is open.

What changes do you think we should make in order to solve the problem?

1. When the picker is opened with Add attachment:

App/src/components/AttachmentPicker/index.js

Line 80 in 76c1559

fileInput.current.click();

2. We can call another function to set the state setIsAttachmentPreviewActive to false:

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 239 in 76c1559

setIsAttachmentPreviewActive(false);

3. This will disable the file drop here:

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 398 in 76c1559

if (isAttachmentPreviewActive) {

4. We should probably rename this state to something like setIsAttachmentPicking

What alternative solutions did you explore? (Optional)

As we have limited access to the file picker, we could listen for images dropped and force a redirect or similar to trigger the file picker to close

[peterdbarkerUK]

Discussed a little here.

[raymondchooi]

@peterdbarkerUK ignore if the discussion link wasn't meant to be seen externally but I can't access the link or see/find any other discussions other than the initial linked slack discussion

[peterdbarkerUK]

Hey @raymondchooi - yes, that one was private, left it here for my own ease of tracking! Apologies for the confusion

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[peterdbarkerUK]

@situchan - what do you think of the proposal?

[melvin-bot]

@peterdbarkerUK @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@peterdbarkerUK, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@peterdbarkerUK, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[situchan]

Let's fix this case as well so ideally all popovers, system modals should be closed while dragging file.

Screen.Recording.2023-10-03.at.5.30.39.PM.mov

Still open for better proposals

[peterdbarkerUK]

Friendly bump on this one @situchan :)

[melvin-bot]

@peterdbarkerUK, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[situchan]

FAB menu is automatically closed while dragging over LHN. Similar to this, we can fix all popover cases

[DylanDylann]

@situchan It seems we have another PR handle this issue

[melvin-bot]

@peterdbarkerUK, @situchan Eep! 4 days overdue now. Issues have feelings too...

[situchan]

@peterdbarkerUK let's hold this for #30153. I subscribed to that PR so we'll see how it goes.

[melvin-bot]

@peterdbarkerUK, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

Holding PR is still in review

[melvin-bot]

@peterdbarkerUK, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[situchan]

#31154 was merged today. Waiting for hitting production

[DylanDylann]

Can't reproduce anymore. let's close this

[melvin-bot]

@peterdbarkerUK, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[situchan]

Let's close

[melvin-bot]

@peterdbarkerUK, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!