[HOLD for payment 2023-10-09] [$500] Dev: Web - Unnecessary two back icons in #Room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon and select Send message option
2. Go to #Room tab

Expected Result:

It should show only one back icon

Actual Result:

Two back icons in #Room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.70.5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-16.at.10.27.24.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694840257162789

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ce9ae2774c7e1dd5
• Upwork Job ID: 1703143519242104832
• Last Price Increase: 2023-09-16
• Automatic offers:
• c3024 | Contributor | 26809665
• gadhiyamanan | Reporter | 26809666

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not found page when selecting room in RHP in send message option of FAB shows another back button.

What is the root cause of that problem?

There is a back button for the RHP as a whole for send message and here

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 147 in 76c1559

<FullPageNotFoundView shouldShow={!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length}>

we are showing another back button again.

What changes do you think we should make in order to solve the problem?

We should add shouldShowBackButton={false} here

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 147 in 76c1559

<FullPageNotFoundView shouldShow={!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length}>

I think instead of a generic error we can show

1. title as emptyWorkspace.title from en.ts and show no subtitleKey.
2. Keep title as it is and show subtitleKey as emptyWorkspace.title
3. Use linkKey as emptyWorkspace.title and give corresponding onLinkPress for creating workspace.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ce9ae2774c7e1dd5

[melvin-bot]

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

📣 @MuzanEDM! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sonialiap]

@eVoloshchak what do you think of the above proposals?

[eVoloshchak]

The fix is pretty straightforward, @c3024's proposal looks good to me!

1. title as emptyWorkspace.title from en.ts and show no subtitleKey.
2. Keep title as it is and show subtitleKey as emptyWorkspace.title
3. Use linkKey as emptyWorkspace.title and give corresponding onLinkPress for creating workspace.

Totally agree with this also, the generic error we currently displaying is fine, but more specific error explaining to users what's exactly wrong is always better

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

🎯 ⚡️ Woah @eVoloshchak / @c3024, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @c3024 got assigned: 2023-09-22 04:03:22 Z
• when the PR got merged: 2023-09-26 10:48:00 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• remove duplicate back icon in "# Room" tab for "Send Message" when there is no workspace  #27983

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @c3024 requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Fix for: Web - Incorrect Redirection to Chat Page when Accessing /workspace/new-room URL #23486
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23486/files#r1355533015
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a simple visual bug, additional discussion isn't needed
• Determine if we should create a regression test for this bug.
  This is a small visual bug that didn't prevent user from using the app, so regression tests isn't necessary

[JmillsExpensify]

Awaiting a payment summary to issue payment.

[sonialiap]

@gadhiyamanan reporter $50 - paid ✔️
@c3024 fix + bonus = $750 - paid ✔️
@eVoloshchak review + bonus = $750 - in NewDot

[JmillsExpensify]

$750 payment approved for @eVoloshchak based on summary above.