[HOLD for payment 2023-11-13] [HOLD for payment 2023-10-30] Implement Reassure Regression Testing for SideBarLinks, LHN and ReportScreen

[muttmuure]

Problem

We are implementing a range of initiatives to reduce the number of re-renders for app components, starting with LHN, SideBarLinks and ReportScreen.

Without proper tracking of these initiatives, we will be unable to objectively track regressions.

Solution

We need:

• A plan for identifying the heaviest components to re-render using Reassure.
• A process to perform ongoing tests in Reassure to ensure any regressions are monitored.

We already have Reassure set up in the app so we could work on how to expand this in other components https://github.com/callstack/reassure/tree/main

[adhorodyski]

First tests for LHN are right around the corner, with eg. a whooping 45 rerenders just to get the list on the screen 💪
After this, together with @koko57 we'll transition to the ReportScreen to get the first tests there.

[mountiny]

Thanks for an update Adam

[adhorodyski]

ReportScreen tests are in progress (List ones first to come in the next week), we're also onboarding @OlimpiaZurek to help with the testing and let @koko57 focus more on the Waves work :)

[mountiny]

Looking good, got some PRs to prod now

[adhorodyski]

@mountiny please see our update on this scope.

So far we have:

• LHN tests in place, covering the list with interactions to make sure we don't add new render commits on handlers
• ReportActionsList tests, where we test the list in isolation from the screen

Things to come:

• ReportScreen holistic tests - list + composer interactions. @OlimpiaZurek is working on it and is expecting to have a PR by the EOW.
• Composer tests targeting only the input interactions (without the chat list). @OlimpiaZurek will cover this starting next week, shouldn't take long as we can reuse the mocks from holistic ReportScreen tests.

I believe with all this in place we can close the work for this scope (core functionalities of these 2 screens will be covered) and add any new tests as separate efforts. Please let me know your thoughts on this!

[mountiny]

I think this sounds good and we should explore adding more thorough tests as a quick follow up

[adhorodyski]

ReportScreen tests have been merged, ones targeting Composer are now being internally reviewed under a draft PR. This will close the initial scope of this task.

[mountiny]

Perfect, thank you!

[adhorodyski]

@mountiny I believe we're now able to close this issue and focus on the measureFunction() tests/come up with any other if you think that'd add more value. Please let me know what you think 😊

[mountiny]

All LHN, SideBarLinks and ReportScreen. has been completed closing

Great job @adhorodyski @OlimpiaZurek @koko57

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] feat: add Reassure perf tests to ReportScreen #30414

If no regressions arise, payment will be issued on 2023-11-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @adhorodyski does not require payment (Contractor)