-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] [HOLD for payment 2023-11-21] Explore options how to avoid lots of report screens pushed on stack in desktop layout #27651
Comments
👁️ 👁️ |
plz let me know if i should be doing something specific on this issue - ty! |
Nothing specific now thanks! |
Bumped in Slack for more eyes since Adam is busy with hybrid web |
@adamgrzybowski should have something in store for this one, curious to see that once the wave8 hustle settles down a bit |
PR is up |
This issue has not been updated in over 15 days. @mountiny, @maddylewis, @adamgrzybowski, @situchan eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
This one is done right? |
yes, just waiting for payment. |
Triggered auto assignment to @johncschuster ( |
Bug0 Triage Checklist (Main S/O)
|
@johncschuster could you please pay out $500 to @situchan for their review on the PR? Thank you! |
@johncschuster, @mountiny, @adamgrzybowski, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Sorry I missed this! I'll get payment sorted now! |
Job added to Upwork: https://www.upwork.com/jobs/~01fb0ef201d2d160a5 |
Current assignee @situchan is eligible for the External assigner, not assigning anyone new. |
@situchan I've just invited you to the job. Can you ping me when you've accepted so I can issue payment? Thank you! |
@johncschuster accepted. thanks |
@johncschuster All paid out, can we close? Thanks! |
Yessir! I've just issued payment! |
Coming from https://expensify.slack.com/archives/C05LX9D6E07/p1694767889647489
### Problem:
Because of the way we chose to do navigation, every time we navigate to a new report, we're adding a new component to the navigation stack. That is bad because, overtime, we'll have so many components in the navigation stack that it will consume too much memory and make the app slow. This is a problem mainly for desktop since we don't really click on back and the app doesn't restart frequently, but can affect web too.
### Solution:
Still to be explored, but we need to keep the same navigation patterns and ideally limit the number of memory the screens even frozen would take
Issue Owner
Current Issue Owner: @johncschusterUpwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: