Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [HOLD for payment 2023-11-21] Explore options how to avoid lots of report screens pushed on stack in desktop layout #27651

Closed
mountiny opened this issue Sep 18, 2023 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented Sep 18, 2023

Coming from https://expensify.slack.com/archives/C05LX9D6E07/p1694767889647489

### Problem:

Because of the way we chose to do navigation, every time we navigate to a new report, we're adding a new component to the navigation stack. That is bad because, overtime, we'll have so many components in the navigation stack that it will consume too much memory and make the app slow. This is a problem mainly for desktop since we don't really click on back and the app doesn't restart frequently, but can affect web too.

### Solution:

Still to be explored, but we need to keep the same navigation patterns and ideally limit the number of memory the screens even frozen would take

Issue OwnerCurrent Issue Owner: @johncschuster
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fb0ef201d2d160a5
  • Upwork Job ID: 1729882695643987968
  • Last Price Increase: 2023-11-29
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels Sep 18, 2023
@mountiny mountiny self-assigned this Sep 18, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 18, 2023
@adamgrzybowski
Copy link
Contributor

👁️ 👁️

@maddylewis
Copy link
Contributor

plz let me know if i should be doing something specific on this issue - ty!

@melvin-bot melvin-bot bot removed the Overdue label Sep 27, 2023
@mountiny
Copy link
Contributor Author

Nothing specific now thanks!

@mountiny mountiny moved this to MEDIUM in [#whatsnext] #quality Sep 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 6, 2023
@mountiny
Copy link
Contributor Author

Bumped in Slack for more eyes since Adam is busy with hybrid web

@mountiny
Copy link
Contributor Author

@adamgrzybowski should have something in store for this one, curious to see that once the wave8 hustle settles down a bit

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2023
@mountiny mountiny added the Reviewing Has a PR in review label Oct 24, 2023
@mountiny
Copy link
Contributor Author

PR is up

Copy link

melvin-bot bot commented Nov 20, 2023

This issue has not been updated in over 15 days. @mountiny, @maddylewis, @adamgrzybowski, @situchan eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@adamgrzybowski
Copy link
Contributor

This one is done right?

@situchan
Copy link
Contributor

yes, just waiting for payment.
@maddylewis is OOO until Nov 27

Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Nov 20, 2023
@mountiny mountiny added the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny mountiny removed Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review labels Nov 20, 2023
@mountiny
Copy link
Contributor Author

@johncschuster could you please pay out $500 to @situchan for their review on the PR? Thank you!

@mountiny mountiny changed the title Explore options how to avoid lots of report screens pushed on stack in desktop layout [HOLD for payment 2023-11-21] Explore options how to avoid lots of report screens pushed on stack in desktop layout Nov 20, 2023
Copy link

melvin-bot bot commented Nov 24, 2023

@johncschuster, @mountiny, @adamgrzybowski, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Overdue Daily KSv2 and removed Daily KSv2 Overdue labels Nov 24, 2023
@johncschuster
Copy link
Contributor

Sorry I missed this! I'll get payment sorted now!

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2023
@johncschuster johncschuster added the External Added to denote the issue can be worked on by a contributor label Nov 29, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-11-21] Explore options how to avoid lots of report screens pushed on stack in desktop layout [$500] [HOLD for payment 2023-11-21] Explore options how to avoid lots of report screens pushed on stack in desktop layout Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01fb0ef201d2d160a5

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

@johncschuster
Copy link
Contributor

@situchan I've just invited you to the job. Can you ping me when you've accepted so I can issue payment? Thank you!

@situchan
Copy link
Contributor

@johncschuster accepted. thanks

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Dec 4, 2023

@johncschuster All paid out, can we close? Thanks!

@johncschuster
Copy link
Contributor

Yessir! I've just issued payment!

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@github-project-automation github-project-automation bot moved this from MEDIUM to Done in [#whatsnext] #quality Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

5 participants