Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-09-18 #27654

Closed
91 tasks done
OSBotify opened this issue Sep 18, 2023 · 11 comments
Closed
91 tasks done

Deploy Checklist: New Expensify 2023-09-18 #27654

OSBotify opened this issue Sep 18, 2023 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 18, 2023

Release Version: 1.3.71-12
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 18, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.71-5 🚀

@mvtglobally
Copy link

@thienlnam we still don't have Android build. Can you pls double check

@thienlnam
Copy link
Contributor

Ah crap, looking now - going to try to rebuild Android

@thienlnam
Copy link
Contributor

thienlnam commented Sep 19, 2023

We're running into an issue right now with the android build process, @AndrewGable is looking into it!

@AndrewGable
Copy link
Contributor

Android should be fixed starting version 1.3.71-6

@kavimuru
Copy link

kavimuru commented Sep 19, 2023

@thienlnam Regression 83% progress in the TR. We are working on Android PR slots and few more PRs in all the platforms.

#26602 is failing with #27712
#26854,#27139, #25512, #25564 are failing with #27713
#27137 is failing with #26308 - not fixed
#27287 is failing with #27677
#27340 is failing with #27715 - repro in production, checking off
#27421 is failing with #27723 - repro in production, checking off
#27479 is failing with #27707- repro in production, checking off
#26217 is failing with #27775 - repro in production, checking off

@kavimuru
Copy link

kavimuru commented Sep 19, 2023

@thienlnam Regression is just 2% left

#26602 is failing with #27712
#26854#27139, #25512, #25564 #27088, #27139 are failing with #27713
#27137 is failing with #26308 - not fixed - Okay to check it off?
#27287 is failing with #27677
#27340 is failing with #27715 - repro in production, checking off
#27421 is failing with #27723 - repro in production, checking off
#27479 is failing with #27707- repro in production, checking off
#26217 is failing with #27775 - repro in production, checking off
#27491 is failing with #27800 - repro in production, checking off
#27190 is failing in mWeb with #23908 (not fixed) - Okay to check it off?

#26747 - for android slot, our team does not have a small height device with in scope OS. Could you check internally?

@kavimuru
Copy link

kavimuru commented Sep 19, 2023

@thienlnam Regression is completed.
#26602 is failing with #27712
#26854, #25512, #25564 #27088, #27139 are failing with #27713
#27137 is failing with #26308 - not fixed - Okay to check it off?
#27287 is failing with #27677
#27190 is failing in mWeb with #23908 (not fixed) - Okay to check it off?
#26747 - for android slot, our team does not have a small height device with in scope OS. Could you check internally?
#27180 is failing with #27815 - Repro in production. Okay to check it off?

There are open blockers

@cristipaval
Copy link
Contributor

#27774 has a fix that was merged.
Asked for a CP here

@mountiny
Copy link
Contributor

checking #27777 off, demoting from being a blocker

@thienlnam
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants