[HOLD for payment 2023-10-13] [$500] Web - Pronouns value not displayed on login #27675

kbecciv · 2023-09-18T13:50:34Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Open the app
Open settings->profile->pronouns
Copy the URL
Logout and paste the URL
Login and observe that currently selected pronouns value is not displayed

Expected Result:

App should display pronouns value if present on login

Actual Result:

App does not display pronouns value if present on login on login with pronouns page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

No.pronouns.value.on.login.mp4

Recording.4559.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694889012343609

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014246fda785f9f058
Upwork Job ID: 1703768490032054272
Last Price Increase: 2023-09-25
Automatic offers:

dukenv0307 | Contributor | 26916802

dukenv0307 · 2023-09-18T13:50:34Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pronouns value not displayed on login

What is the root cause of that problem?

We only set searchValue for the first render.

App/src/pages/settings/Profile/PronounsPage.js

Line 29 in 06e8d3a

const [searchValue, setSearchValue] = useState(() => {

When we open the page via deep link on login, currentUserPersonalDetails is empty until the openApp API is complete. So the searchValue is empty.

What changes do you think we should make in order to solve the problem?

We should subscribe isLoadingReportData to know when the openApp is complete.

Then we can create a useEffect to set searchValue state if the API is complete

useEffect(() => {
    if (isLoadingReportData && _.isEmpty(currentPronouns)) {
        return;
    }
    const currentPronounsText = _.chain(CONST.PRONOUNS_LIST)
        .find((_value) => _value === currentPronounsKey)
        .value();

    setSearchValue(currentPronounsText ? translate(`pronouns.${currentPronounsText}`) : '');
}, [currentPronouns, isLoadingReportData])

OPTIONAL: To make the best UI, we can display the loading page before the API is complete or hide the text input until the API is complete

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.18-09-2023.17.46.10.webm

melvin-bot · 2023-09-18T13:50:40Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-18T13:50:40Z

Job added to Upwork: https://www.upwork.com/jobs/~014246fda785f9f058

melvin-bot · 2023-09-18T13:50:42Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-18T13:50:45Z

Triggered auto assignment to @CortneyOfstad (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-09-18T13:50:51Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

c3024 · 2023-09-18T13:50:53Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pronouns list is not shown initially when accessed from deep link and then logging in

What is the root cause of that problem?

We are setting the initial searchValue here

App/src/pages/settings/Profile/PronounsPage.js

Lines 29 to 35 in c77814f

    
           const [searchValue, setSearchValue] = useState(() => { 
        
               const currentPronounsText = _.chain(CONST.PRONOUNS_LIST) 
        
                   .find((_value) => _value === currentPronounsKey) 
        
                   .value(); 
        
               return currentPronounsText ? translate(`pronouns.${currentPronounsText}`) : ''; 
        
           });

When we access this page from deep link, initially currentPronounsKey is empty because currentUserPersonalDetails has not been loaded yet.

What changes do you think we should make in order to solve the problem?

We should show a loading indicator when the page is loading and the pronouns field in currentUserPersonalDetails does not exist by adding this.

    if (!_.has(currentUserPersonalDetails, 'pronouns')) {
        return <FullScreenLoadingIndicator />;
    }

What alternative solutions did you explore? (Optional)

saranshbalyan-1234 · 2023-09-18T14:17:35Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pronouns list is not shown initially when accessed from deep link and then logging in

What is the root cause of that problem?

The initial state does not contains the pronouns.

App/src/pages/settings/Profile/PronounsPage.js

Lines 29 to 36 in ea5f461

    
           const [searchValue, setSearchValue] = useState(() => { 
        
               const currentPronounsText = _.chain(CONST.PRONOUNS_LIST) 
        
                   .find((_value) => _value === currentPronounsKey) 
        
                   .value(); 
        
               return currentPronounsText ? translate(`pronouns.${currentPronounsText}`) : ''; 
        
           });

When we access this page from deep link, initially currentPronounsKey is empty because currentUserPersonalDetails has not been loaded yet.

What changes do you think we should make in order to solve the problem?

What we can do is we can use the below code to get the latest values from the currentUserPersonalDetails object.

    useMemo(() => {
        setSearchValue(() => {
            const currentPronounsText = _.chain(CONST.PRONOUNS_LIST)
                .find((_value) => _value === currentPronounsKey)
                .value();

            return currentPronounsText ? translate(`pronouns.${currentPronounsText}`) : '';
        });
    }, [currentPronounsKey]);

Also the callback that is passed in the setSearchValue, should be a different fucntion to reduce code redundancy

What alternative solutions did you explore? (Optional)

N/A

CortneyOfstad · 2023-09-18T14:53:10Z

@joekaufmanexpensify there is a known issue with two assigners for BZ being applied (more info here), so going to remove my assignment as the second one for this issue 👍

joekaufmanexpensify · 2023-09-19T08:04:22Z

Sounds good!

joekaufmanexpensify · 2023-09-20T08:20:13Z

i can reproduce this. Checking internally about something before saying definitively we should change this.

joekaufmanexpensify · 2023-09-20T08:55:03Z

I chatted with @puneetlath to make sure we should fix this, since this form was designed with a lot intentionality, and confirmed that this is a bug. Next step is for @thesahindia to review proposals!

joekaufmanexpensify · 2023-09-21T08:15:21Z

Pending review of proposals

suneox · 2023-09-21T16:09:03Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Pronouns value not displayed on login

What is the root cause of that problem?

User info is loaded when the first time login via /api?command=OpenApp and the currentPronouns will get empty on the first time so the search value also empty

What changes do you think we should make in order to solve the problem?

At withCurrentUserPersonalDetails.js we should get loading status with key ONYXKEYS.IS_LOADING_APP

    return withOnyx({
+       isLoading: {
+           key: ONYXKEYS.IS_LOADING_APP,
+       },
        personalDetails: {
            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
        },
        session: {
            key: ONYXKEYS.SESSION,
        },
    })(withCurrentUserPersonalDetails);

also config propTypes and defaultProp for isLoading
Before render PronounsPage.js we will check isLoading status and return Loading component

    ...
+   if(props.isLoading) {
+       return <FullScreenLoadingIndicator />
+   }

    return (
      ...
    )

We should add a loading state to prevent users can editing before the data loaded while a slow network

update code from

App/src/pages/settings/Profile/PronounsPage.js

Lines 29 to 36 in bb32cc5

    
           const [searchValue, setSearchValue] = useState(() => { 
        
               const currentPronounsText = _.chain(CONST.PRONOUNS_LIST) 
        
                   .find((_value) => _value === currentPronounsKey) 
        
                   .value(); 
        
               return currentPronounsText ? translate(`pronouns.${currentPronounsText}`) : ''; 
        
           });

to

    const currentPronounsText = useMemo(() => {
        const currentPronounsText = _.chain(CONST.PRONOUNS_LIST)
            .find((_value) => _value === currentPronounsKey)
            .value();

        return currentPronounsText ? translate(`pronouns.${currentPronounsText}`) : '';
    }, [currentPronounsKey]);

    const [searchValue, setSearchValue] = useState(currentPronounsText);

    useEffect(() => {
        if (!isLoading && currentPronounsText) {
            setSearchValue(currentPronounsText);
        }
    }, [isLoading, currentPronounsText]);

A lot of pages use withCurrentUserPersonalDetails so we should add isLoading status into withCurrentUserPersonalDetails.js to be aware of using it for the next feature or fix issues the same with this

What alternative solutions did you explore? (Optional)

Create withCurrentUserPersonalDetailsAndLoadingState.js the same withCurrentUserPersonalDetails and same isLoading config from the primary solution
before render withCurrentUserPersonalDetailsAndLoadingState.js return Loading component

    function WithCurrentUserPersonalDetails(props) {
        const accountID = props.session.accountID;
        const accountPersonalDetails = props.personalDetails[accountID];
        const currentUserPersonalDetails = useMemo(() => ({...accountPersonalDetails, accountID}), [accountPersonalDetails, accountID]);
+       if (props.isLoading) {
+           return <FullScreenLoadingIndicator />;
+       }
        return (
            <WrappedComponent
                ...
            />
        );
    }

joekaufmanexpensify · 2023-09-22T07:17:58Z

@thesahindia could you take a look at these proposals when you have a sec? TY!

suneox · 2023-09-22T17:10:37Z

I have updated my proposal and explain for each change

joekaufmanexpensify · 2023-09-25T04:17:39Z

Pending review of proposals

melvin-bot · 2023-09-25T16:00:25Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

thesahindia · 2023-09-25T21:01:08Z

@dukenv0307's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

joekaufmanexpensify · 2023-10-16T14:30:44Z

Got it. I will review the timing before we issue payment. We still need @allroundexperts to complete the BZ checklist here before we can issue payment.

joekaufmanexpensify · 2023-10-17T19:49:57Z

Bumped in Slack

allroundexperts · 2023-10-17T20:26:15Z

Checklist

There isn't any particular PR to blame here. I think we just forgot to implement this edge case.
N/A
https://expensify.slack.com/archives/C049HHMV9SM/p1697574239538219
A regression test would be good.

Regression test

Login and make sure that the user has set up pronouns in the profile page.
Copy the pronouns page url and logout.
In a new tab, open the copied url and login.
Verify that the pronouns that were set up in step 1 show up successfully.

Do we 👍 or 👎 ?

joekaufmanexpensify · 2023-10-18T15:23:07Z

TY! IMO, we can punt the regression test here, as it doesn't seem realistic to me that many/any users will be frequently trying to deeplink login specifically to the pronouns page. This feels like a significant edge case to me, so no need to include it in every regression run.

joekaufmanexpensify · 2023-10-18T21:52:07Z

Going to sort through the questions about contributor bounty, and whether the speed bonus applies here tomorrow. Once those are resolved, we'll be all set to issue payment!

joekaufmanexpensify · 2023-10-19T15:59:37Z

Okay, chatted about the speed bonus internally, and we will offer that here, since both @allroundexperts and @dukenv0307 prioritized this one with urgency.

joekaufmanexpensify · 2023-10-19T16:00:20Z

We are still discussing this a bit, and will issue payment as soon as that is resolved!

joekaufmanexpensify · 2023-10-19T20:18:12Z

@dukenv0307 checking in on this. After further discussions, it sounds like the PR you ultimately implemented used some aspects of the other contributor's proposal.

No worries about this! But we're discussing splitting the $500 bounty with them, and want to make sure you don't have any significant concerns with that? TY!

melvin-bot · 2023-10-23T12:26:59Z

@amyevans, @allroundexperts, @joekaufmanexpensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

joekaufmanexpensify · 2023-10-23T13:31:38Z

@dukenv0307 could you please review this and let us know your thoughts? TY!

joekaufmanexpensify · 2023-10-23T16:46:20Z

Okay, while we wait for the contributor payments to be sorted out (via Upwork), we can handle @allroundexperts payment now. They will get $750 ($500 for C+ review + $250 speed bonus), paid via NewDot

dukenv0307 · 2023-10-24T02:42:42Z

@joekaufmanexpensify I agree with this .

JmillsExpensify · 2023-10-24T16:19:34Z

$750 payment approved for @allroundexperts based on summary above.

joekaufmanexpensify · 2023-10-24T20:31:22Z

Great, thanks for confirming. That means we still need to issue the following payments:

@dukenv0307 - $375 ($250 for half of PR bounty, and $125 for 50% speed bonus for bounty paid). Paid vua Upwork.
@suneox - $250 for providing elements used in the solution. No speed bonus here since they did not contribute to the timed work to get this merged. Paid via upwork.
@dhanashree-sawant - $50 for reporting the bug. Paid via Upwork.

joekaufmanexpensify · 2023-10-24T20:31:31Z

@suneox offer sent for $250!

joekaufmanexpensify · 2023-10-24T20:31:46Z

@dhanashree-sawant offer sent for $50!

dukenv0307 · 2023-10-25T03:25:00Z

@joekaufmanexpensify I think the bonus should be $250 and we only split $500 between me and @suneox. Correct me if I missed something.

joekaufmanexpensify · 2023-10-25T14:20:58Z

@dukenv0307 the urgency bonus is 50% of the bounty earned by the contributor who raised the PR, rather than a static bonus. Since you raised the PR, and are earning a $250 bounty for this issue, your 50% bonus for the PR is $125. A $250 bonus on your $250 bounty would be a 100% bonus.

@suneox isn't earning a bonus since they were not involved in the collaborative process of raising the PR quickly.

LMK if you have any other questions!

joekaufmanexpensify · 2023-10-25T14:22:31Z

@dukenv0307 $375 sent and contract ended!

joekaufmanexpensify · 2023-10-25T14:23:20Z

@suneox $250 sent and contract ended!

joekaufmanexpensify · 2023-10-25T14:24:31Z

@dhanashree-sawant $50 sent and contract ended!

joekaufmanexpensify · 2023-10-25T14:24:36Z

Upwork job closed

joekaufmanexpensify · 2023-10-25T14:25:02Z

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!

dukenv0307 · 2023-11-15T08:23:48Z

@dukenv0307 the urgency bonus is 50% of the bounty earned by the contributor who raised the PR, rather than a static bonus. Since you raised the PR, and are earning a $250 bounty for this issue, your 50% bonus for the PR is $125. A $250 bonus on your $250 bounty would be a 100% bonus.

@joekaufmanexpensify my take is that as we're splitting original bounty, we also share responsibility of getting a PR up and merged and will jointly be eligible for the $250 bonus if within 3 days. But 1 of us does not participate in the PR, only I handle the PR from start to end and strive to get it merged asap, I bear the whole responsibility (which by right should be split similar to the reward).

So it makes sense that I'll be eligible for the full bonus of the "PR responsibility" which is $250. I have seen that in other issues like this one. Could you kindly give this a second look, thanks!

joekaufmanexpensify · 2023-11-15T15:50:40Z

@dukenv0307 I definitely understand where you're coming from. However, the previous guidance on the urgency bonus is fairly clear. It is a 50% bonus applied to the bounty earned to incentivize the individual writing the PR to get it done quickly. It scaled down with the various compensation changes we've made to the contributor program as well.

I think we handled the urgency bonus in that other issue incorrectly, so I don't think we'd issue a 100% urgency bonus here based on that.

We appreciate your understanding. Let me know if you have any other questions!

kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 18, 2023

melvin-bot bot changed the title ~~Web - Pronouns value not displayed on login~~ [$500] Web - Pronouns value not displayed on login Sep 18, 2023

melvin-bot bot assigned joekaufmanexpensify Sep 18, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 18, 2023

melvin-bot bot assigned CortneyOfstad Sep 18, 2023

melvin-bot bot assigned thesahindia Sep 18, 2023

CortneyOfstad removed their assignment Sep 18, 2023

melvin-bot bot added the Overdue label Sep 25, 2023

melvin-bot bot removed the Overdue label Sep 25, 2023

melvin-bot bot added the Overdue label Oct 16, 2023

melvin-bot bot removed the Overdue label Oct 16, 2023

melvin-bot bot added the Overdue label Oct 23, 2023

melvin-bot bot removed the Overdue label Oct 23, 2023

joekaufmanexpensify closed this as completed Oct 25, 2023

[HOLD for payment 2023-10-13] [$500] Web - Pronouns value not displayed on login #27675

[HOLD for payment 2023-10-13] [$500] Web - Pronouns value not displayed on login #27675

Comments

kbecciv commented Sep 18, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

dukenv0307 commented Sep 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

melvin-bot bot commented Sep 18, 2023

melvin-bot bot commented Sep 18, 2023

melvin-bot bot commented Sep 18, 2023 • edited by joekaufmanexpensify Loading

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 18, 2023

melvin-bot bot commented Sep 18, 2023

c3024 commented Sep 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

saranshbalyan-1234 commented Sep 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

CortneyOfstad commented Sep 18, 2023

joekaufmanexpensify commented Sep 19, 2023

joekaufmanexpensify commented Sep 20, 2023

joekaufmanexpensify commented Sep 20, 2023

joekaufmanexpensify commented Sep 21, 2023

suneox commented Sep 21, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

joekaufmanexpensify commented Sep 22, 2023

suneox commented Sep 22, 2023

joekaufmanexpensify commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

thesahindia commented Sep 25, 2023

joekaufmanexpensify commented Oct 16, 2023

joekaufmanexpensify commented Oct 17, 2023

allroundexperts commented Oct 17, 2023

Checklist

Regression test

joekaufmanexpensify commented Oct 18, 2023

joekaufmanexpensify commented Oct 18, 2023

joekaufmanexpensify commented Oct 19, 2023

joekaufmanexpensify commented Oct 19, 2023

joekaufmanexpensify commented Oct 19, 2023

melvin-bot bot commented Oct 23, 2023

joekaufmanexpensify commented Oct 23, 2023

joekaufmanexpensify commented Oct 23, 2023

dukenv0307 commented Oct 24, 2023 • edited Loading

JmillsExpensify commented Oct 24, 2023

joekaufmanexpensify commented Oct 24, 2023

joekaufmanexpensify commented Oct 24, 2023

joekaufmanexpensify commented Oct 24, 2023

dukenv0307 commented Oct 25, 2023 • edited Loading

joekaufmanexpensify commented Oct 25, 2023

joekaufmanexpensify commented Oct 25, 2023

joekaufmanexpensify commented Oct 25, 2023

joekaufmanexpensify commented Oct 25, 2023

joekaufmanexpensify commented Oct 25, 2023

joekaufmanexpensify commented Oct 25, 2023

dukenv0307 commented Nov 15, 2023

joekaufmanexpensify commented Nov 15, 2023

kbecciv commented Sep 18, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 18, 2023 •

edited by joekaufmanexpensify

Loading

suneox commented Sep 21, 2023 •

edited

Loading

dukenv0307 commented Oct 24, 2023 •

edited

Loading

dukenv0307 commented Oct 25, 2023 •

edited

Loading