[HOLD for payment 2023-10-05] [$500] Web - There's no max length for editing private notes input

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any report => report details => Private Notes.
2. Choose My Notes => Try to paste over 15,000 characters and click Save.
3. Verify that there's no limit character for editing private note Input.

Expected Result:

Private note input should be limit character like other input.

Actual Result:

There's no max length for editing private notes input.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-17.at.11.02.27.mov

Recording.4574.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694923317416409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017d2086d12246e4a8
• Upwork Job ID: 1703805477394239488
• Last Price Increase: 2023-09-18
• Automatic offers:
• hungvu193 | Contributor | 26808029
• hungvu193 | Reporter | 26808030

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017d2086d12246e4a8

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[kbecciv]

Proposal by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694923317416409

Proposal

Please re-state the problem that we are trying to solve in this issue.

There’s no max length limit for editing private notes TextInput and as I can see the browser is not responding after that.

What is the root cause of that problem?

We didn’t have maxLength for our TextInput in here, so when user pasted large amount of characters ( > 30,000), it will make the App frozen.

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Lines 118 to 132 in c77814f

	<TextInput
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.TEXT}
	inputID="privateNotes"
	label={translate('privateNotes.composerLabel')}
	accessibilityLabel={translate('privateNotes.title')}
	autoCompleteType="off"
	autoCorrect={false}
	autoGrowHeight
	textAlignVertical="top"
	containerStyles={[styles.autoGrowHeightMultilineInput]}
	defaultValue={privateNote}
	value={privateNote}
	onChangeText={(text) => setPrivateNote(text)}
	ref={(el) => (privateNotesInput.current = el)}
	/>

What changes do you think we should make in order to solve the problem?

We should add maxLength={CONST.MAX_COMMENT_LENGTH} to our TextInput, similar with ReportWelcomeMessage.

What alternative solutions did you explore? (Optional)

N/A

[hjchoudry]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There's no max length for editing private notes input

What is the root cause of that problem?

We didn’t have maxLength for our TextInput, so when the user pasted many characters until the app stopped responding.

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Lines 118 to 132 in c77814f

	<TextInput
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.TEXT}
	inputID="privateNotes"
	label={translate('privateNotes.composerLabel')}
	accessibilityLabel={translate('privateNotes.title')}
	autoCompleteType="off"
	autoCorrect={false}
	autoGrowHeight
	textAlignVertical="top"
	containerStyles={[styles.autoGrowHeightMultilineInput]}
	defaultValue={privateNote}
	value={privateNote}
	onChangeText={(text) => setPrivateNote(text)}
	ref={(el) => (privateNotesInput.current = el)}
	/>

What changes do you think we should make in order to solve the problem?

We should add maxLength={CONST.MAX_COMMENT_LENGTH} to our TextInput, similar to other TextInput.

What alternative solutions did you explore? (Optional)
N/A

[bfitzexpensify]

A couple of proposals ready for review when you get a chance @burczu - thanks!

[burczu]

@bfitzexpensify I'll be reviewing them soon.

[burczu]

Reviewed both proposals (they are the same, and correct imo) and the one from @hungvu193 was the first and we should proceed with it.

The question might be if want to use the same max length value as for comments (MAX_COMMENT_LENGTH = 15000)?

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

Reviewed both proposals (they are the same, and correct imo) and the one from @hungvu193 was the first and we should proceed with it.

The question might be if want to use the same max length value as for comments (MAX_COMMENT_LENGTH = 15000)?

🎀 👀 🎀 C+ reviewed

I think Yes because we're also using it for welcome message

[francoisl]

Yep sounds good, pretty straightforward change.

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

🎯 ⚡️ Woah @burczu / @hungvu193, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @hungvu193 got assigned: 2023-09-22 00:42:47 Z
• when the PR got merged: 2023-09-25 01:42:41 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: add max length for private notes #27975

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @hungvu193 requires payment offer (Contributor)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Switching this to daily so I'm aware of it and action it on 10/5

[bfitzexpensify]

Payments complete, please review the BZ checklist when you get a chance @burczu - thanks!

[bfitzexpensify]

Friendly bump on the BZ checklist @burczu - thank you!

[burczu]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR: It was working this way since the very beginning
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

OK, let's close this out - thanks everyone