Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - Chat created offline with incorrect phone number disappears without any notice or error #27725

Closed
1 of 6 tasks
lanitochka17 opened this issue Sep 18, 2023 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Login to NewDot
  2. Go offline
  3. Create a new chat with an invalid phone number (5555555555555)
  4. Send some messages
  5. Go online

Expected Result:

We should show error message that the phone number is invalid (e.g. if using 5555555555555) as we do on ther platforms.

Actual Result:

The chat created while in offline mode with the incorrect phone number is created at first, and then randomly disappears without any notice or error message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.70-8

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6205461_video_34.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d0dc9ce11fcd2d6a
  • Upwork Job ID: 1707061707929169920
  • Last Price Increase: 2023-10-04
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2023

@michaelhaxhiu 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@michaelhaxhiu michaelhaxhiu added the External Added to denote the issue can be worked on by a contributor label Sep 27, 2023
@melvin-bot melvin-bot bot changed the title Web - Chat created offline with incorrect phone number disappears without any notice or error [$500] Web - Chat created offline with incorrect phone number disappears without any notice or error Sep 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01d0dc9ce11fcd2d6a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@michaelhaxhiu
Copy link
Contributor

This is indeed inconsistent with other platforms like chrome, safari, and mobile! I cleaned up the Expected Result.

I think we should be showing this error as the number format is clearly invalid whether you are offline or online:

image

Would love C+ input though!

@melvin-bot melvin-bot bot removed the Overdue label Sep 27, 2023
@michaelhaxhiu michaelhaxhiu removed their assignment Sep 27, 2023
@michaelhaxhiu michaelhaxhiu added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Expensify Expensify deleted a comment from melvin-bot bot Sep 27, 2023
@michaelhaxhiu
Copy link
Contributor

I'm also re-assigning to another BZ as I'm preparing for sabbatical this Friday. In terms of next steps:

  • Let's have the C+ help ensure two things (1) The Expected Result makes sense for a user in offline mode and (2) This can be worked on external because sometimes, offline mode issues lean toward internal

Thanks in advance @mallenexpensify !

@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@cubuspl42 @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@cubuspl42
Copy link
Contributor

@lanitochka17 @mallenexpensify

So after inputing an incorrect phone number, this "Please enter a valid number...." error is presented, as expected, on non-Web platforms (iOS, Android) when offline?

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@mallenexpensify
Copy link
Contributor

I was NOT able to reproduce on iOS > Chrome

@lanitochka17 , can you please test again on Windows > Chrome and, after you reconnect to wifi, can you leave it on the chat screen for a little wihle? ~15 seconds? It took a moment for my chat to update once I connected to wifi.
Thx

image

@lanitochka17
Copy link
Author

@mallenexpensify Hello, Issue is not reproducible on Build 1.3.77-3.
Chat with phone number does not disappear.

Recording.138.mp4

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mallenexpensify
Copy link
Contributor

Thanks @lanitochka17 , closing as two of us weren't able to reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants