Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - Request money - Console error after refreshing page and requesting money #27726

Closed
1 of 6 tasks
lanitochka17 opened this issue Sep 18, 2023 · 27 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #27395

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Refresh the page
  4. Click on FAB > Request money

Expected Result:

There is no console error

Actual Result:

There is a console error after refreshing a page and selecting "Request money". Console error does not show up if user navigates to different areas of the app before requesting money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.71-5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6205468_Recording__234.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010ab36420ceccc863
  • Upwork Job ID: 1704804349777985536
  • Last Price Increase: 2023-09-21
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Sep 19, 2023

@lanitochka17 I see the below on Chrome. Can you screenshot a pic of the error you're seeing so I can confirm they're the same? ( it's a lil hard for me t make out in the vid)

image

@lanitochka17
Copy link
Author

I see the same console error in Windows/Chrome

123

@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Sep 21, 2023
@melvin-bot melvin-bot bot changed the title Web - Request money - Console error after refreshing page and requesting money [$500] Web - Request money - Console error after refreshing page and requesting money Sep 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~010ab36420ceccc863

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@mallenexpensify
Copy link
Contributor

Guessing/hoping this can be external, I'm unsure though. @fedirjh , what do you think?

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2023
@Talha345
Copy link
Contributor

This is a CSP error and needs to be fixed on the server side.

@fedirjh
Copy link
Contributor

fedirjh commented Sep 23, 2023

cc @mallenexpensify This should be internal, should be fixed on server.

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2023
@mallenexpensify mallenexpensify added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2023

Current assignee @fedirjh is eligible for the Internal assigner, not assigning anyone new.

@mallenexpensify
Copy link
Contributor

Thanks @fedirjh and @Talha345, made it Internal.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 27, 2023
@fedirjh
Copy link
Contributor

fedirjh commented Sep 29, 2023

Awaiting internal assignment.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 29, 2023
@mallenexpensify
Copy link
Contributor

hmm... are we treating console errors with the same level of priority as other bugs?

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@fedirjh
Copy link
Contributor

fedirjh commented Oct 9, 2023

are we treating console errors with the same level of priority as other bugs?

It depends on the specific console error. Some errors indicate broken functionality and require higher priority, while in this case, it's a CSP (Content Security Policy) error that doesn't seem to affect functionality. IMO, it's not as high a priority as other bugs.

@melvin-bot melvin-bot bot added the Overdue label Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

@mallenexpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify
Copy link
Contributor

Still waiting internal pickup, since it's not high priority, I'll wait a lil bit longer then drop in #engineering-chat to get more 👀 and feedback about next steps

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

@mallenexpensify @fedirjh this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

@mallenexpensify, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Oct 17, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
@mallenexpensify
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 9, 2023
@mallenexpensify
Copy link
Contributor

No takers in the post above, will post again next week if no one picks this up

@melvin-bot melvin-bot bot removed the Overdue label Nov 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@mallenexpensify
Copy link
Contributor

Maybe post about next week, it's not a priority and it the holidays here...

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 1, 2023
@mallenexpensify
Copy link
Contributor

Likely closing this soon since it's a console error and we're prioritizing working on roadmap issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants