Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Dev: IOS - Horizontal line appearing above deleted task message #27806

Closed
1 of 6 tasks
kbecciv opened this issue Sep 19, 2023 · 20 comments
Closed
1 of 6 tasks

[$500] Dev: IOS - Horizontal line appearing above deleted task message #27806

kbecciv opened this issue Sep 19, 2023 · 20 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Sep 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

Action Performed:

  1. Open a chat.
  2. Navigate to the "Assign task" section.
  3. Enter a title and create a task.
  4. Cancel the task

Expected Result:

A horizontal line should appear below the deleted thread message

Actual Result:

The horizontal line is displayed above the deleted task message, not below it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev 1.3.71-6
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-19.at.12.31.22.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695109294508539

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015398ec0361ebae96
  • Upwork Job ID: 1704198774990962688
  • Last Price Increase: 2023-10-02
@kbecciv kbecciv added the External Added to denote the issue can be worked on by a contributor label Sep 19, 2023
@melvin-bot melvin-bot bot changed the title Dev: IOS - IOS - Horizontal line appearing above deleted task message [$500] Dev: IOS - IOS - Horizontal line appearing above deleted task message Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~015398ec0361ebae96

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 19, 2023
@kbecciv kbecciv changed the title [$500] Dev: IOS - IOS - Horizontal line appearing above deleted task message Dev: IOS - Horizontal line appearing above deleted task message Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

@cubuspl42
Copy link
Contributor

@kbecciv What's the status of this issue? Why is it External/Help Wanted but the pricetag was removed?

@kbecciv
Copy link
Author

kbecciv commented Sep 20, 2023

@cubuspl42 Not sure why the price is removed, I used "External" label only, because QA team cannot verify the bug in Dev.

@cubuspl42
Copy link
Contributor

Can it be added back manually? I think that people might intuitively think that this is a mislabeled internal issue when they see no pricetag.

@kbecciv kbecciv changed the title Dev: IOS - Horizontal line appearing above deleted task message [500] Dev: IOS - Horizontal line appearing above deleted task message Sep 20, 2023
@kbecciv
Copy link
Author

kbecciv commented Sep 20, 2023

I added manually

@mallenexpensify mallenexpensify changed the title [500] Dev: IOS - Horizontal line appearing above deleted task message [$500] Dev: IOS - Horizontal line appearing above deleted task message Sep 25, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

Upwork job price has been updated to $500

@mallenexpensify
Copy link
Contributor

@ayazhussain79 I see you deleted a comment in the vid but I don't see 'delete comment' in the reproduce steps. Can you please update them and/or provide more details? thx

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@ayazhussain79
Copy link
Contributor

@mallenexpensify i deleted comment to show you when i deleted message thread line is below deleted message but when i canceled task line is above the deleted thread

@ayazhussain79
Copy link
Contributor

Line is not appearing now

Screenshot 2023-09-26 at 1 18 02 AM

@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 28, 2023

@cubuspl42, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@cubuspl42, @mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

@cubuspl42, @mallenexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@cubuspl42
Copy link
Contributor

@kbecciv @mallenexpensify Would you retest this?

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@mallenexpensify
Copy link
Contributor

I see this after deleting a task, the keyboard is still showing which is different than the screenshot-vid in the OP. So, I'm not able to reprodue, are you @cubuspl42 ?
IMG_0244

@cubuspl42
Copy link
Contributor

Also no. Let's close this one.

@mallenexpensify
Copy link
Contributor

Thanks for checking @cubuspl42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants