-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Task does not appear in LHN after self-assigning as a group member #27852
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On A, go to a group chat with B as a member
this was already working correctly, the bug is present only if you create a task from a room
Could you change the test steps to indicate that please?
I quite not understand your mean. From the linked thread, the bug specifically happen in group chat, not a DM and that's what I mean by saying "go to a group chat with B as a member". |
For me it isn't reproducible in group chat either (the video below is latest Screen.Recording.2023-11-08.at.17.26.45.mov |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-11-21.at.16.35.51.movAndroid: mWeb ChromeScreen.Recording.2023-11-21.at.16.33.17.moviOS: NativeScreen.Recording.2023-11-21.at.16.32.05.moviOS: mWeb SafariScreen.Recording.2023-11-21.at.16.30.19.movMacOS: Chrome / SafariScreen.Recording.2023-11-21.at.16.27.44.movMacOS: DesktopScreen.Recording.2023-11-21.at.16.44.46.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.2-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀
|
Details
Task does not appear in LHN after self-assigning as a group member. This PR fixes that.
Fixed Issues
$ #26762
PROPOSAL: #26762 (comment)
Tests
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2023-11-06.at.22.37.33-compressed.mov
Android: mWeb Chrome
Screen.Recording.2023-11-06.at.22.39.52-compressed.mov
iOS: Native
Screen.Recording.2023-11-06.at.22.43.51-compressed.mov
iOS: mWeb Safari
Screen.Recording.2023-11-06.at.22.45.21-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-06.at.22.32.24-compressed.mov
MacOS: Desktop
Screen.Recording.2023-11-06.at.22.48.45-compressed.mov