[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Dev: Web - focus lose on click ctrl+shift+k again

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Press ctrl+shift+k to open Send message
2. Again click press ctrl+shift+k

Expected Result:

Input field should be focused

Actual Result:

Input field not focused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.72.4
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-20.at.6.11.41.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694785511995319

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ec26b7124d8b07f
• Upwork Job ID: 1704481362907553792
• Last Price Increase: 2023-10-04
• Automatic offers:
• bernhardoj | Contributor | 27118476

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019ec26b7124d8b07f

[melvin-bot]

Triggered auto assignment to @garrettmknight (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[kbecciv]

Linking a recent issue #17482

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking ctr+shift+k shortcut twice will blur the Send message page search input.

What is the root cause of that problem?

Pressing the shortcut will navigate to the Send message page. Every time we are doing navigation, we are blurring anything.

App/src/libs/Navigation/Navigation.js

Line 90 in 2a5ea63

DomUtils.blurActiveElement();

This issue was previously fixed here by preventing navigating to the same page by comparing the current route and the route we want to navigate to.

App/src/libs/Navigation/AppNavigator/AuthScreens.js

Lines 200 to 203 in 2a5ea63

	if (Navigation.isActiveRoute(ROUTES.NEW)) {
	return;
	}
	Navigation.navigate(ROUTES.NEW);

However, if we open Send message (with policy room permission), the route is either /new/chat or /new/room but we are comparing it to /new (this is to fix #27710).

What changes do you think we should make in order to solve the problem?

Remove the blurring of everything every time we call navigate, then we can also remove the if code to prevent calling navigate to the same page.

App/src/libs/Navigation/Navigation.js

Lines 87 to 90 in 2a5ea63

	// A pressed navigation button will remain focused, keeping its tooltip visible, even if it's supposed to be out of view.
	// To prevent that we blur the button manually (especially for Safari, where the mouse leave event is missing).
	// More info: https://github.com/Expensify/App/issues/13146
	DomUtils.blurActiveElement();

This code was previously removed in this PR but looks like there is some bad merge that reintroduced it (most likely from this PR).

[garrettmknight]

@sobitneupane either of these proposals look good?

[sobitneupane]

@gadhiyamanan @garrettmknight I was unable to replicate the issue. Is it still reproducible?

[Pluto0104]

@sobitneupane this issue is still reproducible under the beta feature. if you don't enable the beta feature, it may be not reproducible.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@garrettmknight, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

[sobitneupane]

this issue is still reproducible under the beta feature. if you don't enable the beta feature, it may be not reproducible.

Which beta feature are we talking about?

[Pluto0104]

If you enabled beta feature, RHP might look like this:

[sobitneupane]

This code was previously removed in this PR but looks like there is some bad merge that reintroduced it (most likely from this #16581).

@bernhardoj Why was the code removed in the linked PR?

The code was introduced to tackle #13146 issue. Won't removing the code cause the regression?

[bernhardoj]

@sobitneupane #13146 issue handles a couple of issues and DomUtils.blurActiveElement (and also setting all tooltip as focusable) is specifically made to handle the issue where the tooltip is stuck when we navigate to another page, only on Safari.

(on main)

Screen.Recording.2023-10-04.at.15.25.28.mov

We considered it a hack, so we decided to remove it. It brings more issues than the fix. One of them is this. I told them that it's safe to remove it here, but looks like they miss it, so I propose it here again.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[garrettmknight]

@sobitneupane what do you think?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix pressing new chat shortcut twice remove the focus from search input #29202

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sobitneupane does not require payment (Eligible for Manual Requests)
• @bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix pressing new chat shortcut twice remove the focus from search input #29202

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sobitneupane does not require payment (Eligible for Manual Requests)
• @bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix pressing new chat shortcut twice remove the focus from search input #29202

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sobitneupane does not require payment (Eligible for Manual Requests)
• @bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@garrettmknight, @nkuoch, @sobitneupane, @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick!

[garrettmknight]

Summary of payments for this issue:

• Urgency bonus: Yes
• Reporter: @gadhiyamanan - $50 paid via Upwork
• Contributor: @bernhardoj - $750 paid via Upwork
• Reviewer: @sobitneupane - $750

Upwork job: https://www.upwork.com/jobs/~019ec26b7124d8b07f

[garrettmknight]

@gadhiyamanan offer out to you - accept and I'll pay.

[gadhiyamanan]

@garrettmknight offer accepted, thanks!

[garrettmknight]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane ] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane ] Determine if we should create a regression test for this bug.
• [@sobitneupane ] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

@sobitneupane please complete the checklist and request payment.

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane ] The PR that introduced the bug has been identified. Link to the PR:

The change resulting this issue was introduced by #14048 PR which was later removed by #16052 PR. But was later reintroduced probably due to some merge conflicts.

• [@sobitneupane ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

• [@sobitneupane ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

There are multiple PRs involved. As this feature was newly introduced, probably shortcuts were not tested.

• [@sobitneupane ] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane ] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#27860 (comment)

[sobitneupane]

Regression Test Proposal

• Press CTRL+K
• Verify a new chat opens with the search input focused
• Press CTRL+K once again
• Verify the search input is still focused

Do we agree 👍 or 👎

[sobitneupane]

#27860 (comment)

Requested payment on newDot.

[JmillsExpensify]

$750 payment approved for @sobitneupane based on this comment.

[garrettmknight]

All set, closing.