[$500] Chat - The user is able to scroll through the suggestion list

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login to any account.
2. Open any chat that has a long chat history.
3. Type "@" followed by the search keyword in the compose field.
4. Ensure that the suggestion list ONLY returns a FEW results so that the scroll bar doesn't appear.
5. Long-press on any item in the suggestion list and scroll up/down.
6. Observation: The content behind the suggestion list scrolls.

Expected Result:

The content behind the suggestion list should not scroll.

Actual Result:

The user is able to scroll through the suggestion list, causing the chat behind it to scroll.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

scroll-through.mp4

Recording.4627.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695140320778399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c3091e29ea2936a7
• Upwork Job ID: 1704497441979785216
• Last Price Increase: 2023-10-11

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c3091e29ea2936a7

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji or mention suggestions list is scrollable

What is the root cause of that problem?

We don't have any modal-like style or element to prevent interaction when suggestion list shows

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to add modal-like parent to suggestion list.
This PR is in progress and uses portal.
I think we need to hold this issue until the above PR is merged

Result

What alternative solutions did you explore? (Optional)

[trjExpensify]

Assigned second, dropping off.

[lschurr]

@0xmiroslav could you review the proposal on this one?

[0xmiros]

@s-alves10 thanks for the proposal but it's intentional to set MAX_AMOUNT_OF_SUGGESTIONS to 20.

[s-alves10]

@0xmiroslav

I misunderstood the issue. I think we need to hold this issue until this PR is merged

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[0xmiros]

@0xmiroslav

I misunderstood the issue. I think we need to hold this issue until this PR is merged

It's merged

[lschurr]

Are we still waiting on new proposals @0xmiroslav? Or has this one been fixed with that PR?

[0xmiros]

I think we're waiting updated proposals.

[melvin-bot]

@lschurr, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[lschurr]

Still waiting on proposals.

[MrRefactor]

Hi! PR is ready to be reviewed

[Santhosh-Sellavel]

@mallenexpensify I am planning on OOO please assign a new C+ here to continue the review.

[situchan]

I'd like to continue reviewing PR

[francoisl]

Assigned you @situchan

[MrRefactor]

PR merged 5 days ago!

CC: @lschurr

[lschurr]

Thanks @MrRefactor - Typically the payment date is set for 7 days after the change is deployed to production. Is this one that doesn't need to be deployed @francoisl?

[francoisl]

No, it still needs to be deployed to production. It was just deployed to staging 1 hour ago. We had a merge/deploy freeze last week, hence the delayed deploy.

[lschurr]

Great, thanks for checking!

[MrRefactor]

Hey Hey @francoisl @lschurr, deployed to production 2 weeks ago, schould we somehow trigger melvin-bot to go forward and close it?

[francoisl]

Yes we can issue payments now @lschurr and then close this.

[lschurr]

Ah sorry I missed this. I'll take care of payments today.

[lschurr]

Payment summary:

• Contributor: @MrRefactor (agency - no payment needed)
• Contributor+: @situchan $500 (to be paid in Upwork)

[lschurr]

@situchan - sent offer: https://www.upwork.com/nx/wm/offer/101468767

[lschurr]

This is complete.

[tranvantoan-qn]

@lschurr I'm eligible for a reporting bonus as well 😄

[lschurr]

Oh wow, you're right! This is an old one. I sent an offer via Upwork @tranvantoan-qn: https://www.upwork.com/nx/wm/offer/101471120

[tranvantoan-qn]

Thank you!
I have accepted the offer

[lschurr]

All set.