[$500] Android - Scan - Camera preview in Scan becomes blank after returning from Distance

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch New Expensify app.
2. Go to + > Request money.
3. Go to Scan and enable camera access if not allowed yet.
4. Go to Distance.
5. Go back to Scan.

Expected Result:

Camera preview works without issue

Actual Result:

Camera preview is now blank

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.72-6

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6207769_Screen_Recording_20230920_235909_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018be32f891c61fb2c
• Upwork Job ID: 1707637360214872064
• Last Price Increase: 2023-09-29
• Automatic offers:
• dukenv0307 | Contributor | 27009429

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@stephanieelliott 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[stephanieelliott]

Agree this should probably be fixed, adding relevant labels.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018be32f891c61fb2c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Camera preview is now blank

What is the root cause of that problem?

We're switching the isCameraActive state a lot here
That condition is not ideal since even though you don't really go to the Scan tab, but only from Manual to Distance or vice versa, it will still turn on and off the isCameraActive a few times.

This excessive switching of isCameraActive causes the blank issue since we're changing the camera status a lot (which is a sensitive feature in native).

What changes do you think we should make in order to solve the problem?

That condition is not ideal since even though you don't really go to the Scan tab, but only from Manual to Distance or vice versa, it will still turn on and off the isCameraActive a few times.

We need to make sure we don't toggle on and off the isCameraActive in the above scenario.

• Connect to selectedTab in ReceiptSelector and pass it to the CameraComponent
• Check if the selectedTab is of the tab further away from the Scan tab in the position change direction, if yes then don't call setIsCameraActive here

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@mananjadhav, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

I think @dukenv0307's proposal will work here.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[stephanieelliott]

Thanks @thesahindia! Assigned @dukenv0307

[melvin-bot]

@mananjadhav, @bondydaa, @stephanieelliott, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[mananjadhav]

@dukenv0307 can you ask on the slack? Even I don't know if external contributors can build on iOS.

[dukenv0307]

Started a conversation in slack cc @mananjadhav @bondydaa

[melvin-bot]

@mananjadhav, @bondydaa, @stephanieelliott, @dukenv0307 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[bondydaa]

discussing in that slack thread (https://expensify.slack.com/archives/C01GTK53T8Q/p1699410931837159) what next steps are, i'm so confused here.

[bondydaa]

okay threw these idea out in the thread:

1. If @dukenv0307 has an idea of how to fix create a PR and we'll create an ad-hoc build to test (we can get other internal engineers, contributors, or QA with physical devices)
2. Or @mananjadhav could take over writing the PR since you have a physical ios device it seems to test while you go? Then @dukenv0307 can help review the PR (sort of swapping roles).

Either of those seem like a good path forward to unblock this?

[mananjadhav]

@bondydaa I think the iOS development will blocked for me too. I'll check this over the weekend.

[stephanieelliott]

Hey @mananjadhav did you have a chance to check this?

[mananjadhav]

Nope I am unable to debug this on physical iOS device.

[situchan]

This is not reproducible anymore

[stephanieelliott]

Hey @lanitochka17 can you confirm whether this is still reproducible?

[lanitochka17]

@stephanieelliott Issue is not reproducible v1.4.4-1

Screen_Recording_20231129_012046_New.Expensify.mp4

[stephanieelliott]

Ok, gonna consider the regression fixed so let's pay out on the original issue. Summarizing payment:

• Issue reporter: N/A
• Contributor: @dukenv0307 $500, pay via Upwork
• Contributor+: @mananjadhav $500

Upwork job is here

[mananjadhav]

@stephanieelliott @bondya Wanted to raise this if we can payout the full amount on this one? The regression (which was fixed via some PR), couldn't be tested by me because we don't have physical build access. Hence it wasn't possible to identify the regression at all.

Also tagging @mountiny as they helped with the iOS QA.

[mountiny]

I think it makes sense to not give penalty if C+ could not catch this.

Can you not build even from XCode with the automatic certificate?

[mananjadhav]

Can you not build even from XCode with the automatic certificate?

No. and I tried multiple attempts for the adhoc build.

[mountiny]

I think thats legit

[stephanieelliott]

Sounds good-- updated the payment summary here!

• Issue reporter: N/A
• Contributor: @dukenv0307 $500, PAID via Upwork
• Contributor+: @mananjadhav $500, request via NewDot

[JmillsExpensify]

$500 payment approved for @mananjadhav based on summary above.